Re: Review Request 47474: Windows: Disabled signal handlers in logging.cpp.

2016-05-30 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47474/#review135570
---




src/logging/logging.cpp (line 202)


indentation.


- Joris Van Remoortere


On May 20, 2016, 12:04 a.m., Daniel Pravat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47474/
> ---
> 
> (Updated May 20, 2016, 12:04 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Artem Harutyunyan, Joris Van 
> Remoortere, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Disabled signal handlers in logging.cpp.
> 
> 
> Diffs
> -
> 
>   src/logging/logging.cpp 20d2f6341bd39fc5d056f1046d258d006fc602e4 
> 
> Diff: https://reviews.apache.org/r/47474/diff/
> 
> 
> Testing
> ---
> 
> Windows: build/run
> OSX: make check
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>

Re: Review Request 47474: Windows: Disabled signal handlers in logging.cpp.

2016-05-19 Thread Daniel Pravat 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47474/
---

(Updated May 20, 2016, 12:04 a.m.)


Review request for mesos, Alex Naparu, Artem Harutyunyan, Joris Van Remoortere, 
and Michael Park.


Repository: mesos


Description
---

Windows: Disabled signal handlers in logging.cpp.


Diffs (updated)
-

  src/logging/logging.cpp 20d2f6341bd39fc5d056f1046d258d006fc602e4 

Diff: https://reviews.apache.org/r/47474/diff/


Testing
---

Windows: build/run
OSX: make check


Thanks,

Daniel Pravat

Re: Review Request 47474: Windows: Disabled signal handlers in logging.cpp.

2016-05-17 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47474/#review133633
---


Fix it, then Ship it!





src/logging/logging.cpp (line 202)


Indentation. Missing period `.`. Please put backticks around 
`InstallFailureSignalHandler`. No need for the `()` in 
`InstallFailureSignalHandler()`.



src/logging/logging.cpp (lines 208 - 212)


indentation.


- Joris Van Remoortere


On May 17, 2016, 5:34 p.m., Daniel Pravat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47474/
> ---
> 
> (Updated May 17, 2016, 5:34 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Artem Harutyunyan, Joris Van 
> Remoortere, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Disabled signal handlers in logging.cpp.
> 
> 
> Diffs
> -
> 
>   src/logging/logging.cpp 20d2f6341bd39fc5d056f1046d258d006fc602e4 
> 
> Diff: https://reviews.apache.org/r/47474/diff/
> 
> 
> Testing
> ---
> 
> Windows: build/run
> OSX: make check
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>

Re: Review Request 47474: Windows: Disabled signal handlers in logging.cpp.

2016-05-17 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47474/#review133628
---



Patch looks great!

Reviews applied: [47473, 47474]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 17, 2016, 5:34 p.m., Daniel Pravat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47474/
> ---
> 
> (Updated May 17, 2016, 5:34 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Artem Harutyunyan, Joris Van 
> Remoortere, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Disabled signal handlers in logging.cpp.
> 
> 
> Diffs
> -
> 
>   src/logging/logging.cpp 20d2f6341bd39fc5d056f1046d258d006fc602e4 
> 
> Diff: https://reviews.apache.org/r/47474/diff/
> 
> 
> Testing
> ---
> 
> Windows: build/run
> OSX: make check
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>