Re: Review Request 51867: Add a member variable for the agent's total resources.

[Jiang Yan Xu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51867/
---

(Updated Sept. 16, 2016, 11:23 a.m.)


Review request for mesos, Anindya Sinha and Neil Conway.


Changes
---

Comments. NNFR.


Bugs: MESOS-4668
https://issues.apache.org/jira/browse/MESOS-4668


Repository: mesos


Description
---

`totalResources` is updated by CheckpointResourcesMessages and doesn't
have to be re-calculated in Slave::usage(). This change allows us to
expose `totalResources` for other purposes as well.


Diffs (updated)
-

  src/slave/slave.hpp 13c76d1eaea2b49519948c9116e5db5caf9407ea 
  src/slave/slave.cpp 7f99e4610d06ebadbef48ce314fec6ad04acb307 

Diff: https://reviews.apache.org/r/51867/diff/


Testing
---

make check.


Thanks,

Jiang Yan Xu

Re: Review Request 51867: Add a member variable for the agent's total resources.

[Jiang Yan Xu]

> On Sept. 14, 2016, 4:56 p.m., Anindya Sinha wrote:
> > src/slave/slave.hpp, line 671
> > 
> >
> > nitpik: totalResources is the same as `info.resources()` with 
> > checkpointed resources applied (and nothing else). So, how about:
> > 
> > s/includes/is the same as

To say it's "the same" we have to emphasize "quantity" but for brevity I just 
did

s/It includes/i.e.,/


- Jiang Yan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51867/#review149000
---


On Sept. 14, 2016, 11:21 a.m., Jiang Yan Xu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51867/
> ---
> 
> (Updated Sept. 14, 2016, 11:21 a.m.)
> 
> 
> Review request for mesos, Anindya Sinha and Neil Conway.
> 
> 
> Bugs: MESOS-4668
> https://issues.apache.org/jira/browse/MESOS-4668
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> `totalResources` is updated by CheckpointResourcesMessages and doesn't
> have to be re-calculated in Slave::usage(). This change allows us to
> expose `totalResources` for other purposes as well.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.hpp e659c44fcc415f10a6980e7b29cc1ce536dfe657 
>   src/slave/slave.cpp 2c7b5ada1aa81babb9ceee0c9f928685878a778c 
> 
> Diff: https://reviews.apache.org/r/51867/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 51867: Add a member variable for the agent's total resources.

[Anindya Sinha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51867/#review149000
---


Fix it, then Ship it!




Ship It!


src/slave/slave.hpp (line 671)


nitpik: totalResources is the same as `info.resources()` with checkpointed 
resources applied (and nothing else). So, how about:

s/includes/is the same as


- Anindya Sinha


On Sept. 14, 2016, 6:21 p.m., Jiang Yan Xu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51867/
> ---
> 
> (Updated Sept. 14, 2016, 6:21 p.m.)
> 
> 
> Review request for mesos, Anindya Sinha and Neil Conway.
> 
> 
> Bugs: MESOS-4668
> https://issues.apache.org/jira/browse/MESOS-4668
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> `totalResources` is updated by CheckpointResourcesMessages and doesn't
> have to be re-calculated in Slave::usage(). This change allows us to
> expose `totalResources` for other purposes as well.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.hpp e659c44fcc415f10a6980e7b29cc1ce536dfe657 
>   src/slave/slave.cpp 2c7b5ada1aa81babb9ceee0c9f928685878a778c 
> 
> Diff: https://reviews.apache.org/r/51867/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 51867: Add a member variable for the agent's total resources.

[Jiang Yan Xu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51867/
---

(Updated Sept. 14, 2016, 9:34 a.m.)


Review request for mesos, Anindya Sinha and Neil Conway.


Bugs: MESOS-4668
https://issues.apache.org/jira/browse/MESOS-4668


Repository: mesos


Description
---

`totalResources` is updated by CheckpointResourcesMessages and doesn't
have to be re-calculated in Slave::usage(). This change allows us to
expose `totalResources` for other purposes as well.


Diffs
-

  src/slave/slave.hpp e659c44fcc415f10a6980e7b29cc1ce536dfe657 
  src/slave/slave.cpp 2c7b5ada1aa81babb9ceee0c9f928685878a778c 

Diff: https://reviews.apache.org/r/51867/diff/


Testing
---

make check.


Thanks,

Jiang Yan Xu