Re: Review Request 51953: Changed registrar operations to no longer depend on "strict" flag.

2016-09-16 Thread Neil Conway
> On Sept. 16, 2016, 7:01 p.m., Vinod Kone wrote: > > src/master/master.hpp, line 1935 > > > > > > looks like our style is to add a comment about the unused parameter. > > > > https://github.com/apache/meso

Re: Review Request 51953: Changed registrar operations to no longer depend on "strict" flag.

2016-09-16 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51953/ --- (Updated Sept. 16, 2016, 7:15 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 51953: Changed registrar operations to no longer depend on "strict" flag.

2016-09-16 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51953/#review149241 --- src/master/master.hpp (line 1935)

Re: Review Request 51953: Changed registrar operations to no longer depend on "strict" flag.

2016-09-16 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51953/#review149232 --- Fix it, then Ship it! src/master/master.hpp (line 2136)