Re: Review Request 52148: Added support for killing child containers to the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52148/ --- (Updated Sept. 26, 2016, 10:33 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 52148: Added support for killing child containers to the default executor.

> On Sept. 26, 2016, 4:45 p.m., Vinod Kone wrote: > > src/launcher/default_executor.cpp, line 389 > > > > > > sorry, missed it earlier; why should shutdown be ignored if no task > > group is launched? > > > >

Re: Review Request 52148: Added support for killing child containers to the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52148/#review150411 --- Fix it, then Ship it! src/launcher/default_executor.cpp (line

Re: Review Request 52148: Added support for killing child containers to the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52148/ --- (Updated Sept. 25, 2016, 10:05 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 52148: Added support for killing child containers to the default executor.

> On Sept. 24, 2016, 9:40 p.m., Vinod Kone wrote: > > src/launcher/default_executor.cpp, line 492 > > > > > > why VLOG instead of LOG(ERROR)? hmm, this can happen if the container terminated _just_ before the schedu

Re: Review Request 52148: Added support for killing child containers to the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52148/ --- (Updated Sept. 25, 2016, 9:38 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 52148: Added support for killing child containers to the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52148/#review150315 --- src/launcher/default_executor.cpp (line 368)

Re: Review Request 52148: Added support for killing child containers to the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52148/ --- (Updated Sept. 23, 2016, 3:28 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 52148: Added support for killing child containers to the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52148/ --- (Updated Sept. 22, 2016, 7:33 p.m.) Review request for mesos and Vinod Kone.