Re: Review Request 52639: Added test for `recovered` AgentID and `AGENT_ADDED` after reregister.

2017-01-03 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52639/#review160402 --- Fix it, then Ship it! Looks good minus a few minor issues. I wo

Re: Review Request 52639: Added test for `recovered` AgentID and `AGENT_ADDED` after reregister.

2016-12-30 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52639/ --- (Updated Dec. 30, 2016, 11:05 p.m.) Review request for mesos, Anand Mazumdar, X

Re: Review Request 52639: Added test for `recovered` AgentID and `AGENT_ADDED` after reregister.

2016-12-27 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52639/#review160203 --- Looks good minus a comment around simplifying the `GetRecoveredAge

Re: Review Request 52639: Added test for `recovered` AgentID and `AGENT_ADDED` after reregister.

2016-12-13 Thread Zhitao Li
> On Dec. 13, 2016, 12:47 a.m., Anand Mazumdar wrote: > > src/tests/api_tests.cpp, line 1493 > > > > > > Can you do this outside of this scope as it's common to all subsequent > > blocks? It would then be consisten

Re: Review Request 52639: Added test for `recovered` AgentID and `AGENT_ADDED` after reregister.

2016-12-13 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52639/ --- (Updated Dec. 14, 2016, 4:49 a.m.) Review request for mesos, Anand Mazumdar, Xi

Re: Review Request 52639: Added test for `recovered` AgentID and `AGENT_ADDED` after reregister.

2016-12-12 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52639/#review158935 --- Did an initial pass on the test. Refer to my comments around split

Re: Review Request 52639: Added test for `recovered` AgentID and `AGENT_ADDED` after reregister.

2016-11-01 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52639/ --- (Updated Nov. 1, 2016, 5:30 p.m.) Review request for mesos, Anand Mazumdar, Xia

Re: Review Request 52639: Added test for `recovered` AgentID and `AGENT_ADDED` after reregister.

2016-10-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52639/#review153606 --- Patch looks great! Reviews applied: [53095, 52637, 52638, 52765,

Re: Review Request 52639: Added test for `recovered` AgentID and `AGENT_ADDED` after reregister.

2016-10-21 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52639/ --- (Updated Oct. 21, 2016, 6:41 p.m.) Review request for mesos, Anand Mazumdar, Xi

Re: Review Request 52639: Added test for `recovered` AgentID and `AGENT_ADDED` after reregister.

2016-10-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52639/#review152290 --- Patch looks great! Reviews applied: [52637, 52638, 52765, 52639]

Re: Review Request 52639: Added test for `recovered` AgentID and `AGENT_ADDED` after reregister.

2016-10-11 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52639/ --- (Updated Oct. 12, 2016, 12:18 a.m.) Review request for mesos, Anand Mazumdar an

Re: Review Request 52639: Added test for `recovered` AgentID and `AGENT_ADDED` after reregister.

2016-10-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52639/#review151899 --- Patch looks great! Reviews applied: [52637, 52638, 52639] Passed