Re: Review Request 52682: Cleaned up a few style issues in the capabilities isolator tests.

[Jie Yu]

> On Oct. 17, 2016, 10:02 p.m., Jie Yu wrote:
> > src/tests/containerizer/linux_capabilities_isolator_tests.cpp, line 100
> > 
> >
> > const UsaImage&
> 
> Benjamin Bannier wrote:
> I believe we always pass fundamental types like this enum by value. This 
> one here is almost certainly not bigger than a pointer. Can we just drop 
> this, or would you like me to collect a list of examples in the code base?

IC, sounds good.


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52682/#review152968
---


On Oct. 18, 2016, 8:48 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52682/
> ---
> 
> (Updated Oct. 18, 2016, 8:48 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We remove an unused using declaration, and replace several bool
> parameters with more readable enum values.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/linux_capabilities_isolator_tests.cpp 
> edb46659324c4c6345606cfa4c19f4fce05c59fe 
> 
> Diff: https://reviews.apache.org/r/52682/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 52682: Cleaned up a few style issues in the capabilities isolator tests.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52682/#review153081
---



Patch looks great!

Reviews applied: [52682]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Oct. 18, 2016, 8:48 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52682/
> ---
> 
> (Updated Oct. 18, 2016, 8:48 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We remove an unused using declaration, and replace several bool
> parameters with more readable enum values.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/linux_capabilities_isolator_tests.cpp 
> edb46659324c4c6345606cfa4c19f4fce05c59fe 
> 
> Diff: https://reviews.apache.org/r/52682/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 52682: Cleaned up a few style issues in the capabilities isolator tests.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52682/
---

(Updated Oct. 18, 2016, 10:48 a.m.)


Review request for mesos and Jie Yu.


Changes
---

Renamed some test parameters.


Repository: mesos


Description
---

We remove an unused using declaration, and replace several bool
parameters with more readable enum values.


Diffs (updated)
-

  src/tests/containerizer/linux_capabilities_isolator_tests.cpp 
edb46659324c4c6345606cfa4c19f4fce05c59fe 

Diff: https://reviews.apache.org/r/52682/diff/


Testing
---

make check


Thanks,

Benjamin Bannier

Re: Review Request 52682: Cleaned up a few style issues in the capabilities isolator tests.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52682/
---

(Updated Oct. 18, 2016, 8:59 a.m.)


Review request for mesos and Jie Yu.


Changes
---

Rebased.


Repository: mesos


Description
---

We remove an unused using declaration, and replace several bool
parameters with more readable enum values.


Diffs (updated)
-

  src/tests/containerizer/linux_capabilities_isolator_tests.cpp 
edb46659324c4c6345606cfa4c19f4fce05c59fe 

Diff: https://reviews.apache.org/r/52682/diff/


Testing
---

make check


Thanks,

Benjamin Bannier

Re: Review Request 52682: Cleaned up a few style issues in the capabilities isolator tests.

[Benjamin Bannier]

> On Oct. 18, 2016, 12:02 a.m., Jie Yu wrote:
> > src/tests/containerizer/linux_capabilities_isolator_tests.cpp, line 100
> > 
> >
> > const UsaImage&

I believe we always pass fundamental types like this enum by value. This one 
here is almost certainly not bigger than a pointer. Can we just drop this, or 
would you like me to collect a list of examples in the code base?


> On Oct. 18, 2016, 12:02 a.m., Jie Yu wrote:
> > src/tests/containerizer/linux_capabilities_isolator_tests.cpp, line 101
> > 
> >
> > const Result&

Dito.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52682/#review152968
---


On Oct. 18, 2016, 8:59 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52682/
> ---
> 
> (Updated Oct. 18, 2016, 8:59 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We remove an unused using declaration, and replace several bool
> parameters with more readable enum values.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/linux_capabilities_isolator_tests.cpp 
> edb46659324c4c6345606cfa4c19f4fce05c59fe 
> 
> Diff: https://reviews.apache.org/r/52682/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 52682: Cleaned up a few style issues in the capabilities isolator tests.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52682/#review152968
---


Fix it, then Ship it!





src/tests/containerizer/linux_capabilities_isolator_tests.cpp (line 99)


const UsaImage&



src/tests/containerizer/linux_capabilities_isolator_tests.cpp (line 100)


const Result&


- Jie Yu


On Oct. 10, 2016, 11:23 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52682/
> ---
> 
> (Updated Oct. 10, 2016, 11:23 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We remove an unused using declaration, and replace several bool
> parameters with more readable enum values.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/linux_capabilities_isolator_tests.cpp 
> f040c209b4b4c87cef00b0569b7da7581f4ccf03 
> 
> Diff: https://reviews.apache.org/r/52682/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>