Re: Review Request 52695: Harden libprocess

> On Nov. 2, 2016, 9:32 a.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/Makefile.am > > Lines 30 (patched) > > > > > > I am not a big fan of unconditionally omitting frame pointers as this > > gives the

Re: Review Request 52695: Harden libprocess

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52695/ --- (Updated Nov. 30, 2016, 8:52 p.m.) Review request for mesos, James Peach,

Re: Review Request 52695: Harden libprocess

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52695/ --- (Updated Nov. 30, 2016, 5:12 p.m.) Review request for mesos, James Peach,

Re: Review Request 52695: Harden libprocess

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52695/ --- (Updated Nov. 29, 2016, 4:26 p.m.) Review request for mesos, James Peach,

Re: Review Request 52695: Harden libprocess

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52695/#review156253 --- Ship it! Ship It! - Michael Park On Nov. 9, 2016, 11:07

Re: Review Request 52695: Harden libprocess

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52695/#review155491 --- Ship it! Lots great, thanks a lot. - Benjamin Bannier On

Re: Review Request 52695: Harden libprocess

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52695/ --- (Updated Nov. 9, 2016, 7:07 p.m.) Review request for mesos, James Peach,

Re: Review Request 52695: Harden libprocess

> On Nov. 2, 2016, 10:32 a.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/m4/ax_check_compile_flag.m4, line 1 > > > > > > For future updates it would be great if we'd write down the > > autoconf-archive release

Re: Review Request 52695: Harden libprocess

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52695/ --- (Updated Nov. 8, 2016, 5:41 p.m.) Review request for mesos, James Peach,

Re: Review Request 52695: Harden libprocess

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52695/ --- (Updated Nov. 7, 2016, 9:51 p.m.) Review request for mesos, James Peach,

Re: Review Request 52695: Harden libprocess

> On Nov. 2, 2016, 10:32 a.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/m4/ax_check_compile_flag.m4, line 1 > > > > > > For future updates it would be great if we'd write down the > > autoconf-archive release

Re: Review Request 52695: Harden libprocess

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52695/ --- (Updated Nov. 7, 2016, 9:30 p.m.) Review request for mesos, James Peach,

Re: Review Request 52695: Harden libprocess

> On Nov. 2, 2016, 9:32 a.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/Makefile.am, line 30 > > > > > > I am not a big fan of unconditionally omitting frame pointers as this > > gives the optimizer one less

Re: Review Request 52695: Harden libprocess

> On Nov. 2, 2016, 9:32 a.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/m4/ax_check_compile_flag.m4, line 1 > > > > > > For future updates it would be great if we'd write down the > > autoconf-archive release

Re: Review Request 52695: Harden libprocess

> On Nov. 2, 2016, 10:32 a.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/Makefile.am, line 30 > > > > > > I am not a big fan of unconditionally omitting frame pointers as this > > gives the optimizer one less

Re: Review Request 52695: Harden libprocess

> On Nov. 2, 2016, 9:32 a.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/Makefile.am, line 30 > > > > > > I am not a big fan of unconditionally omitting frame pointers as this > > gives the optimizer one less

Re: Review Request 52695: Harden libprocess

> On Nov. 2, 2016, 9:32 a.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/Makefile.am, line 29 > > > > > > Let's not suppress this valid and potentially useful diagnostic for the > > whole codebase. It does not

Re: Review Request 52695: Harden libprocess

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52695/ --- (Updated Nov. 2, 2016, 3:14 p.m.) Review request for mesos, James Peach,

Re: Review Request 52695: Harden libprocess

> On Nov. 2, 2016, 9:32 a.m., Benjamin Bannier wrote: > > I would really like to see actual timings of e.g., an optimized build > > before and after introducing these new flags, e.g., the runtime of > > `libprocess-tests` and `benchmarks`. Just attached a bunch of benchmarking info that I had

Re: Review Request 52695: Harden libprocess

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52695/#review154527 --- I would really like to see actual timings of e.g., an optimized

Re: Review Request 52695: Harden libprocess

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52695/#review154463 --- Ship it! Ship It! - James Peach On Nov. 1, 2016, 7:12 p.m.,

Re: Review Request 52695: Harden libprocess

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52695/ --- (Updated Nov. 1, 2016, 7:12 p.m.) Review request for mesos, James Peach,

Re: Review Request 52695: Harden libprocess

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52695/ --- (Updated Oct. 14, 2016, 3:20 p.m.) Review request for mesos, Michael Park and

Re: Review Request 52695: Harden libprocess

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52695/#review152315 --- 3rdparty/libprocess/Makefile.am (line 29)

Re: Review Request 52695: Harden libprocess

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52695/ --- (Updated Oct. 11, 2016, 10:47 p.m.) Review request for mesos and Michael Park.

Re: Review Request 52695: Harden libprocess

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52695/ --- (Updated Oct. 10, 2016, 7:52 p.m.) Review request for mesos and Michael Park.

Re: Review Request 52695: Harden libprocess

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52695/#review152028 --- 3rdparty/libprocess/Makefile.am (line 16)