-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52695/
-----------------------------------------------------------
(Updated Oct. 10, 2016, 7:52 p.m.)
Review request for mesos and Michael Park.
Changes
-------
Fix spelling and clarify comment about `-Wall`.
Bugs: MESOS-6229
https://issues.apache.org/jira/browse/MESOS-6229
Repository: mesos
Description
-------
Use a default set of flags to provide additional security and hardening to
libprocess. Additionally, check and catch more warnings/errors.
Diffs (updated)
-----
3rdparty/libprocess/Makefile.am 020b0e1
Diff: https://reviews.apache.org/r/52695/diff/
Testing
-------
Compared the benchmarks with and without the flags being used. Also did a
comparsion with the flags being used with and without optimizations and without
the flags being used with and without optimizations. Overall the performance
hit was very small with a 3-8% overhead (optimizations brings this down
slightly). Most benchmarks were about 5% (or less) slower.
Thanks,
Aaron Wood
