Re: Review Request 52696: Harden stout

2016-11-30 Thread Aaron Wood
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52696/ --- (Updated Nov. 30, 2016, 8:50 p.m.) Review request for mesos, James Peach,

Re: Review Request 52696: Harden stout

2016-11-30 Thread Aaron Wood
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52696/ --- (Updated Nov. 30, 2016, 5:10 p.m.) Review request for mesos, James Peach,

Re: Review Request 52696: Harden stout

2016-11-29 Thread Aaron Wood
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52696/ --- (Updated Nov. 29, 2016, 4:24 p.m.) Review request for mesos, James Peach,

Re: Review Request 52696: Harden stout

2016-11-17 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52696/#review156252 --- Ship it! Ship It! - Michael Park On Nov. 9, 2016, 11:05

Re: Review Request 52696: Harden stout

2016-11-09 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52696/#review155490 --- Ship it! Lots great, thanks a lot. - Benjamin Bannier On

Re: Review Request 52696: Harden stout

2016-11-09 Thread Aaron Wood
> On Nov. 2, 2016, 9:33 a.m., Benjamin Bannier wrote: > > 3rdparty/stout/m4/ax_check_compile_flag.m4, line 1 > > > > > > For future updates it would be great if we'd write down the > > autoconf-archive release this

Re: Review Request 52696: Harden stout

2016-11-09 Thread Aaron Wood
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52696/ --- (Updated Nov. 9, 2016, 7:05 p.m.) Review request for mesos, James Peach,

Re: Review Request 52696: Harden stout

2016-11-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52696/#review155415 --- Patch looks great! Reviews applied: [52647, 52886, 52754, 52645,

Re: Review Request 52696: Harden stout

2016-11-08 Thread Benjamin Bannier
> On Nov. 2, 2016, 10:33 a.m., Benjamin Bannier wrote: > > 3rdparty/stout/m4/ax_check_compile_flag.m4, line 1 > > > > > > For future updates it would be great if we'd write down the > > autoconf-archive release this

Re: Review Request 52696: Harden stout

2016-11-08 Thread Aaron Wood
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52696/ --- (Updated Nov. 8, 2016, 5:41 p.m.) Review request for mesos, James Peach,

Re: Review Request 52696: Harden stout

2016-11-07 Thread Aaron Wood
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52696/ --- (Updated Nov. 7, 2016, 9:52 p.m.) Review request for mesos, James Peach,

Re: Review Request 52696: Harden stout

2016-11-07 Thread Aaron Wood
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52696/ --- (Updated Nov. 7, 2016, 9:27 p.m.) Review request for mesos, James Peach,

Re: Review Request 52696: Harden stout

2016-11-07 Thread Aaron Wood
> On Nov. 2, 2016, 9:33 a.m., Benjamin Bannier wrote: > > 3rdparty/stout/Makefile.am, line 27 > > > > > > I am not a big fan of unconditionally omitting frame pointers as this > > gives the optimizer one less

Re: Review Request 52696: Harden stout

2016-11-02 Thread Aaron Wood
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52696/ --- (Updated Nov. 2, 2016, 3:35 p.m.) Review request for mesos, James Peach,

Re: Review Request 52696: Harden stout

2016-11-02 Thread Aaron Wood
> On Nov. 2, 2016, 9:33 a.m., Benjamin Bannier wrote: > > I would really like to see actual timings of e.g., an optimized build > > before and after introducing these new flags, e.g., the runtime of > > `stout-tests`. Just attached a bunch of benchmarking info that I had saved from when I

Re: Review Request 52696: Harden stout

2016-11-02 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52696/#review154526 --- I would really like to see actual timings of e.g., an optimized

Re: Review Request 52696: Harden stout

2016-11-01 Thread Aaron Wood
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52696/ --- (Updated Nov. 1, 2016, 7:10 p.m.) Review request for mesos, James Peach,

Re: Review Request 52696: Harden stout

2016-10-25 Thread Aaron Wood
> On Oct. 18, 2016, 3:15 a.m., James Peach wrote: > > 3rdparty/stout/Makefile.am, line 27 > > > > > > Where does ``VARIANTS`` come from? I need to fix this. I wrongly thought VARIANTS was something that was set

Re: Review Request 52696: Harden stout

2016-10-17 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52696/#review153025 --- 3rdparty/stout/Makefile.am (line 27)

Re: Review Request 52696: Harden stout

2016-10-14 Thread Aaron Wood
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52696/ --- (Updated Oct. 14, 2016, 3:20 p.m.) Review request for mesos, Michael Park and

Re: Review Request 52696: Harden stout

2016-10-12 Thread Aaron Wood
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52696/#review152316 --- 3rdparty/stout/Makefile.am (line 26)

Re: Review Request 52696: Harden stout

2016-10-11 Thread Aaron Wood
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52696/ --- (Updated Oct. 11, 2016, 10:47 p.m.) Review request for mesos and Michael Park.

Re: Review Request 52696: Harden stout

2016-10-10 Thread Aaron Wood
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52696/ --- (Updated Oct. 10, 2016, 7:53 p.m.) Review request for mesos and Michael Park.