Re: Review Request 52879: Updated the way in which the default and command executors load options.

2016-10-17 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52879/#review152940 --- src/launcher/default_executor.cpp (lines 1015 - 1042)

Re: Review Request 52879: Updated the way in which the default and command executors load options.

2016-10-17 Thread haosdent huang
> On Oct. 17, 2016, 5:52 p.m., haosdent huang wrote: > > src/launcher/default_executor.cpp, line 1034 > > > > > > Let's use `agent_pid` here? Since we rename slave to agent. > > haosdent huang wrote: > hmm, I s

Re: Review Request 52879: Updated the way in which the default and command executors load options.

2016-10-17 Thread haosdent huang
> On Oct. 17, 2016, 5:52 p.m., haosdent huang wrote: > > src/launcher/default_executor.cpp, line 1034 > > > > > > Let's use `agent_pid` here? Since we rename slave to agent. hmm, I saw we still use `slave_pid` in t

Re: Review Request 52879: Updated the way in which the default and command executors load options.

2016-10-17 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52879/#review152914 --- Do you forget to update the `MESOS_EXECUTOR_SHUTDOWN_GRACE_PERIOD`

Re: Review Request 52879: Updated the way in which the default and command executors load options.

2016-10-17 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52879/#review152909 --- The length of the commit message greater than 72, I think it could