Re: Review Request 54295: Added a synchronous version of loop for io::read/write/redirect.

2016-12-05 Thread Benjamin Mahler
> On Dec. 6, 2016, 2:12 a.m., Benjamin Mahler wrote: > > Is it possible to split the optional pid change from the discard logic > > change? If so that would be great! > > > > Looks like a chunk from the next patch slipped into this one? Also, would be great to update the description to say

Re: Review Request 54295: Added a synchronous version of loop for io::read/write/redirect.

2016-12-05 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54295/#review158095 --- Fix it, then Ship it! Is it possible to split the optional pid

Re: Review Request 54295: Added a synchronous version of loop for io::read/write/redirect.

2016-12-04 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54295/ --- (Updated Dec. 5, 2016, 4:35 a.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 54295: Added a synchronous version of loop for io::read/write/redirect.

2016-12-02 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54295/#review157814 --- Fix it, then Ship it!

Re: Review Request 54295: Added a synchronous version of loop for io::read/write/redirect.

2016-12-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54295/#review157754 --- Patch looks great! Reviews applied: [54295] Passed command: