Re: Review Request 55242: Stop using os::system to chown a directory hierarchy.

2017-01-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55242/#review162009 --- Patch looks great! Reviews applied: [55238, 55239, 55240, 55241,

Re: Review Request 55242: Stop using os::system to chown a directory hierarchy.

2017-01-17 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55242/ --- (Updated Jan. 17, 2017, 10:06 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 55242: Stop using os::system to chown a directory hierarchy.

2017-01-17 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55242/#review161659 --- Fix it, then Ship it! Just some style nits.

Re: Review Request 55242: Stop using os::system to chown a directory hierarchy.

2017-01-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55242/#review161636 --- Bad patch! Reviews applied: [55238, 55239, 55240, 55241, 55242]

Re: Review Request 55242: Stop using os::system to chown a directory hierarchy.

2017-01-13 Thread James Peach
> On Jan. 13, 2017, 8:27 a.m., Jiang Yan Xu wrote: > > 3rdparty/stout/tests/os_tests.cpp, line 751 > > > > > > s/tree/subtree/? This commend looks correct to me. - James

Re: Review Request 55242: Stop using os::system to chown a directory hierarchy.

2017-01-13 Thread James Peach
> On Jan. 13, 2017, 8:27 a.m., Jiang Yan Xu wrote: > > 3rdparty/stout/tests/os_tests.cpp, line 751 > > > > > > s/tree/subtree/? This commend looks correct to me. - James

Re: Review Request 55242: Stop using os::system to chown a directory hierarchy.

2017-01-13 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55242/ --- (Updated Jan. 13, 2017, 11:12 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 55242: Stop using os::system to chown a directory hierarchy.

2017-01-13 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55242/#review161413 --- 3rdparty/stout/include/stout/os/posix/chown.hpp (lines 36 - 42)

Re: Review Request 55242: Stop using os::system to chown a directory hierarchy.

2017-01-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55242/#review161344 --- Patch looks great! Reviews applied: [55238, 55239, 55240, 55241,

Re: Review Request 55242: Stop using os::system to chown a directory hierarchy.

2017-01-11 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55242/ --- (Updated Jan. 12, 2017, 12:29 a.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 55242: Stop using os::system to chown a directory hierarchy.

2017-01-11 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55242/#review161199 --- If we implement the recursive chown this way, I feel that we need

Re: Review Request 55242: Stop using os::system to chown a directory hierarchy.

2017-01-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55242/#review160699 --- Patch looks great! Reviews applied: [55238, 55239, 55240, 55241,