Re: Review Request 55490: Used the `mesos/mesos-tidy` image from DockerHub.

2017-01-19 Thread Benjamin Bannier
> On Jan. 15, 2017, 10:55 a.m., Benjamin Bannier wrote: > > This is great. Could you make sure to follow up with setting > > `mesos/mesos-tidy` up for automated builds? Before building the image in > > the dockerhub time constraints was hard, but I am optimistic this would > > work now with

Re: Review Request 55490: Used the `mesos/mesos-tidy` image from DockerHub.

2017-01-18 Thread Benjamin Bannier
> On Jan. 18, 2017, 1:53 p.m., Benjamin Bannier wrote: > > support/mesos-tidy.sh, line 22 > > > > > > Let's keep this further down so to not take away from `CHECKS` > > prominence. Any reason we'd want to deviate

Re: Review Request 55490: Used the `mesos/mesos-tidy` image from DockerHub.

2017-01-18 Thread Michael Park
> On Jan. 18, 2017, 4:53 a.m., Benjamin Bannier wrote: > > support/mesos-tidy.sh, line 22 > > > > > > Let's keep this further down so to not take away from `CHECKS` > > prominence. Any reason we'd want to deviate

Re: Review Request 55490: Used the `mesos/mesos-tidy` image from DockerHub.

2017-01-18 Thread Michael Park
> On Jan. 18, 2017, 4:53 a.m., Benjamin Bannier wrote: > > support/mesos-tidy.sh, line 22 > > > > > > Let's keep this further down so to not take away from `CHECKS` > > prominence. Any reason we'd want to deviate

Re: Review Request 55490: Used the `mesos/mesos-tidy` image from DockerHub.

2017-01-18 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55490/#review162095 --- Ship it! Modulo my comments. - Benjamin Bannier On Jan. 18,

Re: Review Request 55490: Used the `mesos/mesos-tidy` image from DockerHub.

2017-01-18 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55490/#review162068 --- support/mesos-tidy.sh (line 22)

Re: Review Request 55490: Used the `mesos/mesos-tidy` image from DockerHub.

2017-01-18 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55490/ --- (Updated Jan. 18, 2017, 12:58 a.m.) Review request for mesos and Benjamin

Re: Review Request 55490: Used the `mesos/mesos-tidy` image from DockerHub.

2017-01-17 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55490/ --- (Updated Jan. 17, 2017, 6:34 p.m.) Review request for mesos and Benjamin

Re: Review Request 55490: Used the `mesos/mesos-tidy` image from DockerHub.

2017-01-17 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55490/ --- (Updated Jan. 17, 2017, 6:34 p.m.) Review request for mesos and Benjamin

Re: Review Request 55490: Used the `mesos/mesos-tidy` image from DockerHub.

2017-01-17 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55490/ --- (Updated Jan. 17, 2017, 3:56 p.m.) Review request for mesos and Benjamin

Re: Review Request 55490: Used the `mesos/mesos-tidy` image from DockerHub.

2017-01-17 Thread Michael Park
> On Jan. 15, 2017, 1:55 a.m., Benjamin Bannier wrote: > > support/mesos-tidy.sh, line 43 > > > > > > Removing the image sure made sense for an always regenerated image, but > > does it also for a relatively static

Re: Review Request 55490: Used the `mesos/mesos-tidy` image from DockerHub.

2017-01-17 Thread Michael Park
> On Jan. 15, 2017, 1:55 a.m., Benjamin Bannier wrote: > > support/mesos-tidy.sh, line 43 > > > > > > Removing the image sure made sense for an always regenerated image, but > > does it also for a relatively static

Re: Review Request 55490: Used the `mesos/mesos-tidy` image from DockerHub.

2017-01-15 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55490/#review161660 --- Fix it, then Ship it! This is great. Could you make sure to

Re: Review Request 55490: Used the `mesos/mesos-tidy` image from DockerHub.

2017-01-14 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55490/ --- (Updated Jan. 14, 2017, 12:02 p.m.) Review request for mesos and Benjamin

Re: Review Request 55490: Used the `mesos/mesos-tidy` image from DockerHub.

2017-01-13 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55490/ --- (Updated Jan. 13, 2017, 2 a.m.) Review request for mesos and Benjamin Bannier.