Re: Review Request 56666: Added a HMAC SHA256 generator.

2017-03-09 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5/#review168546
---


Ship it!




Ship It!

- Vinod Kone


On March 8, 2017, 2:11 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5/
> ---
> 
> (Updated March 8, 2017, 2:11 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Greg Mann.
> 
> 
> Bugs: MESOS-7001
> https://issues.apache.org/jira/browse/MESOS-7001
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> HMAC SHA256 can be used to create or verify message signatures.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/ssl/utilities.hpp 
> c2f64a91a505675d568ddf5aa081125e4e32fe17 
>   3rdparty/libprocess/src/ssl/utilities.cpp 
> 8aec613312eee3dd11d9df8c3828a5185407e073 
> 
> 
> Diff: https://reviews.apache.org/r/5/diff/6/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 56666: Added a HMAC SHA256 generator.

2017-03-08 Thread Jan Schlicht 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5/
---

(Updated March 8, 2017, 3:11 p.m.)


Review request for mesos, Alexander Rojas and Greg Mann.


Changes
---

Addressed issues.


Bugs: MESOS-7001
https://issues.apache.org/jira/browse/MESOS-7001


Repository: mesos


Description
---

HMAC SHA256 can be used to create or verify message signatures.


Diffs (updated)
-

  3rdparty/libprocess/include/process/ssl/utilities.hpp 
c2f64a91a505675d568ddf5aa081125e4e32fe17 
  3rdparty/libprocess/src/ssl/utilities.cpp 
8aec613312eee3dd11d9df8c3828a5185407e073 


Diff: https://reviews.apache.org/r/5/diff/6/

Changes: https://reviews.apache.org/r/5/diff/5-6/


Testing
---

make check


Thanks,

Jan Schlicht

Re: Review Request 56666: Added a HMAC SHA256 generator.

2017-03-07 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5/#review168184
---




3rdparty/libprocess/src/ssl/utilities.cpp
Lines 363 (patched)


if reason is nullptr the error shows up as "HMAC failed: " which is weird.

how about

```
return Error(
   "HMAC failed" + (reason == nultpr ? "" : ": " + std::string(reason)));

```


- Vinod Kone


On March 7, 2017, 3:34 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5/
> ---
> 
> (Updated March 7, 2017, 3:34 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Greg Mann.
> 
> 
> Bugs: MESOS-7001
> https://issues.apache.org/jira/browse/MESOS-7001
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> HMAC SHA256 can be used to create or verify message signatures.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/ssl/utilities.hpp 
> c2f64a91a505675d568ddf5aa081125e4e32fe17 
>   3rdparty/libprocess/src/ssl/utilities.cpp 
> 8aec613312eee3dd11d9df8c3828a5185407e073 
> 
> 
> Diff: https://reviews.apache.org/r/5/diff/5/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 56666: Added a HMAC SHA256 generator.

2017-03-07 Thread Jan Schlicht 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5/
---

(Updated March 7, 2017, 4:34 p.m.)


Review request for mesos, Alexander Rojas and Greg Mann.


Changes
---

Fixed a typo.


Bugs: MESOS-7001
https://issues.apache.org/jira/browse/MESOS-7001


Repository: mesos


Description
---

HMAC SHA256 can be used to create or verify message signatures.


Diffs (updated)
-

  3rdparty/libprocess/include/process/ssl/utilities.hpp 
c2f64a91a505675d568ddf5aa081125e4e32fe17 
  3rdparty/libprocess/src/ssl/utilities.cpp 
8aec613312eee3dd11d9df8c3828a5185407e073 


Diff: https://reviews.apache.org/r/5/diff/5/

Changes: https://reviews.apache.org/r/5/diff/4-5/


Testing
---

make check


Thanks,

Jan Schlicht

Re: Review Request 56666: Added a HMAC SHA256 generator.

2017-03-06 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5/#review168036
---


Fix it, then Ship it!





3rdparty/libprocess/include/process/ssl/utilities.hpp
Lines 115 (patched)


s/hase/hash/


- Greg Mann


On March 3, 2017, 2:02 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5/
> ---
> 
> (Updated March 3, 2017, 2:02 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Greg Mann.
> 
> 
> Bugs: MESOS-7001
> https://issues.apache.org/jira/browse/MESOS-7001
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> HMAC SHA256 can be used to create or verify message signatures.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/ssl/utilities.hpp 
> c2f64a91a505675d568ddf5aa081125e4e32fe17 
>   3rdparty/libprocess/src/ssl/utilities.cpp 
> 8aec613312eee3dd11d9df8c3828a5185407e073 
> 
> 
> Diff: https://reviews.apache.org/r/5/diff/4/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 56666: Added a HMAC SHA256 generator.

2017-03-03 Thread Jan Schlicht 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5/
---

(Updated March 3, 2017, 3:02 p.m.)


Review request for mesos, Alexander Rojas and Greg Mann.


Changes
---

Addressed issues.


Bugs: MESOS-7001
https://issues.apache.org/jira/browse/MESOS-7001


Repository: mesos


Description
---

HMAC SHA256 can be used to create or verify message signatures.


Diffs (updated)
-

  3rdparty/libprocess/include/process/ssl/utilities.hpp 
c2f64a91a505675d568ddf5aa081125e4e32fe17 
  3rdparty/libprocess/src/ssl/utilities.cpp 
8aec613312eee3dd11d9df8c3828a5185407e073 


Diff: https://reviews.apache.org/r/5/diff/4/

Changes: https://reviews.apache.org/r/5/diff/3-4/


Testing
---

make check


Thanks,

Jan Schlicht

Re: Review Request 56666: Added a HMAC SHA256 generator.

2017-02-28 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5/#review167170
---




3rdparty/libprocess/include/process/ssl/utilities.hpp (lines 114 - 122)


In this comment, it might be good to introduce HMAC by saying "Generates a 
keyed-hash message authentication code (HMAC) with SHA256."

Then, you can use "HMAC" in the `@return` comment below.



3rdparty/libprocess/include/process/ssl/utilities.hpp (lines 124 - 125)


Could we use `key` instead of `secret` for the second parameter name here? 
Seems more consistent with the terminology in this file, as well as the OpenSSL 
library.

I also have a slight preference for `message` instead of `input`, but up to 
you.


- Greg Mann


On Feb. 27, 2017, 11:37 a.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5/
> ---
> 
> (Updated Feb. 27, 2017, 11:37 a.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Greg Mann.
> 
> 
> Bugs: MESOS-7001
> https://issues.apache.org/jira/browse/MESOS-7001
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> HMAC SHA256 can be used to create or verify message signatures.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/ssl/utilities.hpp 
> c2f64a91a505675d568ddf5aa081125e4e32fe17 
>   3rdparty/libprocess/src/ssl/utilities.cpp 
> 8aec613312eee3dd11d9df8c3828a5185407e073 
> 
> Diff: https://reviews.apache.org/r/5/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 56666: Added a HMAC SHA256 generator.

2017-02-22 Thread Jan Schlicht 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5/
---

(Updated Feb. 22, 2017, 3:25 p.m.)


Review request for mesos and Greg Mann.


Changes
---

Addressed issues.


Bugs: MESOS-7001
https://issues.apache.org/jira/browse/MESOS-7001


Repository: mesos


Description
---

HMAC SHA256 can be used to create or verify message signatures.


Diffs (updated)
-

  3rdparty/libprocess/include/process/ssl/utilities.hpp 
c2f64a91a505675d568ddf5aa081125e4e32fe17 
  3rdparty/libprocess/src/ssl/utilities.cpp 
8aec613312eee3dd11d9df8c3828a5185407e073 

Diff: https://reviews.apache.org/r/5/diff/


Testing
---

make check


Thanks,

Jan Schlicht

Re: Review Request 56666: Added a HMAC SHA256 generator.

2017-02-19 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5/#review166056
---




3rdparty/libprocess/include/process/ssl/utilities.hpp (line 119)


s/,/./


- Greg Mann


On Feb. 16, 2017, 9:34 a.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5/
> ---
> 
> (Updated Feb. 16, 2017, 9:34 a.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Bugs: MESOS-7001
> https://issues.apache.org/jira/browse/MESOS-7001
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> HMAC SHA256 can be used to create or verify message signatures.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/ssl/utilities.hpp 
> c2f64a91a505675d568ddf5aa081125e4e32fe17 
>   3rdparty/libprocess/src/ssl/utilities.cpp 
> 8aec613312eee3dd11d9df8c3828a5185407e073 
> 
> Diff: https://reviews.apache.org/r/5/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 56666: Added a HMAC SHA256 generator.

2017-02-16 Thread Jan Schlicht 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5/
---

(Updated Feb. 16, 2017, 10:34 a.m.)


Review request for mesos and Greg Mann.


Changes
---

Removed redundancy.


Summary (updated)
-

Added a HMAC SHA256 generator.


Bugs: MESOS-7001
https://issues.apache.org/jira/browse/MESOS-7001


Repository: mesos


Description (updated)
---

HMAC SHA256 can be used to create or verify message signatures.


Diffs (updated)
-

  3rdparty/libprocess/include/process/ssl/utilities.hpp 
c2f64a91a505675d568ddf5aa081125e4e32fe17 
  3rdparty/libprocess/src/ssl/utilities.cpp 
8aec613312eee3dd11d9df8c3828a5185407e073 

Diff: https://reviews.apache.org/r/5/diff/


Testing (updated)
---

make check


Thanks,

Jan Schlicht