Re: Review Request 61272: Added a MockResourceProvider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61272/ --- (Updated Aug. 18, 2017, 12:24 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 61272: Added a MockResourceProvider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61272/#review183099 --- Ship it! Ship It! - Jie Yu On Aug. 15, 2017, 12:05 p.m., Jan

Re: Review Request 61272: Added a MockResourceProvider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61272/ --- (Updated Aug. 15, 2017, 2:05 p.m.) Review request for mesos, Benjamin Bannier a

Re: Review Request 61272: Added a MockResourceProvider.

> On Aug. 1, 2017, 10:37 p.m., Jie Yu wrote: > > src/tests/mesos.hpp > > Lines 2287-2291 (patched) > > > > > > This is a bit counter intuitive. I was expecting that > > MockResourceProvider will take a real Driver:

Re: Review Request 61272: Added a MockResourceProvider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61272/ --- (Updated Aug. 7, 2017, 8:15 p.m.) Review request for mesos, Benjamin Bannier an

Re: Review Request 61272: Added a MockResourceProvider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61272/ --- (Updated Aug. 3, 2017, 4:28 p.m.) Review request for mesos, Benjamin Bannier an

Re: Review Request 61272: Added a MockResourceProvider.

> On Aug. 3, 2017, noon, Benjamin Bannier wrote: > > src/tests/mesos.hpp > > Lines 2301 (patched) > > > > > > How about passing this as an argument instead? It semantically belongs > > to the remote description we

Re: Review Request 61272: Added a MockResourceProvider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61272/#review182088 --- src/tests/mesos.hpp Lines 2258-2259 (patched)

Re: Review Request 61272: Added a MockResourceProvider.

> On Aug. 2, 2017, 12:37 a.m., Jie Yu wrote: > > src/tests/mesos.hpp > > Lines 2287-2291 (patched) > > > > > > This is a bit counter intuitive. I was expecting that > > MockResourceProvider will take a real Driver:

Re: Review Request 61272: Added a MockResourceProvider.

> On Aug. 1, 2017, 10:40 p.m., Jie Yu wrote: > > src/tests/mesos.hpp > > Lines 2255 (patched) > > > > > > I don't think we need a v0 MockResourceProvider. Let's just use v1 > > Jan Schlicht wrote: > This isn't

Re: Review Request 61272: Added a MockResourceProvider.

> On Aug. 1, 2017, 10:37 p.m., Jie Yu wrote: > > src/tests/mesos.hpp > > Lines 2287-2291 (patched) > > > > > > This is a bit counter intuitive. I was expecting that > > MockResourceProvider will take a real Driver:

Re: Review Request 61272: Added a MockResourceProvider.

> On Aug. 2, 2017, 12:40 a.m., Jie Yu wrote: > > src/tests/mesos.hpp > > Lines 2255 (patched) > > > > > > I don't think we need a v0 MockResourceProvider. Let's just use v1 This isn't a v0 MockResouceProvider, but

Re: Review Request 61272: Added a MockResourceProvider.

> On Aug. 2, 2017, 12:37 a.m., Jie Yu wrote: > > src/tests/mesos.hpp > > Lines 2287-2291 (patched) > > > > > > This is a bit counter intuitive. I was expecting that > > MockResourceProvider will take a real Driver:

Re: Review Request 61272: Added a MockResourceProvider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61272/ --- (Updated Aug. 2, 2017, 1:38 p.m.) Review request for mesos, Benjamin Bannier an

Re: Review Request 61272: Added a MockResourceProvider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61272/#review181923 --- src/tests/mesos.hpp Lines 2255 (patched)

Re: Review Request 61272: Added a MockResourceProvider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61272/#review181922 --- src/tests/mesos.hpp Lines 2287-2291 (patched)

Re: Review Request 61272: Added a MockResourceProvider.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61272/ --- (Updated Aug. 1, 2017, 4:06 p.m.) Review request for mesos, Benjamin Bannier an