Re: Review Request 62214: Added JavaScript linter.

2017-11-09 Thread Kevin Klues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62214/#review190597
---


Ship it!




Ship It!

- Kevin Klues


On Oct. 18, 2017, 9:23 a.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62214/
> ---
> 
> (Updated Oct. 18, 2017, 9:23 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Gaston Kleiman, and Kevin Klues.
> 
> 
> Bugs: MESOS-7924
> https://issues.apache.org/jira/browse/MESOS-7924
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The linter runs when changes on a JavaScript file are being committed.
> We use ESLint with a configuration based on our current JS code base.
> The linter and its dependencies (i.e. Node.js) are installed in a
> virtual environment using Virtualenv and then Nodeenv.
> 
> 
> Diffs
> -
> 
>   support/.eslintrc.js PRE-CREATION 
>   support/build-virtualenv b46a86a2604925f936bbb9d3414d5be3976836db 
>   support/mesos-style.py 96030f21c08d893d49471ff73f50d185afcd16d6 
>   support/pip-requirements.txt 6ae67d005e85a1334701e8f644e9c32dfd5f20a5 
> 
> 
> Diff: https://reviews.apache.org/r/62214/diff/9/
> 
> 
> Testing
> ---
> 
> ```
> $ make check
> ```
> 
> Following this commit, I have also tried to commit a change on a JavaScript 
> file and checked that ESLinter was correctly running.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 62214: Added JavaScript linter.

2017-11-09 Thread Kevin Klues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62214/#review190595
---




support/mesos-style.py
Lines 107 (patched)


I seem to be getting this error when testing manually:
```
Checking 1 JavaScript file
Traceback (most recent call last):
  File "support/mesos-style.py", line 472, in 
JS_ERRORS = JS_LINTER.main(sys.argv[1:])
  File "support/mesos-style.py", line 344, in main
return super(JsLinter, self).main(modified_files)
  File "support/mesos-style.py", line 210, in main
lint_errors = self.run_lint(list(filtered_candidates_set))
  File "support/mesos-style.py", line 332, in run_lint
config=config_path)
  File "support/mesos-style.py", line 108, in run_command_in_virtualenv
shell=True, stdout=subprocess.PIPE)
  File 
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py",
 line 710, in __init__
errread, errwrite)
  File 
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py",
 line 1335, in _execute_child
raise child_exception
TypeError: execv() arg 2 must contain only strings
```


- Kevin Klues


On Oct. 18, 2017, 9:23 a.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62214/
> ---
> 
> (Updated Oct. 18, 2017, 9:23 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Gaston Kleiman, and Kevin Klues.
> 
> 
> Bugs: MESOS-7924
> https://issues.apache.org/jira/browse/MESOS-7924
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The linter runs when changes on a JavaScript file are being committed.
> We use ESLint with a configuration based on our current JS code base.
> The linter and its dependencies (i.e. Node.js) are installed in a
> virtual environment using Virtualenv and then Nodeenv.
> 
> 
> Diffs
> -
> 
>   support/.eslintrc.js PRE-CREATION 
>   support/build-virtualenv PRE-CREATION 
>   support/mesos-style.py b2fdac9f8f76bdf8d8ede9ad8a056e4bb8c2754c 
>   support/pip-requirements.txt PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62214/diff/8/
> 
> 
> Testing
> ---
> 
> ```
> $ make check
> ```
> 
> Following this commit, I have also tried to commit a change on a JavaScript 
> file and checked that ESLinter was correctly running.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 62214: Added JavaScript linter.

2017-11-09 Thread Kevin Klues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62214/#review190593
---


Ship it!





support/mesos-style.py
Lines 99-111 (patched)


We should make sure to change the python linter to use this in a subsequent 
commit.


- Kevin Klues


On Oct. 18, 2017, 9:23 a.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62214/
> ---
> 
> (Updated Oct. 18, 2017, 9:23 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Gaston Kleiman, and Kevin Klues.
> 
> 
> Bugs: MESOS-7924
> https://issues.apache.org/jira/browse/MESOS-7924
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The linter runs when changes on a JavaScript file are being committed.
> We use ESLint with a configuration based on our current JS code base.
> The linter and its dependencies (i.e. Node.js) are installed in a
> virtual environment using Virtualenv and then Nodeenv.
> 
> 
> Diffs
> -
> 
>   support/.eslintrc.js PRE-CREATION 
>   support/build-virtualenv PRE-CREATION 
>   support/mesos-style.py b2fdac9f8f76bdf8d8ede9ad8a056e4bb8c2754c 
>   support/pip-requirements.txt PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62214/diff/8/
> 
> 
> Testing
> ---
> 
> ```
> $ make check
> ```
> 
> Following this commit, I have also tried to commit a change on a JavaScript 
> file and checked that ESLinter was correctly running.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 62214: Added JavaScript linter.

2017-10-18 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62214/#review188477
---



PASS: Mesos patch 62214 was successfully built and tested.

Reviews applied: `['62214']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62214

- Mesos Reviewbot Windows


On Oct. 18, 2017, 11:23 a.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62214/
> ---
> 
> (Updated Oct. 18, 2017, 11:23 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Gaston Kleiman, and Kevin Klues.
> 
> 
> Bugs: MESOS-7924
> https://issues.apache.org/jira/browse/MESOS-7924
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The linter runs when changes on a JavaScript file are being committed.
> We use ESLint with a configuration based on our current JS code base.
> The linter and its dependencies (i.e. Node.js) are installed in a
> virtual environment using Virtualenv and then Nodeenv.
> 
> 
> Diffs
> -
> 
>   src/webui/.eslintrc.js PRE-CREATION 
>   src/webui/.gitignore PRE-CREATION 
>   src/webui/bootstrap PRE-CREATION 
>   src/webui/pip-requirements.txt PRE-CREATION 
>   support/mesos-style.py b2fdac9f8f76bdf8d8ede9ad8a056e4bb8c2754c 
> 
> 
> Diff: https://reviews.apache.org/r/62214/diff/7/
> 
> 
> Testing
> ---
> 
> ```
> $ make check
> ```
> 
> Following this commit, I have also tried to commit a change on a JavaScript 
> file and checked that ESLinter was correctly running.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 62214: Added JavaScript linter.

2017-10-18 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62214/#review188474
---



Patch looks great!

Reviews applied: [62214]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Oct. 18, 2017, 9:23 a.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62214/
> ---
> 
> (Updated Oct. 18, 2017, 9:23 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Gaston Kleiman, and Kevin Klues.
> 
> 
> Bugs: MESOS-7924
> https://issues.apache.org/jira/browse/MESOS-7924
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The linter runs when changes on a JavaScript file are being committed.
> We use ESLint with a configuration based on our current JS code base.
> The linter and its dependencies (i.e. Node.js) are installed in a
> virtual environment using Virtualenv and then Nodeenv.
> 
> 
> Diffs
> -
> 
>   src/webui/.eslintrc.js PRE-CREATION 
>   src/webui/.gitignore PRE-CREATION 
>   src/webui/bootstrap PRE-CREATION 
>   src/webui/pip-requirements.txt PRE-CREATION 
>   support/mesos-style.py b2fdac9f8f76bdf8d8ede9ad8a056e4bb8c2754c 
> 
> 
> Diff: https://reviews.apache.org/r/62214/diff/7/
> 
> 
> Testing
> ---
> 
> ```
> $ make check
> ```
> 
> Following this commit, I have also tried to commit a change on a JavaScript 
> file and checked that ESLinter was correctly running.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 62214: Added JavaScript linter.

2017-10-18 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62214/#review188466
---



FAIL: Failed to apply the dependent review: 62333.

Failed command: `python.exe .\support\apply-reviews.py -n -r 62333`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62214

Relevant logs:

- 
[apply-review-62333-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62214/logs/apply-review-62333-stdout.log):

```
error: patch failed: support/mesos-style.py:153
error: support/mesos-style.py: patch does not apply
```

- Mesos Reviewbot Windows


On Oct. 18, 2017, 9:23 a.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62214/
> ---
> 
> (Updated Oct. 18, 2017, 9:23 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Gaston Kleiman, and Kevin Klues.
> 
> 
> Bugs: MESOS-7924
> https://issues.apache.org/jira/browse/MESOS-7924
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The linter runs when changes on a JavaScript file are being committed.
> We use ESLint with a configuration based on our current JS code base.
> The linter and its dependencies (i.e. Node.js) are installed in a
> virtual environment using Virtualenv and then Nodeenv.
> 
> 
> Diffs
> -
> 
>   src/webui/.eslintrc.js PRE-CREATION 
>   src/webui/.gitignore PRE-CREATION 
>   src/webui/bootstrap PRE-CREATION 
>   src/webui/pip-requirements.txt PRE-CREATION 
>   support/mesos-style.py b2fdac9f8f76bdf8d8ede9ad8a056e4bb8c2754c 
> 
> 
> Diff: https://reviews.apache.org/r/62214/diff/7/
> 
> 
> Testing
> ---
> 
> ```
> $ make check
> ```
> 
> Following this commit, I have also tried to commit a change on a JavaScript 
> file and checked that ESLinter was correctly running.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 62214: Added JavaScript linter.

2017-10-18 Thread Armand Grillet 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62214/
---

(Updated Oct. 18, 2017, 9:23 a.m.)


Review request for mesos, Benjamin Mahler, Gaston Kleiman, and Kevin Klues.


Changes
---

Rebase.


Bugs: MESOS-7924
https://issues.apache.org/jira/browse/MESOS-7924


Repository: mesos


Description (updated)
---

The linter runs when changes on a JavaScript file are being committed.
We use ESLint with a configuration based on our current JS code base.
The linter and its dependencies (i.e. Node.js) are installed in a
virtual environment using Virtualenv and then Nodeenv.


Diffs (updated)
-

  src/webui/.eslintrc.js PRE-CREATION 
  src/webui/.gitignore PRE-CREATION 
  src/webui/bootstrap PRE-CREATION 
  src/webui/pip-requirements.txt PRE-CREATION 
  support/mesos-style.py b2fdac9f8f76bdf8d8ede9ad8a056e4bb8c2754c 


Diff: https://reviews.apache.org/r/62214/diff/7/

Changes: https://reviews.apache.org/r/62214/diff/6-7/


Testing (updated)
---

```
$ make check
```

Following this commit, I have also tried to commit a change on a JavaScript 
file and checked that ESLinter was correctly running.


Thanks,

Armand Grillet

Re: Review Request 62214: Added JavaScript linter.

2017-10-06 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62214/#review187300
---



Patch looks great!

Reviews applied: [62333, 62214]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Oct. 6, 2017, 9 a.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62214/
> ---
> 
> (Updated Oct. 6, 2017, 9 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Kevin Klues.
> 
> 
> Bugs: MESOS-7924
> https://issues.apache.org/jira/browse/MESOS-7924
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This linter runs when changes on a JavaScript file are being committed.
> The linter used is ESLint with a configuration based on our current JS
> code base. The linter and its dependencies (i.e. Node.js) are installed
> in a environment using Virtualenv and then Nodeenv.
> 
> 
> Diffs
> -
> 
>   src/webui/.eslintrc.js PRE-CREATION 
>   src/webui/.gitignore PRE-CREATION 
>   src/webui/bootstrap PRE-CREATION 
>   src/webui/pip-requirements.txt PRE-CREATION 
>   support/mesos-style.py b2fdac9f8f76bdf8d8ede9ad8a056e4bb8c2754c 
> 
> 
> Diff: https://reviews.apache.org/r/62214/diff/6/
> 
> 
> Testing
> ---
> 
> Following this commit, I have tried to commit a change on a JavaScript file 
> and checked that ESLinter was correctly running.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 62214: Added JavaScript linter.

2017-10-06 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62214/#review187252
---



FAIL: Failed to apply the dependent review: 62333.

Failed command: `python.exe .\support\apply-reviews.py -n -r 62333`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62214

Relevant logs:

- 
[apply-review-62333-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62214/logs/apply-review-62333-stdout.log):

```
error: patch failed: support/mesos-style.py:153
error: support/mesos-style.py: patch does not apply
```

- Mesos Reviewbot Windows


On Oct. 6, 2017, 9 a.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62214/
> ---
> 
> (Updated Oct. 6, 2017, 9 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Kevin Klues.
> 
> 
> Bugs: MESOS-7924
> https://issues.apache.org/jira/browse/MESOS-7924
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This linter runs when changes on a JavaScript file are being committed.
> The linter used is ESLint with a configuration based on our current JS
> code base. The linter and its dependencies (i.e. Node.js) are installed
> in a environment using Virtualenv and then Nodeenv.
> 
> 
> Diffs
> -
> 
>   src/webui/.eslintrc.js PRE-CREATION 
>   src/webui/.gitignore PRE-CREATION 
>   src/webui/bootstrap PRE-CREATION 
>   src/webui/pip-requirements.txt PRE-CREATION 
>   support/mesos-style.py b2fdac9f8f76bdf8d8ede9ad8a056e4bb8c2754c 
> 
> 
> Diff: https://reviews.apache.org/r/62214/diff/6/
> 
> 
> Testing
> ---
> 
> Following this commit, I have tried to commit a change on a JavaScript file 
> and checked that ESLinter was correctly running.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 62214: Added JavaScript linter.

2017-10-06 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62214/#review187251
---



FAIL: Failed to apply the dependent review: 62333.

Failed command: `python.exe .\support\apply-reviews.py -n -r 62333`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62214

Relevant logs:

- 
[apply-review-62333-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62214/logs/apply-review-62333-stdout.log):

```
error: patch failed: support/mesos-style.py:153
error: support/mesos-style.py: patch does not apply
```

- Mesos Reviewbot Windows


On Oct. 6, 2017, 9 a.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62214/
> ---
> 
> (Updated Oct. 6, 2017, 9 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Kevin Klues.
> 
> 
> Bugs: MESOS-7924
> https://issues.apache.org/jira/browse/MESOS-7924
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This linter runs when changes on a JavaScript file are being committed.
> The linter used is ESLint with a configuration based on our current JS
> code base. The linter and its dependencies (i.e. Node.js) are installed
> in a environment using Virtualenv and then Nodeenv.
> 
> 
> Diffs
> -
> 
>   src/webui/.eslintrc.js PRE-CREATION 
>   src/webui/.gitignore PRE-CREATION 
>   src/webui/bootstrap PRE-CREATION 
>   src/webui/pip-requirements.txt PRE-CREATION 
>   support/mesos-style.py b2fdac9f8f76bdf8d8ede9ad8a056e4bb8c2754c 
> 
> 
> Diff: https://reviews.apache.org/r/62214/diff/6/
> 
> 
> Testing
> ---
> 
> Following this commit, I have tried to commit a change on a JavaScript file 
> and checked that ESLinter was correctly running.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 62214: Added JavaScript linter.

2017-10-06 Thread Armand Grillet 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62214/
---

(Updated Oct. 6, 2017, 9 a.m.)


Review request for mesos, Benjamin Mahler and Kevin Klues.


Changes
---

Resolved issues.


Bugs: MESOS-7924
https://issues.apache.org/jira/browse/MESOS-7924


Repository: mesos


Description
---

This linter runs when changes on a JavaScript file are being committed.
The linter used is ESLint with a configuration based on our current JS
code base. The linter and its dependencies (i.e. Node.js) are installed
in a environment using Virtualenv and then Nodeenv.


Diffs (updated)
-

  src/webui/.eslintrc.js PRE-CREATION 
  src/webui/.gitignore PRE-CREATION 
  src/webui/bootstrap PRE-CREATION 
  src/webui/pip-requirements.txt PRE-CREATION 
  support/mesos-style.py b2fdac9f8f76bdf8d8ede9ad8a056e4bb8c2754c 


Diff: https://reviews.apache.org/r/62214/diff/6/

Changes: https://reviews.apache.org/r/62214/diff/5-6/


Testing
---

Following this commit, I have tried to commit a change on a JavaScript file and 
checked that ESLinter was correctly running.


Thanks,

Armand Grillet

Re: Review Request 62214: Added JavaScript linter.

2017-10-05 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62214/#review187214
---



Patch looks great!

Reviews applied: [62333, 62214]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Sept. 29, 2017, 1:28 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62214/
> ---
> 
> (Updated Sept. 29, 2017, 1:28 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Kevin Klues.
> 
> 
> Bugs: MESOS-7924
> https://issues.apache.org/jira/browse/MESOS-7924
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This linter runs when changes on a JavaScript file are being committed.
> The linter used is ESLint with a configuration based on our current JS
> code base. The linter and its dependencies (i.e. Node.js) are installed
> in a environment using Virtualenv and then Nodeenv.
> 
> 
> Diffs
> -
> 
>   src/webui/.eslintrc.js PRE-CREATION 
>   src/webui/.gitignore PRE-CREATION 
>   src/webui/bootstrap PRE-CREATION 
>   src/webui/pip-requirements.txt PRE-CREATION 
>   support/mesos-style.py 9cd1623c48623e558dcd5b80b4bbf5a2162c57cb 
> 
> 
> Diff: https://reviews.apache.org/r/62214/diff/5/
> 
> 
> Testing
> ---
> 
> Following this commit, I have tried to commit a change on a JavaScript file 
> and checked that ESLinter was correctly running.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 62214: Added JavaScript linter.

2017-10-05 Thread Kevin Klues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62214/#review187180
---




support/mesos-style.py
Lines 356-361 (patched)


This should already be handled by the `exclude_files` list and the 
`find_candidates()` function in the base class. Is it necessary to duplicate 
this logic here?



support/mesos-style.py
Lines 364 (patched)


I don't think this function will ever be called if len(source_paths) == 0 
(meaning this check is unnecessary). See the main() function from the base 
class.


- Kevin Klues


On Sept. 29, 2017, 1:28 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62214/
> ---
> 
> (Updated Sept. 29, 2017, 1:28 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Kevin Klues.
> 
> 
> Bugs: MESOS-7924
> https://issues.apache.org/jira/browse/MESOS-7924
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This linter runs when changes on a JavaScript file are being committed.
> The linter used is ESLint with a configuration based on our current JS
> code base. The linter and its dependencies (i.e. Node.js) are installed
> in a environment using Virtualenv and then Nodeenv.
> 
> 
> Diffs
> -
> 
>   src/webui/.eslintrc.js PRE-CREATION 
>   src/webui/.gitignore PRE-CREATION 
>   src/webui/bootstrap PRE-CREATION 
>   src/webui/pip-requirements.txt PRE-CREATION 
>   support/mesos-style.py 9cd1623c48623e558dcd5b80b4bbf5a2162c57cb 
> 
> 
> Diff: https://reviews.apache.org/r/62214/diff/5/
> 
> 
> Testing
> ---
> 
> Following this commit, I have tried to commit a change on a JavaScript file 
> and checked that ESLinter was correctly running.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 62214: Added JavaScript linter.

2017-10-05 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62214/#review187178
---



FAIL: Failed to apply the dependent review: 62333.

Failed command: `python.exe .\support\apply-reviews.py -n -r 62333`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62214

Relevant logs:

- 
[apply-review-62333-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62214/logs/apply-review-62333-stdout.log):

```
error: patch failed: support/mesos-style.py:153
error: support/mesos-style.py: patch does not apply
```

- Mesos Reviewbot Windows


On Sept. 29, 2017, 6:28 a.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62214/
> ---
> 
> (Updated Sept. 29, 2017, 6:28 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Kevin Klues.
> 
> 
> Bugs: MESOS-7924
> https://issues.apache.org/jira/browse/MESOS-7924
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This linter runs when changes on a JavaScript file are being committed.
> The linter used is ESLint with a configuration based on our current JS
> code base. The linter and its dependencies (i.e. Node.js) are installed
> in a environment using Virtualenv and then Nodeenv.
> 
> 
> Diffs
> -
> 
>   src/webui/.eslintrc.js PRE-CREATION 
>   src/webui/.gitignore PRE-CREATION 
>   src/webui/bootstrap PRE-CREATION 
>   src/webui/pip-requirements.txt PRE-CREATION 
>   support/mesos-style.py 9cd1623c48623e558dcd5b80b4bbf5a2162c57cb 
> 
> 
> Diff: https://reviews.apache.org/r/62214/diff/5/
> 
> 
> Testing
> ---
> 
> Following this commit, I have tried to commit a change on a JavaScript file 
> and checked that ESLinter was correctly running.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 62214: Added JavaScript linter.

2017-10-05 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62214/#review187176
---



FAIL: Failed to apply the dependent review: 62333.

Failed command: `python.exe .\support\apply-reviews.py -n -r 62333`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62214

Relevant logs:

- 
[apply-review-62333-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62214/logs/apply-review-62333-stdout.log):

```
error: patch failed: support/mesos-style.py:153
error: support/mesos-style.py: patch does not apply
```

- Mesos Reviewbot Windows


On Sept. 29, 2017, 1:28 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62214/
> ---
> 
> (Updated Sept. 29, 2017, 1:28 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Kevin Klues.
> 
> 
> Bugs: MESOS-7924
> https://issues.apache.org/jira/browse/MESOS-7924
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This linter runs when changes on a JavaScript file are being committed.
> The linter used is ESLint with a configuration based on our current JS
> code base. The linter and its dependencies (i.e. Node.js) are installed
> in a environment using Virtualenv and then Nodeenv.
> 
> 
> Diffs
> -
> 
>   src/webui/.eslintrc.js PRE-CREATION 
>   src/webui/.gitignore PRE-CREATION 
>   src/webui/bootstrap PRE-CREATION 
>   src/webui/pip-requirements.txt PRE-CREATION 
>   support/mesos-style.py 9cd1623c48623e558dcd5b80b4bbf5a2162c57cb 
> 
> 
> Diff: https://reviews.apache.org/r/62214/diff/5/
> 
> 
> Testing
> ---
> 
> Following this commit, I have tried to commit a change on a JavaScript file 
> and checked that ESLinter was correctly running.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 62214: Added JavaScript linter.

2017-09-29 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62214/#review186770
---



Patch looks great!

Reviews applied: [62333, 62214]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Sept. 29, 2017, 9:28 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62214/
> ---
> 
> (Updated Sept. 29, 2017, 9:28 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Kevin Klues.
> 
> 
> Bugs: MESOS-7924
> https://issues.apache.org/jira/browse/MESOS-7924
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This linter runs when changes on a JavaScript file are being committed.
> The linter used is ESLint with a configuration based on our current JS
> code base. The linter and its dependencies (i.e. Node.js) are installed
> in a environment using Virtualenv and then Nodeenv.
> 
> 
> Diffs
> -
> 
>   src/webui/.eslintrc.js PRE-CREATION 
>   src/webui/.gitignore PRE-CREATION 
>   src/webui/bootstrap PRE-CREATION 
>   src/webui/pip-requirements.txt PRE-CREATION 
>   support/mesos-style.py 9cd1623c48623e558dcd5b80b4bbf5a2162c57cb 
> 
> 
> Diff: https://reviews.apache.org/r/62214/diff/4/
> 
> 
> Testing
> ---
> 
> Following this commit, I have tried to commit a change on a JavaScript file 
> and checked that ESLinter was correctly running.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 62214: Added JavaScript linter.

2017-09-29 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62214/#review186679
---



PASS: Mesos patch 62214 was successfully built and tested.

Reviews applied: `['62333', '62214']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62214

- Mesos Reviewbot Windows


On Sept. 29, 2017, 1:28 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62214/
> ---
> 
> (Updated Sept. 29, 2017, 1:28 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Kevin Klues.
> 
> 
> Bugs: MESOS-7924
> https://issues.apache.org/jira/browse/MESOS-7924
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This linter runs when changes on a JavaScript file are being committed.
> The linter used is ESLint with a configuration based on our current JS
> code base. The linter and its dependencies (i.e. Node.js) are installed
> in a environment using Virtualenv and then Nodeenv.
> 
> 
> Diffs
> -
> 
>   src/webui/.eslintrc.js PRE-CREATION 
>   src/webui/.gitignore PRE-CREATION 
>   src/webui/bootstrap PRE-CREATION 
>   src/webui/pip-requirements.txt PRE-CREATION 
>   support/mesos-style.py 9cd1623c48623e558dcd5b80b4bbf5a2162c57cb 
> 
> 
> Diff: https://reviews.apache.org/r/62214/diff/4/
> 
> 
> Testing
> ---
> 
> Following this commit, I have tried to commit a change on a JavaScript file 
> and checked that ESLinter was correctly running.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 62214: Added JavaScript linter.

2017-09-29 Thread Armand Grillet 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62214/
---

(Updated Sept. 29, 2017, 1:28 p.m.)


Review request for mesos, Benjamin Mahler and Kevin Klues.


Changes
---

Added comments to bootstrap script and changed nodeenv version to not have 
`OSError: [Errno 17] File exists` errors.


Bugs: MESOS-7924
https://issues.apache.org/jira/browse/MESOS-7924


Repository: mesos


Description
---

This linter runs when changes on a JavaScript file are being committed.
The linter used is ESLint with a configuration based on our current JS
code base. The linter and its dependencies (i.e. Node.js) are installed
in a environment using Virtualenv and then Nodeenv.


Diffs (updated)
-

  src/webui/.eslintrc.js PRE-CREATION 
  src/webui/.gitignore PRE-CREATION 
  src/webui/bootstrap PRE-CREATION 
  src/webui/pip-requirements.txt PRE-CREATION 
  support/mesos-style.py 9cd1623c48623e558dcd5b80b4bbf5a2162c57cb 


Diff: https://reviews.apache.org/r/62214/diff/4/

Changes: https://reviews.apache.org/r/62214/diff/3-4/


Testing
---

Following this commit, I have tried to commit a change on a JavaScript file and 
checked that ESLinter was correctly running.


Thanks,

Armand Grillet

Re: Review Request 62214: Added JavaScript linter.

2017-09-27 Thread Kevin Klues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62214/#review186407
---




src/webui/bootstrap
Lines 71 (patched)


Can you add a comment here as to why you need to deactivate and then 
immediatley reactivate again?


- Kevin Klues


On Sept. 25, 2017, 2:56 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62214/
> ---
> 
> (Updated Sept. 25, 2017, 2:56 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Kevin Klues.
> 
> 
> Bugs: MESOS-7924
> https://issues.apache.org/jira/browse/MESOS-7924
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This linter runs when changes on a JavaScript file are being committed.
> The linter used is ESLint with a configuration based on our current JS
> code base. The linter and its dependencies (i.e. Node.js) are installed
> in a environment using Virtualenv and then Nodeenv.
> 
> 
> Diffs
> -
> 
>   src/webui/.eslintrc.js PRE-CREATION 
>   src/webui/.gitignore PRE-CREATION 
>   src/webui/bootstrap PRE-CREATION 
>   src/webui/pip-requirements.txt PRE-CREATION 
>   support/mesos-style.py 9cd1623c48623e558dcd5b80b4bbf5a2162c57cb 
> 
> 
> Diff: https://reviews.apache.org/r/62214/diff/3/
> 
> 
> Testing
> ---
> 
> Following this commit, I have tried to commit a change on a JavaScript file 
> and checked that ESLinter was correctly running.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 62214: Added JavaScript linter.

2017-09-25 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62214/#review186138
---



PASS: Mesos patch 62214 was successfully built and tested.

Reviews applied: `['62333', '62214']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62214

- Mesos Reviewbot Windows


On Sept. 25, 2017, 2:56 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62214/
> ---
> 
> (Updated Sept. 25, 2017, 2:56 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Kevin Klues.
> 
> 
> Bugs: MESOS-7924
> https://issues.apache.org/jira/browse/MESOS-7924
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This linter runs when changes on a JavaScript file are being committed.
> The linter used is ESLint with a configuration based on our current JS
> code base. The linter and its dependencies (i.e. Node.js) are installed
> in a environment using Virtualenv and then Nodeenv.
> 
> 
> Diffs
> -
> 
>   src/webui/.eslintrc.js PRE-CREATION 
>   src/webui/.gitignore PRE-CREATION 
>   src/webui/bootstrap PRE-CREATION 
>   src/webui/pip-requirements.txt PRE-CREATION 
>   support/mesos-style.py 9cd1623c48623e558dcd5b80b4bbf5a2162c57cb 
> 
> 
> Diff: https://reviews.apache.org/r/62214/diff/3/
> 
> 
> Testing
> ---
> 
> Following this commit, I have tried to commit a change on a JavaScript file 
> and checked that ESLinter was correctly running.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 62214: Added JavaScript linter.

2017-09-25 Thread Armand Grillet 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62214/
---

(Updated Sept. 25, 2017, 2:56 p.m.)


Review request for mesos, Benjamin Mahler and Kevin Klues.


Changes
---

Improved naming.


Bugs: MESOS-7924
https://issues.apache.org/jira/browse/MESOS-7924


Repository: mesos


Description
---

This linter runs when changes on a JavaScript file are being committed.
The linter used is ESLint with a configuration based on our current JS
code base. The linter and its dependencies (i.e. Node.js) are installed
in a environment using Virtualenv and then Nodeenv.


Diffs (updated)
-

  src/webui/.eslintrc.js PRE-CREATION 
  src/webui/.gitignore PRE-CREATION 
  src/webui/bootstrap PRE-CREATION 
  src/webui/pip-requirements.txt PRE-CREATION 
  support/mesos-style.py 9cd1623c48623e558dcd5b80b4bbf5a2162c57cb 


Diff: https://reviews.apache.org/r/62214/diff/3/

Changes: https://reviews.apache.org/r/62214/diff/2-3/


Testing
---

Following this commit, I have tried to commit a change on a JavaScript file and 
checked that ESLinter was correctly running.


Thanks,

Armand Grillet

Re: Review Request 62214: Added JavaScript linter.

2017-09-19 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62214/#review185677
---



Patch looks great!

Reviews applied: [62333, 62214]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Sept. 18, 2017, 3:10 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62214/
> ---
> 
> (Updated Sept. 18, 2017, 3:10 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Kevin Klues.
> 
> 
> Bugs: MESOS-7924
> https://issues.apache.org/jira/browse/MESOS-7924
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This linter runs when changes on a JavaScript file are being committed.
> The linter used is ESLint with a configuration based on our current JS
> code base. The linter and its dependencies (i.e. Node.js) are installed
> in a environment using Virtualenv and then Nodeenv.
> 
> 
> Diffs
> -
> 
>   src/webui/.eslintrc.js PRE-CREATION 
>   src/webui/.gitignore PRE-CREATION 
>   src/webui/bootstrap PRE-CREATION 
>   src/webui/pip-requirements.txt PRE-CREATION 
>   support/mesos-style.py cf37d9f4da4ab90b92f0136a1dcd5dd8bbae5785 
> 
> 
> Diff: https://reviews.apache.org/r/62214/diff/2/
> 
> 
> Testing
> ---
> 
> Following this commit, I have tried to commit a change on a JavaScript file 
> and checked that ESLinter was correctly running.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 62214: Added JavaScript linter.

2017-09-18 Thread Armand Grillet 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62214/
---

(Updated Sept. 18, 2017, 3:10 p.m.)


Review request for mesos, Benjamin Mahler and Kevin Klues.


Changes
---

Updated dependency.


Bugs: MESOS-7924
https://issues.apache.org/jira/browse/MESOS-7924


Repository: mesos


Description
---

This linter runs when changes on a JavaScript file are being committed.
The linter used is ESLint with a configuration based on our current JS
code base. The linter and its dependencies (i.e. Node.js) are installed
in a environment using Virtualenv and then Nodeenv.


Diffs
-

  src/webui/.eslintrc.js PRE-CREATION 
  src/webui/.gitignore PRE-CREATION 
  src/webui/bootstrap PRE-CREATION 
  src/webui/pip-requirements.txt PRE-CREATION 
  support/mesos-style.py cf37d9f4da4ab90b92f0136a1dcd5dd8bbae5785 


Diff: https://reviews.apache.org/r/62214/diff/2/


Testing
---

Following this commit, I have tried to commit a change on a JavaScript file and 
checked that ESLinter was correctly running.


Thanks,

Armand Grillet

Re: Review Request 62214: Added JavaScript linter.

2017-09-15 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62214/#review185507
---



Patch looks great!

Reviews applied: [62332, 62333, 62214]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Sept. 14, 2017, 3:59 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62214/
> ---
> 
> (Updated Sept. 14, 2017, 3:59 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Kevin Klues.
> 
> 
> Bugs: MESOS-7924
> https://issues.apache.org/jira/browse/MESOS-7924
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This linter runs when changes on a JavaScript file are being committed.
> The linter used is ESLint with a configuration based on our current JS
> code base. The linter and its dependencies (i.e. Node.js) are installed
> in a environment using Virtualenv and then Nodeenv.
> 
> 
> Diffs
> -
> 
>   src/webui/.eslintrc.js PRE-CREATION 
>   src/webui/.gitignore PRE-CREATION 
>   src/webui/bootstrap PRE-CREATION 
>   src/webui/pip-requirements.txt PRE-CREATION 
>   support/mesos-style.py cf37d9f4da4ab90b92f0136a1dcd5dd8bbae5785 
> 
> 
> Diff: https://reviews.apache.org/r/62214/diff/2/
> 
> 
> Testing
> ---
> 
> Following this commit, I have tried to commit a change on a JavaScript file 
> and checked that ESLinter was correctly running.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 62214: Added JavaScript linter.

2017-09-15 Thread Armand Grillet 


> On Sept. 11, 2017, 7:18 p.m., Benjamin Mahler wrote:
> > support/mesos-style.py
> > Lines 307-311 (patched)
> > 
> >
> > Similarly to my comment below, if we had some virtual env abstraction 
> > this could be running something within in:
> > 
> > ```
> > virtualenv.run_within(['eslint', ...]);
> > ```

The `run_lint()` functions are quite different depending on the linter and only 
the activation of the virtual environment is done in both functions for the 
`.js` and `.py` linters. I could still had a `main()` function in /r/62333 if 
you think that is necessary.


> On Sept. 11, 2017, 7:18 p.m., Benjamin Mahler wrote:
> > support/mesos-style.py
> > Lines 332-334 (patched)
> > 
> >
> > Copy paste?

We have a `pip-requirements` to install nodeenv.


> On Sept. 11, 2017, 7:18 p.m., Benjamin Mahler wrote:
> > support/mesos-style.py
> > Lines 344-361 (patched)
> > 
> >
> > Can you document that we build the virtualenv by running bootstrap?
> > 
> > It will be unfortunate to have the code here and in PyLinter diverge, 
> > have you considered adding some kind of VirtualEnv class or making these 
> > standalone virtualenv functions here for them to both reuse?

/r/62333/


- Armand


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62214/#review185102
---


On Sept. 14, 2017, 3:59 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62214/
> ---
> 
> (Updated Sept. 14, 2017, 3:59 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Kevin Klues.
> 
> 
> Bugs: MESOS-7924
> https://issues.apache.org/jira/browse/MESOS-7924
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This linter runs when changes on a JavaScript file are being committed.
> The linter used is ESLint with a configuration based on our current JS
> code base. The linter and its dependencies (i.e. Node.js) are installed
> in a environment using Virtualenv and then Nodeenv.
> 
> 
> Diffs
> -
> 
>   src/webui/.eslintrc.js PRE-CREATION 
>   src/webui/.gitignore PRE-CREATION 
>   src/webui/bootstrap PRE-CREATION 
>   src/webui/pip-requirements.txt PRE-CREATION 
>   support/mesos-style.py cf37d9f4da4ab90b92f0136a1dcd5dd8bbae5785 
> 
> 
> Diff: https://reviews.apache.org/r/62214/diff/2/
> 
> 
> Testing
> ---
> 
> Following this commit, I have tried to commit a change on a JavaScript file 
> and checked that ESLinter was correctly running.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 62214: Added JavaScript linter.

2017-09-14 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62214/#review185453
---



FAIL: Some Mesos tests failed.

Reviews applied: `['62332', '62333', '62214']`

Failed command: `C:\mesos\src\mesos-tests.exe --verbose`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62214

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62214/logs/mesos-tests-stdout.log):

```
[ RUN  ] ContentType/SchedulerTest.SchedulerReconnect/0
[   OK ] ContentType/SchedulerTest.SchedulerReconnect/0 (241 ms)
[ RUN  ] ContentType/SchedulerTest.SchedulerReconnect/1
[   OK ] ContentType/SchedulerTest.SchedulerReconnect/1 (240 ms)
[--] 30 tests from ContentType/SchedulerTest (24624 ms total)

[--] 2 tests from ContentTypeAndSSLConfig/SchedulerSSLTest
[ RUN  ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/0
[   OK ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/0 (896 
ms)
[ RUN  ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/1
[   OK ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/1 (989 
ms)
[--] 2 tests from ContentTypeAndSSLConfig/SchedulerSSLTest (1968 ms 
total)

[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (138 
ms)
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (150 
ms)
[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (339 ms 
total)

[--] Global test environment tear-down
[==] 627 tests from 66 test cases ran. (335899 ms total)
[  PASSED  ] 626 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] ContentType/MasterAPITest.EventAuthorizationFiltering/1, where 
GetParam() = application/json

 1 FAILED TEST
  YOU HAVE 174 DISABLED TESTS

```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62214/logs/mesos-tests-stderr.log):

```
I0914 21:39:25.307788 16848 master.cpp:8418] Removing framework 
67e1c6b1-a376-4f26-bddb-0405647f4e4e- (default)
I0914 21:39:25.307788 16848 master.cpp:3267] Deactivating framework 
67e1c6b1-a376-4f26-bddb-0405647f4e4e- (default)
I0914 21:39:25.308787 17072 hierarchical.cpp:412] Deactivated framework 
67e1c6b1-a376-4f26-bddb-0405647f4e4e-
I0914 21:39:25.308787 13984 slave.cpp:3235] Shutting down framework 
67e1c6b1-a376-4f26-bddb-0405647f4e4e-
I0914 21:39:25.308787 16848 master.cpp:8993] Updating the state of task 
d8848512-704e-4b0c-bfa1-14a7593cd0c5 of framework 
67e1c6b1-a376-4f26-bddb-0405647f4e4e- (latest state: TASK_KILLED, status 
update state: TASK_KILLED)
I0914 21:39:25.308787 13984 slave.cpp:5731] Shutting down executor 'default' of 
framework 67e1c6b1-a376-4f26-bddb-0405647f4e4e- (via HTTP)
I0914 21:39:25.326788 16848 master.cpp:9087] Removing task 
d8848512-704e-4b0c-bfa1-14a7593cd0c5 with resources 
[{"allocation_info":{"role":"*"},"name":"cpus","scalar":{"value":2.0},"type":"SCALAR"},{"allocation_info":{"role":"*"},"name":"mem","scalar":{"value":1024.0},"type":"SCALAR"},{"allocation_info":{"role":"*"},"name":"disk","scalar":{"value":1024.0},"type":"SCALAR"},{"allocation_info":{"role":"*"},"name":"ports","ranges":{"range":[{"begin":31000,"end":32000}]},"type":"RANGES"}]
 of framework 67e1c6b1-a376-4f26-bddb-0405647f4e4e- on agent 
67e1c6b1-a376-4f26-bddb-0405647f4e4e-S0 at slave(254)@10.3.1.5:57393 
(mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0914 21:39:25.337790 16848 master.cpp:9116] Removing executor 'default' with 
resources [] of framework 67e1c6b1-a376-4f26-bddb-0405647f4e4e- on agent 
67e1c6b1-a376-4f26-bddb-0405647f4e4e-S0 at slave(254)@10.3.1.5:57393 
(mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0914 21:39:25.351790 17072 hierarchical.cpp:355] Removed framework 
67e1c6b1-a376-4f26-bddb-0405647f4e4e-
E0914 21:39:25.352789 13984 scheduler.cpp:649] End-Of-File received from 
master. The master closed the event stream
I0914 21:39:25.354790 17072 scheduler.cpp:444] Re-detecting master
I0914 21:39:25.356791 17072 scheduler.cpp:470] New master detected at 
master@10.3.1.5:57393
I0914 21:39:25.373792 15500 slave.cpp:5407] Executor 'default' of framework 
67e1c6b1-a376-4f26-bddb-0405647f4e4e- exited with status 0
I0914 21:39:25.373792 15500 slave.cpp:5511] Cleaning up executor 'default' of 
framework 67e1c6b1-a376-4f26-bddb-0405647f4e4e- (via HTTP)
W0914 21:39:25.374792 16848 master.cpp:7021] Ignoring unknown exited executor 
'default' of framework

Re: Review Request 62214: Added JavaScript linter.

2017-09-14 Thread Armand Grillet 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62214/
---

(Updated Sept. 14, 2017, 3:59 p.m.)


Review request for mesos, Benjamin Mahler and Kevin Klues.


Changes
---

Resolved issues.


Bugs: MESOS-7924
https://issues.apache.org/jira/browse/MESOS-7924


Repository: mesos


Description (updated)
---

This linter runs when changes on a JavaScript file are being committed.
The linter used is ESLint with a configuration based on our current JS
code base. The linter and its dependencies (i.e. Node.js) are installed
in a environment using Virtualenv and then Nodeenv.


Diffs (updated)
-

  src/webui/.eslintrc.js PRE-CREATION 
  src/webui/.gitignore PRE-CREATION 
  src/webui/bootstrap PRE-CREATION 
  src/webui/pip-requirements.txt PRE-CREATION 
  support/mesos-style.py cf37d9f4da4ab90b92f0136a1dcd5dd8bbae5785 


Diff: https://reviews.apache.org/r/62214/diff/2/

Changes: https://reviews.apache.org/r/62214/diff/1-2/


Testing (updated)
---

Following this commit, I have tried to commit a change on a JavaScript file and 
checked that ESLinter was correctly running.


Thanks,

Armand Grillet

Re: Review Request 62214: Added JavaScript linter.

2017-09-11 Thread Benjamin Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62214/#review185102
---



Can you add Kevin Klues to the review and ask him to take a look at the virtual 
env bootstrapping? I'm assuming you based this on his one for the CLI?


src/webui/master/static/.eslintrc.js
Lines 6 (patched)


Does this run successfully on the webui? Can you document for posterity how 
this config was produced?



src/webui/master/static/.gitignore
Lines 1 (patched)


Ditto here re: serving the file over HTTP.



src/webui/master/static/bootstrap
Lines 3-4 (patched)


I think the master serves all assets under static:


https://github.com/apache/mesos/blob/297b7042a7ef65aafca40832b5f8736e27e26ed2/src/master/master.cpp#L1122

Which means that if this file is here it's served by the master.



support/mesos-style.py
Lines 298-302 (patched)


Stale copy paste



support/mesos-style.py
Lines 307-311 (patched)


Similarly to my comment below, if we had some virtual env abstraction this 
could be running something within in:

```
virtualenv.run_within(['eslint', ...]);
```



support/mesos-style.py
Lines 309 (patched)


Is this applying a lint on the whole file or just the diff? Is it possible 
to do just the diff with eslint?

If not, we'll need to make sure the lint result is clean before we commit 
this, right?



support/mesos-style.py
Lines 332-334 (patched)


Copy paste?



support/mesos-style.py
Lines 344-361 (patched)


Can you document that we build the virtualenv by running bootstrap?

It will be unfortunate to have the code here and in PyLinter diverge, have 
you considered adding some kind of VirtualEnv class or making these standalone 
virtualenv functions here for them to both reuse?



support/mesos-style.py
Lines 343-345 (original)


What happened here? Should this be a different patch?


- Benjamin Mahler


On Sept. 11, 2017, 9:49 a.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62214/
> ---
> 
> (Updated Sept. 11, 2017, 9:49 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-7924
> https://issues.apache.org/jira/browse/MESOS-7924
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This linter runs when changes on a JavaScript file are being committed.
> The linter used is ESLint with a configuration based on our current JS
> code base. The linter and its dependencies (i.e. Node.js) are installed
> in a virtual environment using Virtualenv and then Nodeenv.
> 
> 
> Diffs
> -
> 
>   src/.gitignore PRE-CREATION 
>   src/webui/master/static/.eslintrc.js PRE-CREATION 
>   src/webui/master/static/.gitignore PRE-CREATION 
>   src/webui/master/static/bootstrap PRE-CREATION 
>   src/webui/master/static/pip-requirements.txt PRE-CREATION 
>   support/mesos-style.py cf37d9f4da4ab90b92f0136a1dcd5dd8bbae5785 
> 
> 
> Diff: https://reviews.apache.org/r/62214/diff/1/
> 
> 
> Testing
> ---
> 
> Following this commit, I have tried to commit a change on a JavaScript file 
> and checked that ESLinter was correctly invoked.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 62214: Added JavaScript linter.

2017-09-11 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62214/#review185080
---



FAIL: Some Mesos tests failed. Please check 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62214/logs/mesos-tests-stdout.log
 and 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62214/logs/mesos-tests-stderr.log
 for any relevant errors

Reviews applied: [62214]

Logs available here: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62214/logs

- Mesos Reviewbot Windows


On Sept. 11, 2017, 9:49 a.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62214/
> ---
> 
> (Updated Sept. 11, 2017, 9:49 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-7924
> https://issues.apache.org/jira/browse/MESOS-7924
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This linter runs when changes on a JavaScript file are being committed.
> The linter used is ESLint with a configuration based on our current JS
> code base. The linter and its dependencies (i.e. Node.js) are installed
> in a virtual environment using Virtualenv and then Nodeenv.
> 
> 
> Diffs
> -
> 
>   src/.gitignore PRE-CREATION 
>   src/webui/master/static/.eslintrc.js PRE-CREATION 
>   src/webui/master/static/.gitignore PRE-CREATION 
>   src/webui/master/static/bootstrap PRE-CREATION 
>   src/webui/master/static/pip-requirements.txt PRE-CREATION 
>   support/mesos-style.py cf37d9f4da4ab90b92f0136a1dcd5dd8bbae5785 
> 
> 
> Diff: https://reviews.apache.org/r/62214/diff/1/
> 
> 
> Testing
> ---
> 
> Following this commit, I have tried to commit a change on a JavaScript file 
> and checked that ESLinter was correctly invoked.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>