Re: Review Request 63094: Added resource version uuid for offer operations.

2017-10-29 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63094/ --- (Updated Oct. 29, 2017, 3:15 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 63094: Added resource version uuid for offer operations.

2017-10-29 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63094/ --- (Updated Oct. 29, 2017, 10:37 a.m.) Review request for mesos, Benjamin

Re: Review Request 63094: Added resource version uuid for offer operations.

2017-10-27 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63094/#review189457 --- Fix it, then Ship it!

Re: Review Request 63094: Added resource version uuid for offer operations.

2017-10-27 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63094/ --- (Updated Oct. 27, 2017, 5:06 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 63094: Added resource version uuid for offer operations.

2017-10-27 Thread Jie Yu
> On Oct. 26, 2017, 11:08 p.m., Greg Mann wrote: > > src/messages/messages.proto > > Lines 712 (patched) > > > > > > Do we need multiple ResourceVersionUUIDs here? Can the master just > > include the UUID for the

Re: Review Request 63094: Added resource version uuid for offer operations.

2017-10-27 Thread Jie Yu
> On Oct. 20, 2017, 12:44 p.m., Benjamin Bannier wrote: > > src/messages/messages.proto > > Lines 663 (patched) > > > > > > Even though currently operation on agent resources cannot exhibit > > operation

Re: Review Request 63094: Added resource version uuid for offer operations.

2017-10-26 Thread Greg Mann
> On Oct. 18, 2017, 9:46 a.m., Benjamin Bannier wrote: > > include/mesos/resource_provider/resource_provider.proto > > Lines 56-66 (patched) > > > > > > I would prefer if we would not assume that this number changes

Re: Review Request 63094: Added resource version uuid for offer operations.

2017-10-26 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63094/#review189371 --- include/mesos/v1/resource_provider/resource_provider.proto Lines

Re: Review Request 63094: Added resource version uuid for offer operations.

2017-10-20 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63094/#review188829 --- src/messages/messages.proto Lines 613 (patched)

Re: Review Request 63094: Added resource version uuid for offer operations.

2017-10-19 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63094/ --- (Updated Oct. 19, 2017, 9:35 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 63094: Added resource version uuid for offer operations.

2017-10-18 Thread Jie Yu
> On Oct. 18, 2017, 9:46 a.m., Benjamin Bannier wrote: > > include/mesos/resource_provider/resource_provider.proto > > Lines 56-66 (patched) > > > > > > I would prefer if we would not assume that this number changes

Re: Review Request 63094: Added resource version uuid for offer operations.

2017-10-18 Thread Jie Yu
> On Oct. 18, 2017, 9:46 a.m., Benjamin Bannier wrote: > > include/mesos/resource_provider/resource_provider.proto > > Lines 56-66 (patched) > > > > > > I would prefer if we would not assume that this number changes

Re: Review Request 63094: Added resource version uuid for offer operations.

2017-10-18 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63094/ --- (Updated Oct. 19, 2017, 12:10 a.m.) Review request for mesos, Benjamin