Re: Review Request 63765: Fixed an issue with the scheduler driver subscribe backoff time.

2017-12-02 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63765/#review192630
---


Ship it!




Ship It!

- Vinod Kone


On Dec. 2, 2017, 4:47 a.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63765/
> ---
> 
> (Updated Dec. 2, 2017, 4:47 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Vinod Kone.
> 
> 
> Bugs: MESOS-8171
> https://issues.apache.org/jira/browse/MESOS-8171
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When framework failover time is set to zero (which is the
> default value), the scheduler driver subscribe backoff time
> will also become zero. Ignore failover time if it is zero
> when deciding the subscribe backoff time.
> Also added a dedicated test.
> 
> 
> Diffs
> -
> 
>   src/sched/sched.cpp 6028499285ad092ffd252e842c5d9835dd4442f8 
>   src/tests/scheduler_driver_tests.cpp 
> 14d872b8fadfd4ef16d8923fb0df924331534bc3 
> 
> 
> Diff: https://reviews.apache.org/r/63765/diff/3/
> 
> 
> Testing
> ---
> 
> make check, and the new dedicated test.
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 63765: Fixed an issue with the scheduler driver subscribe backoff time.

2017-12-01 Thread Meng Zhu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63765/
---

(Updated Dec. 1, 2017, 8:47 p.m.)


Review request for mesos, Gilbert Song and Vinod Kone.


Bugs: MESOS-8171
https://issues.apache.org/jira/browse/MESOS-8171


Repository: mesos


Description
---

When framework failover time is set to zero (which is the
default value), the scheduler driver subscribe backoff time
will also become zero. Ignore failover time if it is zero
when deciding the subscribe backoff time.
Also added a dedicated test.


Diffs (updated)
-

  src/sched/sched.cpp 6028499285ad092ffd252e842c5d9835dd4442f8 
  src/tests/scheduler_driver_tests.cpp 14d872b8fadfd4ef16d8923fb0df924331534bc3 


Diff: https://reviews.apache.org/r/63765/diff/3/

Changes: https://reviews.apache.org/r/63765/diff/2-3/


Testing
---

make check, and the new dedicated test.


Thanks,

Meng Zhu

Re: Review Request 63765: Fixed an issue with the scheduler driver subscribe backoff time.

2017-12-01 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63765/#review191665
---




src/tests/scheduler_driver_tests.cpp
Lines 107 (patched)


s/enqueue/enqueued/

sorry my bad for the typo in the comment.


- Vinod Kone


On Nov. 18, 2017, 9:32 p.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63765/
> ---
> 
> (Updated Nov. 18, 2017, 9:32 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Vinod Kone.
> 
> 
> Bugs: MESOS-8171
> https://issues.apache.org/jira/browse/MESOS-8171
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When framework failover time is set to zero (which is the
> default value), the scheduler driver subscribe backoff time
> will also become zero. Ignore failover time if it is zero
> when deciding the subscribe backoff time.
> Also added a dedicated test.
> 
> 
> Diffs
> -
> 
>   src/sched/sched.cpp 6028499285ad092ffd252e842c5d9835dd4442f8 
>   src/tests/scheduler_driver_tests.cpp 
> 14d872b8fadfd4ef16d8923fb0df924331534bc3 
> 
> 
> Diff: https://reviews.apache.org/r/63765/diff/2/
> 
> 
> Testing
> ---
> 
> make check, and the new dedicated test.
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 63765: Fixed an issue with the scheduler driver subscribe backoff time.

2017-11-19 Thread Meng Zhu 


> On Nov. 18, 2017, 11:06 a.m., Vinod Kone wrote:
> > src/tests/scheduler_driver_tests.cpp
> > Lines 96 (patched)
> > 
> >
> > we use camel case for our variable names in mesos and snake case in 
> > libprocess/stout
> > 
> > s/in_sequence/inSequence/
> > 
> > btw, why is the sequence here necessary?

I want to make sure a call gets dropped first and then check expectation (no 
future calls). I think without the sequence, we can not enforce this order 
consistently?


- Meng


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63765/#review191445
---


On Nov. 18, 2017, 1:32 p.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63765/
> ---
> 
> (Updated Nov. 18, 2017, 1:32 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Vinod Kone.
> 
> 
> Bugs: MESOS-8171
> https://issues.apache.org/jira/browse/MESOS-8171
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When framework failover time is set to zero (which is the
> default value), the scheduler driver subscribe backoff time
> will also become zero. Ignore failover time if it is zero
> when deciding the subscribe backoff time.
> Also added a dedicated test.
> 
> 
> Diffs
> -
> 
>   src/sched/sched.cpp 6028499285ad092ffd252e842c5d9835dd4442f8 
>   src/tests/scheduler_driver_tests.cpp 
> 14d872b8fadfd4ef16d8923fb0df924331534bc3 
> 
> 
> Diff: https://reviews.apache.org/r/63765/diff/2/
> 
> 
> Testing
> ---
> 
> make check, and the new dedicated test.
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 63765: Fixed an issue with the scheduler driver subscribe backoff time.

2017-11-18 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63765/#review191447
---



FAIL: Some Mesos libprocess-tests failed.

Reviews applied: `['63765']`

Failed command: 
`C:\DCOS\mesos\3rdparty\libprocess\src\tests\Debug\libprocess-tests.exe`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63765

Relevant logs:

- 
[libprocess-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63765/logs/libprocess-tests-stdout.log):

```
[ RUN  ] Scheme/HTTPTest.WWWAuthenticateHeader/1
[   OK ] Scheme/HTTPTest.WWWAuthenticateHeader/1 (73 ms)
[ RUN  ] Scheme/HTTPTest.Accepts/0
[   OK ] Scheme/HTTPTest.Accepts/0 (1117 ms)
[ RUN  ] Scheme/HTTPTest.Accepts/1
[   OK ] Scheme/HTTPTest.Accepts/1 (83 ms)
[--] 34 tests from Scheme/HTTPTest (15398 ms total)

[--] 4 tests from SSLVerifyIPAdd/SSLTest
[ RUN  ] SSLVerifyIPAdd/SSLTest.BasicSameProcess/0
[   OK ] SSLVerifyIPAdd/SSLTest.BasicSameProcess/0 (994 ms)
[ RUN  ] SSLVerifyIPAdd/SSLTest.BasicSameProcess/1
[   OK ] SSLVerifyIPAdd/SSLTest.BasicSameProcess/1 (1265 ms)
[ RUN  ] SSLVerifyIPAdd/SSLTest.RequireCertificate/0
[   OK ] SSLVerifyIPAdd/SSLTest.RequireCertificate/0 (814 ms)
[ RUN  ] SSLVerifyIPAdd/SSLTest.RequireCertificate/1
[   OK ] SSLVerifyIPAdd/SSLTest.RequireCertificate/1 (1032 ms)
[--] 4 tests from SSLVerifyIPAdd/SSLTest (4316 ms total)

[--] Global test environment tear-down
[==] 201 tests from 33 test cases ran. (51507 ms total)
[  PASSED  ] 199 tests.
[  FAILED  ] 2 tests, listed below:
[  FAILED  ] HttpServeTest.Discard
[  FAILED  ] SSLTest.ECDHESupport

 2 FAILED TESTS
  YOU HAVE 19 DISABLED TESTS

```

- 
[libprocess-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63765/logs/libprocess-tests-stderr.log):

```
I1118 22:35:02.748981  4176 openssl.cpp:509] CA directory path unspecified! 
NOTE: Set CA directory path with LIBPROCESS_SSL_CA_DIR=
I1118 22:35:02.748981  4176 openssl.cpp:514] Will not verify peer certificate!
NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peWARNING: Logging before 
InitGoogleLogging() is written to STDERR
I1118 22:35:03.060993  5476 openssl.cpp:509] CA directory path unspecified! 
NOTE: Set CA directory path with LIBPROCESS_SSL_CA_DIR=
I1118 22:35:03.061995  5476 openssl.cpp:514] Will not verify peer certificate!
NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peer certificate verification
I1118 22:35:03.061995  5476 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT 
implies peer certificate verification.
LIBPROCESS_SSL_VERIFY_CERT set to true
I1118 22:35:03.061995  5476 openssl.cpp:563] Using CA file: 
C:\Users\mesos\AppData\Local\Temp\aLZp2t\cert.pem
WARNING: Logging before InitGoogleLogging() is written to STDERR
I1118 22:35:04.057031  4608 openssl.cpp:509] CA directory path unspecified! 
NOTE: Set CA directory path with LIBPROCESS_SSL_CA_DIR=
I1118 22:35:04.058033  4608 openssl.cpp:514] Will not verify peer certificate!
NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peer certificate verification
I1118 22:35:04.058033  4608 openssl.cpp:526] Will use IP address verification 
in subject alternative name certificate extension.
I1118 22:35:04.059033  4608 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT 
implies peer certificate verification.
LIBPROCESS_SSL_VERIFY_CERT set to true
I1118 22:35:04.059033  4608 openssl.cpp:563] Using CA file: 
C:\Users\mesos\AppData\Local\Temp\9o4BBW\cert.pem
er certificate verification
I1118 22:35:02.764982  4176 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT 
implies peer certificate verification.
LIBPROCESS_SSL_VERIFY_CERT set to true
I1118 22:35:02.764982  4176 openssl.cpp:563] Using CA file: 
C:\Users\mesos\AppData\Local\Temp\aLZp2t\cert.pem
I1118 22:35:03.741022  4176 openssl.cpp:509] CA directory path unspecified! 
NOTE: Set CA directory path with LIBPROCESS_SSL_CA_DIR=
I1118 22:35:03.741022  4176 openssl.cpp:514] Will not verify peer certificate!
NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peer certificate verification
I1118 22:35:03.741022  4176 openssl.cpp:526] Will use IP address verification 
in subject alternative name certificate extension.
I1118 22:35:03.742020  4176 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT 
implies peer certificate verification.
LIBPROCESS_SSL_VERIFY_CERT set to true
I1118 22:35:03.742020  4176 openssl.cpp:563] Using CA file: 
C:\Users\mesos\AppData\Local\Temp\9o4BBW\cert.pem
I1118 22:35:04.382045  3060 process.cpp:1052] Failed to accept socket: future 
discarded
```

- Mesos Reviewbot Windows


On Nov. 18, 2017, 9:32 p.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63765/
>

Re: Review Request 63765: Fixed an issue with the scheduler driver subscribe backoff time.

2017-11-18 Thread Meng Zhu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63765/
---

(Updated Nov. 18, 2017, 1:32 p.m.)


Review request for mesos, Gilbert Song and Vinod Kone.


Bugs: MESOS-8171
https://issues.apache.org/jira/browse/MESOS-8171


Repository: mesos


Description
---

When framework failover time is set to zero (which is the
default value), the scheduler driver subscribe backoff time
will also become zero. Ignore failover time if it is zero
when deciding the subscribe backoff time.
Also added a dedicated test.


Diffs (updated)
-

  src/sched/sched.cpp 6028499285ad092ffd252e842c5d9835dd4442f8 
  src/tests/scheduler_driver_tests.cpp 14d872b8fadfd4ef16d8923fb0df924331534bc3 


Diff: https://reviews.apache.org/r/63765/diff/2/

Changes: https://reviews.apache.org/r/63765/diff/1-2/


Testing
---

make check, and the new dedicated test.


Thanks,

Meng Zhu

Re: Review Request 63765: Fixed an issue with the scheduler driver subscribe backoff time.

2017-11-18 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63765/#review191445
---




src/tests/scheduler_driver_tests.cpp
Line 77 (original), 78 (patched)


2 blank lines between outer elements.



src/tests/scheduler_driver_tests.cpp
Lines 96 (patched)


we use camel case for our variable names in mesos and snake case in 
libprocess/stout

s/in_sequence/inSequence/

btw, why is the sequence here necessary?



src/tests/scheduler_driver_tests.cpp
Lines 98 (patched)


Add a comment here

// Drop the first SUBSCRIBE call so that the driver retries.



src/tests/scheduler_driver_tests.cpp
Lines 113 (patched)


// Settling the clock ensures that if a retried SUBSCRIBE call is enqueue 
it // will be processed. Since the backoff is non-zero no new SUBSCRIBE call
// should be sent when the clock is paused.



src/tests/scheduler_driver_tests.cpp
Line 78 (original), 118 (patched)


2 blank lines between out elements.


- Vinod Kone


On Nov. 13, 2017, 9:32 p.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63765/
> ---
> 
> (Updated Nov. 13, 2017, 9:32 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Vinod Kone.
> 
> 
> Bugs: MESOS-8171
> https://issues.apache.org/jira/browse/MESOS-8171
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When framework failover time is set to zero (which is the
> default value), the scheduler driver subscribe backoff time
> will also become zero. Ignore failover time if it is zero
> when deciding the subscribe backoff time.
> Also added a dedicated test.
> 
> 
> Diffs
> -
> 
>   src/sched/sched.cpp 6028499285ad092ffd252e842c5d9835dd4442f8 
>   src/tests/scheduler_driver_tests.cpp 
> 14d872b8fadfd4ef16d8923fb0df924331534bc3 
> 
> 
> Diff: https://reviews.apache.org/r/63765/diff/1/
> 
> 
> Testing
> ---
> 
> make check, and the new dedicated test.
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 63765: Fixed an issue with the scheduler driver subscribe backoff time.

2017-11-18 Thread Vinod Kone 


> On Nov. 13, 2017, 10:35 p.m., Mesos Reviewbot Windows wrote:
> > FAIL: Some Mesos libprocess-tests failed.
> > 
> > Reviews applied: `['63765']`
> > 
> > Failed command: 
> > `C:\DCOS\mesos\3rdparty\libprocess\src\tests\Debug\libprocess-tests.exe`
> > 
> > All the build artifacts available at: 
> > http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63765
> > 
> > Relevant logs:
> > 
> > - 
> > [libprocess-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63765/logs/libprocess-tests-stdout.log):
> > 
> > ```
> > [   OK ] Scheme/HTTPTest.WWWAuthenticateHeader/0 (837 ms)
> > [ RUN  ] Scheme/HTTPTest.WWWAuthenticateHeader/1
> > [   OK ] Scheme/HTTPTest.WWWAuthenticateHeader/1 (71 ms)
> > [ RUN  ] Scheme/HTTPTest.Accepts/0
> > [   OK ] Scheme/HTTPTest.Accepts/0 (400 ms)
> > [ RUN  ] Scheme/HTTPTest.Accepts/1
> > [   OK ] Scheme/HTTPTest.Accepts/1 (95 ms)
> > [--] 34 tests from Scheme/HTTPTest (12856 ms total)
> > 
> > [--] 4 tests from SSLVerifyIPAdd/SSLTest
> > [ RUN  ] SSLVerifyIPAdd/SSLTest.BasicSameProcess/0
> > [   OK ] SSLVerifyIPAdd/SSLTest.BasicSameProcess/0 (718 ms)
> > [ RUN  ] SSLVerifyIPAdd/SSLTest.BasicSameProcess/1
> > [   OK ] SSLVerifyIPAdd/SSLTest.BasicSameProcess/1 (255 ms)
> > [ RUN  ] SSLVerifyIPAdd/SSLTest.RequireCertificate/0
> > [   OK ] SSLVerifyIPAdd/SSLTest.RequireCertificate/0 (728 ms)
> > [ RUN  ] SSLVerifyIPAdd/SSLTest.RequireCertificate/1
> > [   OK ] SSLVerifyIPAdd/SSLTest.RequireCertificate/1 (1154 ms)
> > [--] 4 tests from SSLVerifyIPAdd/SSLTest (3015 ms total)
> > 
> > [--] Global test environment tear-down
> > [==] 201 tests from 33 test cases ran. (47658 ms total)
> > [  PASSED  ] 200 tests.
> > [  FAILED  ] 1 test, listed below:
> > [  FAILED  ] SSLTest.SSLSocket
> > 
> >  1 FAILED TEST
> >   YOU HAVE 19 DISABLED TESTS
> > 
> > ```
> > 
> > - 
> > [libprocess-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63765/logs/libprocess-tests-stderr.log):
> > 
> > ```
> > I1113 22:35:08.356146   388 openssl.cpp:509] CA directory path unspecified! 
> > NOTE: Set CA directory path with LIBPROCESS_SSL_CA_DIR=
> > I1113 22:35:08.356146   388 openssl.cpp:514] Will not verify peer 
> > certificate!
> > NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peWARNING: Logging before 
> > InitGoogleLogging() is written to STDERR
> > I1113 22:35:08.664160  2056 openssl.cpp:509] CA directory path unspecified! 
> > NOTE: Set CA directory path with LIBPROCESS_SSL_CA_DIR=
> > I1113 22:35:08.665160  2056 openssl.cpp:514] Will not verify peer 
> > certificate!
> > NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peer certificate 
> > verification
> > I1113 22:35:08.665160  2056 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT 
> > implies peer certificate verification.
> > LIBPROCESS_SSL_VERIFY_CERT set to true
> > I1113 22:35:08.666160  2056 openssl.cpp:563] Using CA file: 
> > C:\Users\mesos\AppData\Local\Temp\7tcras\cert.pem
> > WARNING: Logging before InitGoogleLogging() is written to STDERR
> > I1113 22:35:09.757180  4952 openssl.cpp:509] CA directory path unspecified! 
> > NOTE: Set CA directory path with LIBPROCESS_SSL_CA_DIR=
> > I1113 22:35:09.759182  4952 openssl.cpp:514] Will not verify peer 
> > certificate!
> > NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peer certificate 
> > verification
> > I1113 22:35:09.759182  4952 openssl.cpp:526] Will use IP address 
> > verification in subject alternative name certificate extension.
> > I1113 22:35:09.759182  4952 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT 
> > implies peer certificate verification.
> > LIBPROCESS_SSL_VERIFY_CERT set to true
> > I1113 22:35:09.760185  4952 openssl.cpp:563] Using CA file: 
> > C:\Users\mesos\AppData\Local\Temp\eGNHTo\cert.pem
> > er certificate verification
> > I1113 22:35:08.368152   388 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT 
> > implies peer certificate verification.
> > LIBPROCESS_SSL_VERIFY_CERT set to true
> > I1113 22:35:08.368152   388 openssl.cpp:563] Using CA file: 
> > C:\Users\mesos\AppData\Local\Temp\7tcras\cert.pem
> > I1113 22:35:09.456182   388 openssl.cpp:509] CA directory path unspecified! 
> > NOTE: Set CA directory path with LIBPROCESS_SSL_CA_DIR=
> > I1113 22:35:09.457181   388 openssl.cpp:514] Will not verify peer 
> > certificate!
> > NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peer certificate 
> > verification
> > I1113 22:35:09.457181   388 openssl.cpp:526] Will use IP address 
> > verification in subject alternative name certificate extension.
> > I1113 22:35:09.457181   388 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT 
> > implies peer certificate verification.
> > LIBPROCESS_SSL_VERIFY_CERT set to true
> > I1113 22:35:09.457181   388 openssl.cpp:563] Using CA file: 
> > C:\Users\mesos\AppData\Local\Temp\eGNHTo\cert.pem
> > I1113 22:35:10.005447  4220 process.cpp:1052] Failed to accept socket: 
> > future

Re: Review Request 63765: Fixed an issue with the scheduler driver subscribe backoff time.

2017-11-13 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63765/#review190897
---



FAIL: Some Mesos libprocess-tests failed.

Reviews applied: `['63765']`

Failed command: 
`C:\DCOS\mesos\3rdparty\libprocess\src\tests\Debug\libprocess-tests.exe`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63765

Relevant logs:

- 
[libprocess-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63765/logs/libprocess-tests-stdout.log):

```
[   OK ] Scheme/HTTPTest.WWWAuthenticateHeader/0 (837 ms)
[ RUN  ] Scheme/HTTPTest.WWWAuthenticateHeader/1
[   OK ] Scheme/HTTPTest.WWWAuthenticateHeader/1 (71 ms)
[ RUN  ] Scheme/HTTPTest.Accepts/0
[   OK ] Scheme/HTTPTest.Accepts/0 (400 ms)
[ RUN  ] Scheme/HTTPTest.Accepts/1
[   OK ] Scheme/HTTPTest.Accepts/1 (95 ms)
[--] 34 tests from Scheme/HTTPTest (12856 ms total)

[--] 4 tests from SSLVerifyIPAdd/SSLTest
[ RUN  ] SSLVerifyIPAdd/SSLTest.BasicSameProcess/0
[   OK ] SSLVerifyIPAdd/SSLTest.BasicSameProcess/0 (718 ms)
[ RUN  ] SSLVerifyIPAdd/SSLTest.BasicSameProcess/1
[   OK ] SSLVerifyIPAdd/SSLTest.BasicSameProcess/1 (255 ms)
[ RUN  ] SSLVerifyIPAdd/SSLTest.RequireCertificate/0
[   OK ] SSLVerifyIPAdd/SSLTest.RequireCertificate/0 (728 ms)
[ RUN  ] SSLVerifyIPAdd/SSLTest.RequireCertificate/1
[   OK ] SSLVerifyIPAdd/SSLTest.RequireCertificate/1 (1154 ms)
[--] 4 tests from SSLVerifyIPAdd/SSLTest (3015 ms total)

[--] Global test environment tear-down
[==] 201 tests from 33 test cases ran. (47658 ms total)
[  PASSED  ] 200 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] SSLTest.SSLSocket

 1 FAILED TEST
  YOU HAVE 19 DISABLED TESTS

```

- 
[libprocess-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63765/logs/libprocess-tests-stderr.log):

```
I1113 22:35:08.356146   388 openssl.cpp:509] CA directory path unspecified! 
NOTE: Set CA directory path with LIBPROCESS_SSL_CA_DIR=
I1113 22:35:08.356146   388 openssl.cpp:514] Will not verify peer certificate!
NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peWARNING: Logging before 
InitGoogleLogging() is written to STDERR
I1113 22:35:08.664160  2056 openssl.cpp:509] CA directory path unspecified! 
NOTE: Set CA directory path with LIBPROCESS_SSL_CA_DIR=
I1113 22:35:08.665160  2056 openssl.cpp:514] Will not verify peer certificate!
NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peer certificate verification
I1113 22:35:08.665160  2056 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT 
implies peer certificate verification.
LIBPROCESS_SSL_VERIFY_CERT set to true
I1113 22:35:08.666160  2056 openssl.cpp:563] Using CA file: 
C:\Users\mesos\AppData\Local\Temp\7tcras\cert.pem
WARNING: Logging before InitGoogleLogging() is written to STDERR
I1113 22:35:09.757180  4952 openssl.cpp:509] CA directory path unspecified! 
NOTE: Set CA directory path with LIBPROCESS_SSL_CA_DIR=
I1113 22:35:09.759182  4952 openssl.cpp:514] Will not verify peer certificate!
NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peer certificate verification
I1113 22:35:09.759182  4952 openssl.cpp:526] Will use IP address verification 
in subject alternative name certificate extension.
I1113 22:35:09.759182  4952 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT 
implies peer certificate verification.
LIBPROCESS_SSL_VERIFY_CERT set to true
I1113 22:35:09.760185  4952 openssl.cpp:563] Using CA file: 
C:\Users\mesos\AppData\Local\Temp\eGNHTo\cert.pem
er certificate verification
I1113 22:35:08.368152   388 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT 
implies peer certificate verification.
LIBPROCESS_SSL_VERIFY_CERT set to true
I1113 22:35:08.368152   388 openssl.cpp:563] Using CA file: 
C:\Users\mesos\AppData\Local\Temp\7tcras\cert.pem
I1113 22:35:09.456182   388 openssl.cpp:509] CA directory path unspecified! 
NOTE: Set CA directory path with LIBPROCESS_SSL_CA_DIR=
I1113 22:35:09.457181   388 openssl.cpp:514] Will not verify peer certificate!
NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peer certificate verification
I1113 22:35:09.457181   388 openssl.cpp:526] Will use IP address verification 
in subject alternative name certificate extension.
I1113 22:35:09.457181   388 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT 
implies peer certificate verification.
LIBPROCESS_SSL_VERIFY_CERT set to true
I1113 22:35:09.457181   388 openssl.cpp:563] Using CA file: 
C:\Users\mesos\AppData\Local\Temp\eGNHTo\cert.pem
I1113 22:35:10.005447  4220 process.cpp:1052] Failed to accept socket: future 
discarded
```

- Mesos Reviewbot Windows


On Nov. 13, 2017, 1:32 p.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
>