Re: Review Request 63816: Windows: Fixed MESOS-6816 to enable `ExecutorEnvironmentVariables`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63816/ --- (Updated Nov. 29, 2017, 2:48 p.m.) Review request for mesos, Akash Gupta, Jie Yu, John Kordich, Joseph Wu, and Michael Park. Changes --- Rebased. Bugs: MESOS-6816 https://issues.apache.org/jira/browse/MESOS-6816 Repository: mesos Description --- By removing the explicit system environment override code, and instead setting the system environment as the default in the `CreateProcess` wrapper, the `SlaveTest.ExecutorEnvironmentVariables` can be enabled. Note that this also required fixing `os::host_default_path()` and using it, because the test used `PATH = /bin`, which breaks on Windows. Diffs (updated) - src/slave/containerizer/docker.cpp 9918d83cad3a73242de09819ef9beabdbdca2a94 src/slave/containerizer/mesos/launch.cpp 4fabf9228f1699d07cd6dd6d1752bac096ce76c1 src/tests/slave_tests.cpp b35497bfa9363815845f339b6c3a7f871932b26d Diff: https://reviews.apache.org/r/63816/diff/3/ Changes: https://reviews.apache.org/r/63816/diff/2-3/ Testing --- Thanks, Andrew Schwartzmeyer
Re: Review Request 63816: Windows: Fixed MESOS-6816 to enable `ExecutorEnvironmentVariables`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63816/ --- (Updated Nov. 28, 2017, 4:10 p.m.) Review request for mesos, Akash Gupta, Jie Yu, John Kordich, Joseph Wu, and Michael Park. Changes --- clang-format/rebase Bugs: MESOS-6816 https://issues.apache.org/jira/browse/MESOS-6816 Repository: mesos Description --- By removing the explicit system environment override code, and instead setting the system environment as the default in the `CreateProcess` wrapper, the `SlaveTest.ExecutorEnvironmentVariables` can be enabled. Note that this also required fixing `os::host_default_path()` and using it, because the test used `PATH = /bin`, which breaks on Windows. Diffs (updated) - src/slave/containerizer/docker.cpp 9918d83cad3a73242de09819ef9beabdbdca2a94 src/slave/containerizer/mesos/launch.cpp b1584ff292ada5463917792908a13e00859fd1ae src/tests/slave_tests.cpp a2274b691cf94b003c4bc15450d176a9c73517d5 Diff: https://reviews.apache.org/r/63816/diff/2/ Changes: https://reviews.apache.org/r/63816/diff/1-2/ Testing --- Thanks, Andrew Schwartzmeyer
Re: Review Request 63816: Windows: Fixed MESOS-6816 to enable `ExecutorEnvironmentVariables`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63816/#review191988 --- Ship it! Ship It! - Akash Gupta On Nov. 14, 2017, 11:17 p.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63816/ > --- > > (Updated Nov. 14, 2017, 11:17 p.m.) > > > Review request for mesos, Akash Gupta, Jie Yu, John Kordich, Joseph Wu, and > Michael Park. > > > Bugs: MESOS-6816 > https://issues.apache.org/jira/browse/MESOS-6816 > > > Repository: mesos > > > Description > --- > > By removing the explicit system environment override code, and instead > setting the system environment as the default in the `CreateProcess` > wrapper, the `SlaveTest.ExecutorEnvironmentVariables` can be enabled. > Note that this also required fixing `os::host_default_path()` and using > it, because the test used `PATH = /bin`, which breaks on Windows. > > > Diffs > - > > src/slave/containerizer/docker.cpp 292eecbca246edf068ec8c262aff4f3ce9cd8c67 > src/slave/containerizer/mesos/launch.cpp > b1584ff292ada5463917792908a13e00859fd1ae > src/tests/slave_tests.cpp 61dd940e4452a1dbc6c0361bfc917bdc2dd16be8 > > > Diff: https://reviews.apache.org/r/63816/diff/1/ > > > Testing > --- > > > Thanks, > > Andrew Schwartzmeyer > >
Re: Review Request 63816: Windows: Fixed MESOS-6816 to enable `ExecutorEnvironmentVariables`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63816/#review191100 --- Ship it! - John Kordich On Nov. 14, 2017, 11:17 p.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63816/ > --- > > (Updated Nov. 14, 2017, 11:17 p.m.) > > > Review request for mesos, Akash Gupta, Jie Yu, John Kordich, Joseph Wu, and > Michael Park. > > > Bugs: MESOS-6816 > https://issues.apache.org/jira/browse/MESOS-6816 > > > Repository: mesos > > > Description > --- > > By removing the explicit system environment override code, and instead > setting the system environment as the default in the `CreateProcess` > wrapper, the `SlaveTest.ExecutorEnvironmentVariables` can be enabled. > Note that this also required fixing `os::host_default_path()` and using > it, because the test used `PATH = /bin`, which breaks on Windows. > > > Diffs > - > > src/slave/containerizer/docker.cpp 292eecbca246edf068ec8c262aff4f3ce9cd8c67 > src/slave/containerizer/mesos/launch.cpp > b1584ff292ada5463917792908a13e00859fd1ae > src/tests/slave_tests.cpp 61dd940e4452a1dbc6c0361bfc917bdc2dd16be8 > > > Diff: https://reviews.apache.org/r/63816/diff/1/ > > > Testing > --- > > > Thanks, > > Andrew Schwartzmeyer > >
