Re: Review Request 64868: Added initial doc about CSI support in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64868/#review194726 --- Fix it, then Ship it! It's probably worth taking a look at

Re: Review Request 64868: Added initial doc about CSI support in Mesos.

> On Dec. 29, 2017, 3:03 p.m., James DeFelice wrote: > > docs/csi.md > > Lines 415 (patched) > > > > > > this is a protobuf3 type, for which there are specific rules re: > > JSON-ification: > >

Re: Review Request 64868: Added initial doc about CSI support in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64868/ --- (Updated Jan. 3, 2018, 5:09 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 64868: Added initial doc about CSI support in Mesos.

- Jie --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64868/#review194631 --- On Dec. 29, 2017, 4:53 a.m., Jie Yu wrote: > >

Re: Review Request 64868: Added initial doc about CSI support in Mesos.

> On Dec. 29, 2017, 3:03 p.m., James DeFelice wrote: > > docs/csi.md > > Lines 385 (patched) > > > > > > I'd like to see it called out clearly in the text (vs. being embedded > > in a link) the specific version of

Re: Review Request 64868: Added initial doc about CSI support in Mesos.

> On Dec. 29, 2017, 3:03 p.m., James DeFelice wrote: > > docs/csi.md > > Lines 151 (patched) > > > > > > Can we make it clear that we're talking about a hypothetical EBS > > plugin? AFAIK the external resource

Re: Review Request 64868: Added initial doc about CSI support in Mesos.

> On Dec. 29, 2017, 3:03 p.m., James DeFelice wrote: > > docs/csi.md > > Lines 137 (patched) > > > > > > > Any disk resource ... inherits the same profile as the storage pool. > > > > Why, and who enforces

Re: Review Request 64868: Added initial doc about CSI support in Mesos.

> On Dec. 29, 2017, 3:03 p.m., James DeFelice wrote: > > docs/csi.md > > Lines 298 (patched) > > > > > > this feels like a separate feature. should it be documented elsewhere? Removed the protobuf because it's not

Re: Review Request 64868: Added initial doc about CSI support in Mesos.

> On Jan. 2, 2018, 10:27 p.m., Gaston Kleiman wrote: > > docs/csi.md > > Lines 781-783 (patched) > > > > > > We should probalby say what's the difference between removing an SLRP > > and marking it as gone. I guess

Re: Review Request 64868: Added initial doc about CSI support in Mesos.

> On Jan. 2, 2018, 10:27 p.m., Gaston Kleiman wrote: > > docs/csi.md > > Lines 288-291 (patched) > > > > > > s/framework/scheduler/ > > s/that is available to the frameworks/that is available to them/ > >

Re: Review Request 64868: Added initial doc about CSI support in Mesos.

> On Jan. 2, 2018, 7:53 p.m., Greg Mann wrote: > > Should we mention somewhere that the `--enable-grpc` configure flag must be > > set to enable CSI support in the agent? Good call. Added. - Jie --- This is an automatically generated

Re: Review Request 64868: Added initial doc about CSI support in Mesos.

> On Jan. 2, 2018, 7:49 p.m., Greg Mann wrote: > > docs/csi.md > > Lines 109 (patched) > > > > > > I'm curious: is this accurate as written, or would "must not be set by > > frameworks" be more appropriate? > >

Re: Review Request 64868: Added initial doc about CSI support in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64868/#review194653 --- docs/csi.md Lines 21 (patched)

Re: Review Request 64868: Added initial doc about CSI support in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64868/#review194646 --- Should we mention somewhere that the `--enable-grpc` configure

Re: Review Request 64868: Added initial doc about CSI support in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64868/#review194631 --- docs/csi.md Lines 21 (patched)

Re: Review Request 64868: Added initial doc about CSI support in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64868/#review194600 --- docs/csi.md Lines 137 (patched)

Re: Review Request 64868: Added initial doc about CSI support in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64868/ --- (Updated Dec. 29, 2017, 4:53 a.m.) Review request for mesos, Benjamin Bannier,