Re: Review Request 65189: Displayed all needed commands in apply-reviews script dry-run mode.

2018-01-25 Thread Till Toenshoff 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65189/#review196258
---


Ship it!




Ship It!

- Till Toenshoff


On Jan. 25, 2018, 8:40 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65189/
> ---
> 
> (Updated Jan. 25, 2018, 8:40 a.m.)
> 
> 
> Review request for mesos, Armand Grillet and Kevin Klues.
> 
> 
> Bugs: MESOS-8447
> https://issues.apache.org/jira/browse/MESOS-8447
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds a shell command to create a file containing the commit
> message for dry-run mode. To minimize platform differences we use
> `printf` instead of `echo`. We output the message on a single line
> for compactness.
> 
> 
> Diffs
> -
> 
>   support/apply-reviews.py 0ef28cb02bc65acfeb7ea6808f74e1620a8a85c4 
> 
> 
> Diff: https://reviews.apache.org/r/65189/diff/3/
> 
> 
> Testing
> ---
> 
> Redirected output of `apply-reviews.py --dry-run` to a file and successfully 
> applied its output with `sh`.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 65189: Displayed all needed commands in apply-reviews script dry-run mode.

2018-01-25 Thread Armand Grillet 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65189/#review196231
---


Ship it!




Ship It!

- Armand Grillet


On Jan. 25, 2018, 8:40 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65189/
> ---
> 
> (Updated Jan. 25, 2018, 8:40 a.m.)
> 
> 
> Review request for mesos, Armand Grillet and Kevin Klues.
> 
> 
> Bugs: MESOS-8447
> https://issues.apache.org/jira/browse/MESOS-8447
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds a shell command to create a file containing the commit
> message for dry-run mode. To minimize platform differences we use
> `printf` instead of `echo`. We output the message on a single line
> for compactness.
> 
> 
> Diffs
> -
> 
>   support/apply-reviews.py 0ef28cb02bc65acfeb7ea6808f74e1620a8a85c4 
> 
> 
> Diff: https://reviews.apache.org/r/65189/diff/3/
> 
> 
> Testing
> ---
> 
> Redirected output of `apply-reviews.py --dry-run` to a file and successfully 
> applied its output with `sh`.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 65189: Displayed all needed commands in apply-reviews script dry-run mode.

2018-01-25 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65189/#review196229
---



PASS: Mesos patch 65189 was successfully built and tested.

Reviews applied: `['65189']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65189

- Mesos Reviewbot Windows


On Jan. 25, 2018, 8:40 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65189/
> ---
> 
> (Updated Jan. 25, 2018, 8:40 a.m.)
> 
> 
> Review request for mesos, Armand Grillet and Kevin Klues.
> 
> 
> Bugs: MESOS-8447
> https://issues.apache.org/jira/browse/MESOS-8447
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds a shell command to create a file containing the commit
> message for dry-run mode. To minimize platform differences we use
> `printf` instead of `echo`. We output the message on a single line
> for compactness.
> 
> 
> Diffs
> -
> 
>   support/apply-reviews.py 0ef28cb02bc65acfeb7ea6808f74e1620a8a85c4 
> 
> 
> Diff: https://reviews.apache.org/r/65189/diff/3/
> 
> 
> Testing
> ---
> 
> Redirected output of `apply-reviews.py --dry-run` to a file and successfully 
> applied its output with `sh`.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 65189: Displayed all needed commands in apply-reviews script dry-run mode.

2018-01-25 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65189/
---

(Updated Jan. 25, 2018, 9:40 a.m.)


Review request for mesos, Armand Grillet and Kevin Klues.


Changes
---

Fixed handling of strings containing characters requiring escaping or literal 
quotes.


Bugs: MESOS-8447
https://issues.apache.org/jira/browse/MESOS-8447


Repository: mesos


Description
---

This patch adds a shell command to create a file containing the commit
message for dry-run mode. To minimize platform differences we use
`printf` instead of `echo`. We output the message on a single line
for compactness.


Diffs (updated)
-

  support/apply-reviews.py 0ef28cb02bc65acfeb7ea6808f74e1620a8a85c4 


Diff: https://reviews.apache.org/r/65189/diff/3/

Changes: https://reviews.apache.org/r/65189/diff/2-3/


Testing
---

Redirected output of `apply-reviews.py --dry-run` to a file and successfully 
applied its output with `sh`.


Thanks,

Benjamin Bannier

Re: Review Request 65189: Displayed all needed commands in apply-reviews script dry-run mode.

2018-01-25 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65189/#review196221
---




support/apply-reviews.py
Lines 274-275 (patched)


Manually quoting the string and escaping newlines is insufficient. We also 
need to be able to handle e.g., strings containing literal `'` or `"` or other 
characters requiring escaping.


- Benjamin Bannier


On Jan. 22, 2018, 2:58 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65189/
> ---
> 
> (Updated Jan. 22, 2018, 2:58 p.m.)
> 
> 
> Review request for mesos, Armand Grillet and Kevin Klues.
> 
> 
> Bugs: MESOS-8447
> https://issues.apache.org/jira/browse/MESOS-8447
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds a shell command to create a file containing the commit
> message for dry-run mode. To minimize platform differences we use
> `printf` instead of `echo`. We output the message on a single line
> for compactness.
> 
> 
> Diffs
> -
> 
>   support/apply-reviews.py 0ef28cb02bc65acfeb7ea6808f74e1620a8a85c4 
> 
> 
> Diff: https://reviews.apache.org/r/65189/diff/2/
> 
> 
> Testing
> ---
> 
> Redirected output of `apply-reviews.py --dry-run` to a file and successfully 
> applied its output with `sh`.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 65189: Displayed all needed commands in apply-reviews script dry-run mode.

2018-01-22 Thread Armand Grillet 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65189/#review195911
---


Ship it!




Ship It!

- Armand Grillet


On Jan. 22, 2018, 1:58 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65189/
> ---
> 
> (Updated Jan. 22, 2018, 1:58 p.m.)
> 
> 
> Review request for mesos, Armand Grillet and Kevin Klues.
> 
> 
> Bugs: MESOS-8447
> https://issues.apache.org/jira/browse/MESOS-8447
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds a shell command to create a file containing the commit
> message for dry-run mode. To minimize platform differences we use
> `printf` instead of `echo`. We output the message on a single line
> for compactness.
> 
> 
> Diffs
> -
> 
>   support/apply-reviews.py 0ef28cb02bc65acfeb7ea6808f74e1620a8a85c4 
> 
> 
> Diff: https://reviews.apache.org/r/65189/diff/2/
> 
> 
> Testing
> ---
> 
> Redirected output of `apply-reviews.py --dry-run` to a file and successfully 
> applied its output with `sh`.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 65189: Displayed all needed commands in apply-reviews script dry-run mode.

2018-01-22 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65189/#review195907
---



PASS: Mesos patch 65189 was successfully built and tested.

Reviews applied: `['65189']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65189

- Mesos Reviewbot Windows


On Jan. 22, 2018, 7:58 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65189/
> ---
> 
> (Updated Jan. 22, 2018, 7:58 a.m.)
> 
> 
> Review request for mesos, Armand Grillet and Kevin Klues.
> 
> 
> Bugs: MESOS-8447
> https://issues.apache.org/jira/browse/MESOS-8447
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds a shell command to create a file containing the commit
> message for dry-run mode. To minimize platform differences we use
> `printf` instead of `echo`. We output the message on a single line
> for compactness.
> 
> 
> Diffs
> -
> 
>   support/apply-reviews.py 0ef28cb02bc65acfeb7ea6808f74e1620a8a85c4 
> 
> 
> Diff: https://reviews.apache.org/r/65189/diff/2/
> 
> 
> Testing
> ---
> 
> Redirected output of `apply-reviews.py --dry-run` to a file and successfully 
> applied its output with `sh`.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 65189: Displayed all needed commands in apply-reviews script dry-run mode.

2018-01-22 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65189/
---

(Updated Jan. 22, 2018, 2:58 p.m.)


Review request for mesos, Armand Grillet and Kevin Klues.


Changes
---

Renamed variable.


Bugs: MESOS-8447
https://issues.apache.org/jira/browse/MESOS-8447


Repository: mesos


Description
---

This patch adds a shell command to create a file containing the commit
message for dry-run mode. To minimize platform differences we use
`printf` instead of `echo`. We output the message on a single line
for compactness.


Diffs (updated)
-

  support/apply-reviews.py 0ef28cb02bc65acfeb7ea6808f74e1620a8a85c4 


Diff: https://reviews.apache.org/r/65189/diff/2/

Changes: https://reviews.apache.org/r/65189/diff/1-2/


Testing
---

Redirected output of `apply-reviews.py --dry-run` to a file and successfully 
applied its output with `sh`.


Thanks,

Benjamin Bannier

Re: Review Request 65189: Displayed all needed commands in apply-reviews script dry-run mode.

2018-01-22 Thread Armand Grillet 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65189/#review195884
---




support/apply-reviews.py
Lines 275 (patched)


Can you rename `message` to something else as we already have `with 
open(message_file, 'w') as message:`.


- Armand Grillet


On Jan. 17, 2018, 12:22 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65189/
> ---
> 
> (Updated Jan. 17, 2018, 12:22 p.m.)
> 
> 
> Review request for mesos, Armand Grillet and Kevin Klues.
> 
> 
> Bugs: MESOS-8447
> https://issues.apache.org/jira/browse/MESOS-8447
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds a shell command to create a file containing the commit
> message for dry-run mode. To minimize platform differences we use
> `printf` instead of `echo`. We output the message on a single line
> for compactness.
> 
> 
> Diffs
> -
> 
>   support/apply-reviews.py 0ef28cb02bc65acfeb7ea6808f74e1620a8a85c4 
> 
> 
> Diff: https://reviews.apache.org/r/65189/diff/1/
> 
> 
> Testing
> ---
> 
> Redirected output of `apply-reviews.py --dry-run` to a file and successfully 
> applied its output with `sh`.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 65189: Displayed all needed commands in apply-reviews script dry-run mode.

2018-01-17 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65189/#review195562
---



PASS: Mesos patch 65189 was successfully built and tested.

Reviews applied: `['65189']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65189

- Mesos Reviewbot Windows


On Jan. 17, 2018, 12:22 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65189/
> ---
> 
> (Updated Jan. 17, 2018, 12:22 p.m.)
> 
> 
> Review request for mesos, Armand Grillet and Kevin Klues.
> 
> 
> Bugs: MESOS-8447
> https://issues.apache.org/jira/browse/MESOS-8447
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds a shell command to create a file containing the commit
> message for dry-run mode. To minimize platform differences we use
> `printf` instead of `echo`. We output the message on a single line
> for compactness.
> 
> 
> Diffs
> -
> 
>   support/apply-reviews.py 0ef28cb02bc65acfeb7ea6808f74e1620a8a85c4 
> 
> 
> Diff: https://reviews.apache.org/r/65189/diff/1/
> 
> 
> Testing
> ---
> 
> Redirected output of `apply-reviews.py --dry-run` to a file and successfully 
> applied its output with `sh`.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>