Re: Review Request 65310: Added lambda::zip.

2018-03-08 Thread Alexander Rojas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65310/
---

(Updated March 8, 2018, 1:10 p.m.)


Review request for mesos, Benjamin Hindman and Greg Mann.


Bugs: MESOS-8434
https://issues.apache.org/jira/browse/MESOS-8434


Repository: mesos


Description
---

Introduces the abstractions `lambda::zip` and `lambda::zipto` which
provides a functionality similar to python's  `zip()` call.

This patch supersedes the stalled review
https://reviews.apache.org/r/63292/.


Diffs (updated)
-

  3rdparty/stout/include/stout/lambda.hpp 
c9212be27b45da45f15371689f2aabf18c98657b 
  3rdparty/stout/tests/lambda_tests.cpp 
11b034306b11b95efa9bcd9811c5145ad39314a5 


Diff: https://reviews.apache.org/r/65310/diff/5/

Changes: https://reviews.apache.org/r/65310/diff/4-5/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 65310: Added lambda::zip.

2018-03-07 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65310/#review198805
---


Fix it, then Ship it!





3rdparty/stout/tests/lambda_tests.cpp
Lines 18-19 (patched)


I don't think these includes are necessary?

I do see a few missing, however:









- Greg Mann


On March 6, 2018, 10:11 a.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65310/
> ---
> 
> (Updated March 6, 2018, 10:11 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Greg Mann.
> 
> 
> Bugs: MESOS-8434
> https://issues.apache.org/jira/browse/MESOS-8434
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Introduces the abstractions `lambda::zip` and `lambda::zipto` which
> provides a functionality similar to python's  `zip()` call.
> 
> This patch supersedes the stalled review
> https://reviews.apache.org/r/63292/.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/lambda.hpp 
> c9212be27b45da45f15371689f2aabf18c98657b 
>   3rdparty/stout/tests/lambda_tests.cpp 
> 11b034306b11b95efa9bcd9811c5145ad39314a5 
> 
> 
> Diff: https://reviews.apache.org/r/65310/diff/4/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 65310: Added lambda::zip.

2018-03-06 Thread Alexander Rojas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65310/
---

(Updated March 6, 2018, 11:11 a.m.)


Review request for mesos, Benjamin Hindman and Greg Mann.


Bugs: MESOS-8434
https://issues.apache.org/jira/browse/MESOS-8434


Repository: mesos


Description (updated)
---

Introduces the abstractions `lambda::zip` and `lambda::zipto` which
provides a functionality similar to python's  `zip()` call.

This patch supersedes the stalled review
https://reviews.apache.org/r/63292/.


Diffs (updated)
-

  3rdparty/stout/include/stout/lambda.hpp 
c9212be27b45da45f15371689f2aabf18c98657b 
  3rdparty/stout/tests/lambda_tests.cpp 
11b034306b11b95efa9bcd9811c5145ad39314a5 


Diff: https://reviews.apache.org/r/65310/diff/4/

Changes: https://reviews.apache.org/r/65310/diff/3-4/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 65310: Added lambda::zip.

2018-03-02 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65310/#review198563
---




3rdparty/stout/include/stout/lambda.hpp
Line 22 (original), 22 (patched)


In description:
s/pyhton/python/



3rdparty/stout/include/stout/lambda.hpp
Lines 169-170 (patched)


Nit: enclose `std::pair` and `std::tuple` in backticks, for consistency.



3rdparty/stout/include/stout/lambda.hpp
Lines 202 (patched)


s/parametrize/parametrized/


- Greg Mann


On Jan. 25, 2018, 3:34 p.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65310/
> ---
> 
> (Updated Jan. 25, 2018, 3:34 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Greg Mann.
> 
> 
> Bugs: MESOS-8434
> https://issues.apache.org/jira/browse/MESOS-8434
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Introduces the abstractions `lambda::zip` and `lambda::zipto` which
> provides a functionality similar to pyhton's  `zip()` call.
> 
> This patch supersedes the stalled review
> https://reviews.apache.org/r/63292/.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/lambda.hpp 
> c9212be27b45da45f15371689f2aabf18c98657b 
>   3rdparty/stout/tests/lambda_tests.cpp 
> 11b034306b11b95efa9bcd9811c5145ad39314a5 
> 
> 
> Diff: https://reviews.apache.org/r/65310/diff/3/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 65310: Added lambda::zip.

2018-01-25 Thread Alexander Rojas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65310/
---

(Updated Jan. 25, 2018, 4:34 p.m.)


Review request for mesos, Benjamin Hindman and Greg Mann.


Changes
---

Revert to original implementation since some older compilers have problems 
resolving some template arguments or calling the right constructors.


Bugs: MESOS-8434
https://issues.apache.org/jira/browse/MESOS-8434


Repository: mesos


Description (updated)
---

Introduces the abstractions `lambda::zip` and `lambda::zipto` which
provides a functionality similar to pyhton's `zip()` call.

This patch supersedes the stalled review
https://reviews.apache.org/r/63292/.


Diffs (updated)
-

  3rdparty/stout/include/stout/lambda.hpp 
c9212be27b45da45f15371689f2aabf18c98657b 
  3rdparty/stout/tests/lambda_tests.cpp 
11b034306b11b95efa9bcd9811c5145ad39314a5 


Diff: https://reviews.apache.org/r/65310/diff/2/

Changes: https://reviews.apache.org/r/65310/diff/1-2/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 65310: Added lambda::zip.

2018-01-24 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65310/#review196146
---



FAIL: Mesos stout-tests failed to build.

Reviews applied: `['65310']`

Failed command: `cmake.exe --build . --target stout-tests --config Debug`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65310

Relevant logs:

- 
[stout-tests-build-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65310/logs/stout-tests-build-cmake-stdout.log):

```
  copyfile_tests.cpp
  env_tests.cpp
  Unknown compiler version - please run the configure tests and report the 
results
  Unknown compiler version - please run the configure tests and report the 
results
  filesystem_tests.cpp
  process_tests.cpp
  rmdir_tests.cpp
  Unknown compiler version - please run the configure tests and report the 
results
  socket_tests.cpp
  Unknown compiler version - please run the configure tests and report the 
results
  Unknown compiler version - please run the configure tests and report the 
results
  strerror_tests.cpp
  Unknown compiler version - please run the configure tests and report the 
results
  Unknown compiler version - please run the configure tests and report the 
results
Done Building Project "D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj" 
(default targets) -- FAILED.

Build FAILED.

"D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj" (default target) (1) ->
(ClCompile target) -> 
  D:\DCOS\mesos\mesos\3rdparty\stout\tests\lambda_tests.cpp(115): error C2672: 
'lambda::zip': no matching overloaded function found 
[D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
  D:\DCOS\mesos\mesos\3rdparty\stout\tests\lambda_tests.cpp(115): error C2783: 
'MapIterable lambda::zip(const InputIterable1 &,const 
InputIterable2 &)': could not deduce template argument for 
'MapIterable' [D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
  D:\DCOS\mesos\mesos\3rdparty\stout\tests\lambda_tests.cpp(129): error C2672: 
'lambda::zipto': no matching overloaded function found 
[D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
  D:\DCOS\mesos\mesos\3rdparty\stout\tests\lambda_tests.cpp(129): error C2783: 
'OutputIterable> lambda::zipto(const 
InputIterable1 &,const InputIterable2 &)': could not 
deduce template argument for 'HeterogeneusContainer' 
[D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]

0 Warning(s)
4 Error(s)

Time Elapsed 00:01:08.90
```

- 
[stout-tests-CMakeOutput.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65310/logs/stout-tests-CMakeOutput.log):

```
  Creating directory "cmTC_4bc2c.dir\Debug\".

  Creating directory "D:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\".

  Creating directory "cmTC_4bc2c.dir\Debug\cmTC_4bc2c.tlog\".

InitializeBuildStatus:

  Creating "cmTC_4bc2c.dir\Debug\cmTC_4bc2c.tlog\unsuccessfulbuild" because 
"AlwaysCreate" was specified.

ClCompile:

  C:\Program Files (x86)\Microsoft Visual 
Studio\2017\Community\VC\Tools\MSVC\14.12.25827\bin\HostX64\x64\CL.exe /c /Zi 
/W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D 
COMPILER_SUPPORTS_CXX11 /D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 
/MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /GR 
/Fo"cmTC_4bc2c.dir\Debug\" /Fd"cmTC_4bc2c.dir\Debug\vc141.pdb" /Gd /TP 
/errorReport:queue D:\DCOS\mesos\CMakeFiles\CMakeTmp\src.cxx

  Microsoft (R) C/C++ Optimizing Compiler Version 19.12.25830.2 for x64

  Copyright (C) Microsoft Corporation.  All rights reserved.

  

  cl /c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D 
COMPILER_SUPPORTS_CXX11 /D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 
/MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /GR 
/Fo"cmTC_4bc2c.dir\Debug\" /Fd"cmTC_4bc2c.dir\Debug\vc141.pdb" /Gd /TP 
/errorReport:queue D:\DCOS\mesos\CMakeFiles\CMakeTmp\src.cxx

  src.cxx

  

Link:

  C:\Program Files (x86)\Microsoft Visual 
Studio\2017\Community\VC\Tools\MSVC\14.12.25827\bin\HostX64\x64\link.exe 
/ERRORREPORT:QUEUE 
/OUT:"D:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_4bc2c.exe" /INCREMENTAL 
/NOLOGO kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib 
oleaut32.lib uuid.lib comdlg32.lib advapi32.lib /MANIFEST 
/MANIFESTUAC:"level='asInvoker' uiAccess='false'" /manifest:embed /DEBUG 
/PDB:"D:/DCOS/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_4bc2c.pdb" 
/SUBSYSTEM:CONSOLE /TLBID:1 /DYNAMICBASE /NXCOMPAT 
/IMPLIB:"D:/DCOS/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_4bc2c.lib" /MACHINE:X64  
/machine:x64 cmTC_4bc2c.dir\Debug\src.obj

  cmTC_4bc2c.vcxproj -> D:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_4bc2c.exe

FinalizeBuildStatus:

  Deleting file "cmTC_4bc2c.dir\Debug\cmTC_4bc2c.tlog\unsuccessfulbuild".

  Touching "cmTC_4bc2c.dir\Debug\cmTC_4bc2c.tlog\cmTC_4bc2c.lastbuildstate".

Done Building Project "D:\DCOS\mesos\CMa