Re: Review Request 65475: Fixed SSL socket shutdown returned errno.

2018-02-02 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65475/#review196781 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 65475: Fixed SSL socket shutdown returned errno.

2018-02-02 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65475/ --- (Updated Feb. 3, 2018, 4:48 a.m.) Review request for . Repository: mesos

Re: Review Request 65475: Fixed SSL socket shutdown returned errno.

2018-02-02 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65475/ --- (Updated Feb. 3, 2018, 4:48 a.m.) Review request for . Repository: mesos

Re: Review Request 65475: Fixed SSL socket shutdown returned errno.

2018-02-02 Thread Till Toenshoff
> On Feb. 2, 2018, 6:04 a.m., Benjamin Mahler wrote: > > Can you include Andy on this review as well? I would love to know what the > > suggested approach to this is; if there is some solution in place other > > than `#ifdef`s. > > Andrew Schwartzmeyer wrote: > Depending on how this error

Re: Review Request 65475: Fixed SSL socket shutdown returned errno.

2018-02-02 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65475/#review196755 --- Ship it! Per discussion with Andy, I'm ok with either

Re: Review Request 65475: Fixed SSL socket shutdown returned errno.

2018-02-02 Thread Benjamin Mahler
> On Feb. 2, 2018, 6:04 a.m., Benjamin Mahler wrote: > > Can you include Andy on this review as well? I would love to know what the > > suggested approach to this is; if there is some solution in place other > > than `#ifdef`s. > > Andrew Schwartzmeyer wrote: > Depending on how this error

Re: Review Request 65475: Fixed SSL socket shutdown returned errno.

2018-02-02 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65475/#review196747 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 65475: Fixed SSL socket shutdown returned errno.

2018-02-02 Thread Andrew Schwartzmeyer
> On Feb. 1, 2018, 10:04 p.m., Benjamin Mahler wrote: > > Can you include Andy on this review as well? I would love to know what the > > suggested approach to this is; if there is some solution in place other > > than `#ifdef`s. > > Andrew Schwartzmeyer wrote: > Depending on how this

Re: Review Request 65475: Fixed SSL socket shutdown returned errno.

2018-02-01 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65475/#review196687 --- Can you include Andy on this review as well? I would love to know