Re: Review Request 65838: Updated validation of 'RAW' and 'BLOCK' disk resources.

2018-03-05 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65838/#review198631 --- PASS: Mesos patch 65838 was successfully built and tested. Review

Re: Review Request 65838: Updated validation of 'RAW' and 'BLOCK' disk resources.

2018-03-05 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65838/#review198630 --- Patch looks great! Reviews applied: [65838] Passed command: expo

Re: Review Request 65838: Updated validation of 'RAW' and 'BLOCK' disk resources.

2018-03-05 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65838/ --- (Updated March 5, 2018, 2:49 p.m.) Review request for mesos, Chun-Hung Hsiao, J

Re: Review Request 65838: Updated validation of 'RAW' and 'BLOCK' disk resources.

2018-03-02 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65838/#review198547 --- src/common/resources.cpp Lines 936 (patched)

Re: Review Request 65838: Updated validation of 'RAW' and 'BLOCK' disk resources.

2018-03-02 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65838/#review198546 --- Ship it! Ship It! - Chun-Hung Hsiao On March 2, 2018, 10:46

Re: Review Request 65838: Updated validation of 'RAW' and 'BLOCK' disk resources.

2018-03-02 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65838/#review198531 --- Patch looks great! Reviews applied: [65838] Passed command: expo

Re: Review Request 65838: Updated validation of 'RAW' and 'BLOCK' disk resources.

2018-03-02 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65838/#review198522 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 65838: Updated validation of 'RAW' and 'BLOCK' disk resources.

2018-03-02 Thread Benjamin Bannier
> On March 1, 2018, 2:57 p.m., Jan Schlicht wrote: > > Please add this to `v1/resources.cpp` as well. Done. - Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65838/#review198447

Re: Review Request 65838: Updated validation of 'RAW' and 'BLOCK' disk resources.

2018-03-02 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65838/ --- (Updated March 2, 2018, 11:46 a.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 65838: Updated validation of 'RAW' and 'BLOCK' disk resources.

2018-03-01 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65838/#review198447 --- Please add this to `v1/resources.cpp` as well. - Jan Schlicht O

Re: Review Request 65838: Updated validation of 'RAW' and 'BLOCK' disk resources.

2018-02-28 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65838/#review198402 --- Patch looks great! Reviews applied: [65838] Passed command: expo

Re: Review Request 65838: Updated validation of 'RAW' and 'BLOCK' disk resources.

2018-02-28 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65838/#review198397 --- FAIL: Some of the unit tests failed. Please check the relevant log