Re: Review Request 65899: Use launch actions in `MesosContainerizerLaunchHelper` instead.

2018-03-15 Thread Eric Chung
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65899/#review199276 --- Ship it! Ship It! - Eric Chung On March 15, 2018, 8:18 a.m.,

Re: Review Request 65899: Use launch actions in `MesosContainerizerLaunchHelper` instead.

2018-03-15 Thread Jason Lai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65899/ --- (Updated March 15, 2018, 8:18 a.m.) Review request for mesos, Anish Gupta, Eric

Re: Review Request 65899: Use launch actions in `MesosContainerizerLaunchHelper` instead.

2018-03-14 Thread Jason Lai
> On March 7, 2018, 2:28 a.m., Eric Chung wrote: > > src/slave/containerizer/mesos/launch.cpp > > Lines 583 (patched) > > > > > > why is the explicit delete needed here? was it not being cleaned up > > previously?

Re: Review Request 65899: Use launch actions in `MesosContainerizerLaunchHelper` instead.

2018-03-06 Thread Eric Chung
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65899/#review198759 --- src/slave/containerizer/mesos/launch.cpp Lines 583 (patched)

Re: Review Request 65899: Use launch actions in `MesosContainerizerLaunchHelper` instead.

2018-03-05 Thread Jason Lai
> On March 5, 2018, 9:10 a.m., Mesos Reviewbot Windows wrote: > > FAIL: Some of the unit tests failed. Please check the relevant logs. > > > > Reviews applied: `['65811', '65812', '65898', '65899']` > > > > Failed command: `Start-MesosCITesting` > > > > All the build artifacts available at: >

Re: Review Request 65899: Use launch actions in `MesosContainerizerLaunchHelper` instead.

2018-03-05 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65899/#review198620 --- Patch looks great! Reviews applied: [65811, 65812, 65898, 65899]

Re: Review Request 65899: Use launch actions in `MesosContainerizerLaunchHelper` instead.

2018-03-05 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65899/#review198616 --- FAIL: Some of the unit tests failed. Please check the relevant log