Re: Review Request 66220: Added test for `GROW_VOLUME` and `SHRINK_VOLUME` operations.

> On April 17, 2018, 3:52 p.m., Gaston Kleiman wrote: > > src/tests/persistent_volume_tests.cpp > > Lines 474-475 (patched) > > > > > > I see that Benjamin recently added this line and the corresponding > >

Re: Review Request 66220: Added test for `GROW_VOLUME` and `SHRINK_VOLUME` operations.

> On April 15, 2018, 5:39 p.m., Chun-Hung Hsiao wrote: > > src/tests/persistent_volume_tests.cpp > > Lines 455-459 (patched) > > > > > > Or alternatively, we can do the following: > > ``` > > class

Re: Review Request 66220: Added test for `GROW_VOLUME` and `SHRINK_VOLUME` operations.

> On April 15, 2018, 5:39 p.m., Chun-Hung Hsiao wrote: > > src/tests/persistent_volume_tests.cpp > > Lines 453 (patched) > > > > > > If I'm not mistaken, this test does the following steps: > > > > 1.

Re: Review Request 66220: Added test for `GROW_VOLUME` and `SHRINK_VOLUME` operations.

> On April 13, 2018, 9:43 a.m., Greg Mann wrote: > > src/tests/persistent_volume_tests.cpp > > Lines 455-459 (patched) > > > > > > Is this enforced somewhere in validation code? Can we check for > > expected

Re: Review Request 66220: Added test for `GROW_VOLUME` and `SHRINK_VOLUME` operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66220/#review201355 --- src/tests/persistent_volume_tests.cpp Lines 474-475 (patched)

Re: Review Request 66220: Added test for `GROW_VOLUME` and `SHRINK_VOLUME` operations.

> On April 13, 2018, 9:43 a.m., Greg Mann wrote: > > src/tests/persistent_volume_tests.cpp > > Lines 455-459 (patched) > > > > > > Is this enforced somewhere in validation code? Can we check for > > expected

Re: Review Request 66220: Added test for `GROW_VOLUME` and `SHRINK_VOLUME` operations.

> On April 16, 2018, 5:57 p.m., Zhitao Li wrote: > > src/tests/persistent_volume_tests.cpp > > Lines 541-542 (patched) > > > > > > Let's capture this message and test its content to make sure proper > > operation

Re: Review Request 66220: Added test for `GROW_VOLUME` and `SHRINK_VOLUME` operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66220/#review201235 --- Please consider unreplied comments as "will do".

Re: Review Request 66220: Added test for `GROW_VOLUME` and `SHRINK_VOLUME` operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66220/#review201180 --- src/tests/persistent_volume_tests.cpp Lines 453 (patched)

Re: Review Request 66220: Added test for `GROW_VOLUME` and `SHRINK_VOLUME` operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66220/#review201109 --- src/tests/persistent_volume_tests.cpp Lines 455-459 (patched)

Re: Review Request 66220: Added test for `GROW_VOLUME` and `SHRINK_VOLUME` operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66220/ --- (Updated April 11, 2018, 2:19 p.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 66220: Added test for `GROW_VOLUME` and `SHRINK_VOLUME` operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66220/ --- (Updated March 28, 2018, 11:29 a.m.) Review request for mesos, Chun-Hung

Re: Review Request 66220: Added test for `GROW_VOLUME` and `SHRINK_VOLUME` operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66220/#review199788 --- FAIL: Some of the unit tests failed. Please check the relevant