> On April 15, 2018, 5:39 p.m., Chun-Hung Hsiao wrote: > > src/tests/persistent_volume_tests.cpp > > Lines 455-459 (patched) > > <https://reviews.apache.org/r/66220/diff/4/?file=1996762#file1996762line455> > > > > Or alternatively, we can do the following: > > ``` > > class PersistentVolumeResizeTest : public PersistentVolumeTest {}; > > > > INSTANTIATE_TEST_CASE_P( > > DiskResource, /* Not sure if the same name can be used twice */ > > PersistentVolumeResizeTest, > > ::testing::Values( > > PersistentVolumeSourceType::NONE, > > PersistentVolumeSourceType::PATH)); > > > > TEST_P(PersistentVolumeResizeTest, GrowAndShrink) > > { > > ... > > } > > ``` > > And remove the conditional return.
I feel keeping current form is easier to reason, and the condition upon `MOUNT` is reduced to only one test case. > On April 15, 2018, 5:39 p.m., Chun-Hung Hsiao wrote: > > src/tests/persistent_volume_tests.cpp > > Lines 650-655 (patched) > > <https://reviews.apache.org/r/66220/diff/4/?file=1996762#file1996762line650> > > > > Since the test checks if the subsequent offer contains the shrunk > > volume, there is no need to check the internal `ApplyOperationMessage`. See comments above: this is used to eliminate race condition between master and allocator. - Zhitao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66220/#review201180 ----------------------------------------------------------- On April 11, 2018, 2:19 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66220/ > ----------------------------------------------------------- > > (Updated April 11, 2018, 2:19 p.m.) > > > Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Greg Mann. > > > Bugs: MESOS-4965 > https://issues.apache.org/jira/browse/MESOS-4965 > > > Repository: mesos > > > Description > ------- > > Added test for `GROW_VOLUME` and `SHRINK_VOLUME` operations. > > > Diffs > ----- > > src/tests/persistent_volume_tests.cpp > 4edf781711d9efdb994114aeb6289b6af750b87a > > > Diff: https://reviews.apache.org/r/66220/diff/4/ > > > Testing > ------- > > > Thanks, > > Zhitao Li > >
