Re: Review Request 66461: Added an evolve function for `v1::scheduler::Response`.

2018-04-20 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66461/ --- (Updated April 20, 2018, 3:47 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 66461: Added an evolve function for `v1::scheduler::Response`.

2018-04-10 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66461/#review200831 --- Ship it! Ship It! - Greg Mann On April 7, 2018, 12:16 a.m.,

Re: Review Request 66461: Added an evolve function for `v1::scheduler::Response`.

2018-04-06 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66461/ --- (Updated April 6, 2018, 5:16 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 66461: Added an evolve function for `v1::scheduler::Response`.

2018-04-06 Thread Gaston Kleiman
> On April 6, 2018, 2:01 p.m., Greg Mann wrote: > > src/internal/evolve.hpp > > Lines 120 (patched) > > > > > > Is the `mesos::` necessary in the type of the response argument here? > > Ditto in the implementation.

Re: Review Request 66461: Added an evolve function for `v1::scheduler::Response`.

2018-04-06 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66461/#review200669 --- src/internal/evolve.hpp Lines 120 (patched)