Re: Review Request 67136: Added a function to get rlimits.

2018-11-24 Thread Benjamin Bannier
> On Nov. 24, 2018, 2:17 vorm., Till Toenshoff wrote: > > Thanks for adding this Benjamin - also thanks James for reviewing! > > Till Toenshoff wrote: > Just realized that we should consider moving this into stout, no? That makes sense. We should then make this function independent of

Re: Review Request 67136: Added a function to get rlimits.

2018-11-23 Thread Till Toenshoff via Review Board
> On Nov. 24, 2018, 1:17 a.m., Till Toenshoff wrote: > > Thanks for adding this Benjamin - also thanks James for reviewing! Just realized that we should consider moving this into stout, no? - Till --- This is an automatically generated

Re: Review Request 67136: Added a function to get rlimits.

2018-11-23 Thread Till Toenshoff via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67136/#review210838 --- Fix it, then Ship it! Thanks for adding this Benjamin - also

Re: Review Request 67136: Added a function to get rlimits.

2018-05-21 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67136/#review203486 --- Patch looks great! Reviews applied: [67136] Passed command:

Re: Review Request 67136: Added a function to get rlimits.

2018-05-18 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67136/#review203416 --- PASS: Mesos patch 67136 was successfully built and tested.

Re: Review Request 67136: Added a function to get rlimits.

2018-05-18 Thread Benjamin Bannier
> On May 17, 2018, 11:07 p.m., James Peach wrote: > > src/posix/rlimits.cpp > > Lines 147 (patched) > > > > > > Use `ErrnoError` (also in the rest of the file if you feel like it). Done, also snuck in a fix for the

Re: Review Request 67136: Added a function to get rlimits.

2018-05-18 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67136/ --- (Updated May 18, 2018, 2:36 p.m.) Review request for mesos, Jie Yu and James

Re: Review Request 67136: Added a function to get rlimits.

2018-05-17 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67136/#review203380 --- PASS: Mesos patch 67136 was successfully built and tested.

Re: Review Request 67136: Added a function to get rlimits.

2018-05-17 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67136/#review203373 --- Fix it, then Ship it! src/posix/rlimits.cpp Lines 147