Re: Review Request 67590: Added a dedicated benchmark for overlapping range resources.

2018-06-29 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67590/#review205597 --- Fix it, then Ship it! Thanks! Will get this committed shortly.

Re: Review Request 67590: Added a dedicated benchmark for overlapping range resources.

2018-06-29 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67590/#review205565 --- Patch looks great! Reviews applied: [67590] Passed command:

Re: Review Request 67590: Added a dedicated benchmark for overlapping range resources.

2018-06-28 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67590/#review205552 --- PASS: Mesos patch 67590 was successfully built and tested.

Re: Review Request 67590: Added a dedicated benchmark for overlapping range resources.

2018-06-28 Thread Meng Zhu
> On June 28, 2018, 2:04 p.m., Benjamin Mahler wrote: > > Looks pretty good! The only thing that feels a little off is the size > > parameterization. It currently represents the number of ranges, but I > > imagine other benchmarks might not want to use that as the "size" (vs the > > overall

Re: Review Request 67590: Added a dedicated benchmark for overlapping range resources.

2018-06-28 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67590/ --- (Updated June 28, 2018, 5:38 p.m.) Review request for mesos and Benjamin

Re: Review Request 67590: Added a dedicated benchmark for overlapping range resources.

2018-06-28 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67590/#review205531 --- PASS: Mesos patch 67590 was successfully built and tested.

Re: Review Request 67590: Added a dedicated benchmark for overlapping range resources.

2018-06-28 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67590/#review205530 --- Patch looks great! Reviews applied: [67590] Passed command:

Re: Review Request 67590: Added a dedicated benchmark for overlapping range resources.

2018-06-28 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67590/#review205529 --- Fix it, then Ship it! Looks pretty good! The only thing that

Re: Review Request 67590: Added a dedicated benchmark for overlapping range resources.

2018-06-28 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67590/ --- (Updated June 28, 2018, 12:34 p.m.) Review request for mesos and Benjamin

Re: Review Request 67590: Added a dedicated benchmark for overlapping range resources.

2018-06-28 Thread Meng Zhu
> On June 27, 2018, 6:29 p.m., Benjamin Mahler wrote: > > Great to see this! > > > > Can you update the testing done to say whether this was measured with an > > optimized build? If not, can you add the optimized build measurements? Updated numbers with optimized build > On June 27, 2018,