Re: Review Request 68346: Fixed a backoff overflow bug in scheduler authentication retry logic.

2018-08-16 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68346/#review207435 --- Ship it! Ship It! - Benjamin Mahler On Aug. 16, 2018, 9:03

Re: Review Request 68346: Fixed a backoff overflow bug in scheduler authentication retry logic.

2018-08-16 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68346/ --- (Updated Aug. 16, 2018, 2:03 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 68346: Fixed a backoff overflow bug in scheduler authentication retry logic.

2018-08-16 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68346/ --- (Updated Aug. 16, 2018, 1:46 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 68346: Fixed a backoff overflow bug in scheduler authentication retry logic.

2018-08-16 Thread Meng Zhu
> On Aug. 16, 2018, 12:24 p.m., Benjamin Mahler wrote: > > src/sched/flags.hpp > > Lines 122-125 (original), 122-125 (patched) > > > > > > Either in this review or the next one, we can rename to min and use a > >

Re: Review Request 68346: Fixed a backoff overflow bug in scheduler authentication retry logic.

2018-08-16 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68346/#review207424 --- Looks good! Just an issue in the future.after, as well as the

Re: Review Request 68346: Fixed a backoff overflow bug in scheduler authentication retry logic.

2018-08-15 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68346/ --- (Updated Aug. 15, 2018, 5:11 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 68346: Fixed a backoff overflow bug in scheduler authentication retry logic.

2018-08-15 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68346/ --- (Updated Aug. 14, 2018, 11:10 p.m.) Review request for mesos, Benjamin Mahler