Re: Review Request 68991: Added a test `FsTest.Lsof`.

2018-11-07 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68991/#review210406 --- Ship it! Ship It! - Gilbert Song On Oct. 18, 2018, 11:58

Re: Review Request 68991: Added a test `FsTest.Lsof`.

2018-10-19 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68991/#review209787 --- Ship it! Ship It! - James Peach On Oct. 19, 2018, 6:58

Re: Review Request 68991: Added a test `FsTest.Lsof`.

2018-10-19 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68991/ --- (Updated Oct. 19, 2018, 2:58 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 68991: Added a test `FsTest.Lsof`.

2018-10-17 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68991/#review209700 --- 3rdparty/stout/tests/os/filesystem_tests.cpp Lines 833 (patched)

Re: Review Request 68991: Added a test `FsTest.Lsof`.

2018-10-17 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68991/ --- (Updated Oct. 17, 2018, 2:41 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 68991: Added a test `FsTest.Lsof`.

2018-10-17 Thread Qian Zhang
> On Oct. 13, 2018, 1:40 a.m., James Peach wrote: > > 3rdparty/stout/tests/os/filesystem_tests.cpp > > Lines 830 (patched) > > > > > > Maybe also add: > > ``` > > EXPECT_FALSE(std::find(fds->begin(),

Re: Review Request 68991: Added a test `FsTest.Lsof`.

2018-10-16 Thread James Peach
> On Oct. 12, 2018, 5:40 p.m., James Peach wrote: > > 3rdparty/stout/tests/os/filesystem_tests.cpp > > Lines 830 (patched) > > > > > > Maybe also add: > > ``` > > EXPECT_FALSE(std::find(fds->begin(),

Re: Review Request 68991: Added a test `FsTest.Lsof`.

2018-10-14 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68991/ --- (Updated Oct. 14, 2018, 9:35 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 68991: Added a test `FsTest.Lsof`.

2018-10-14 Thread Qian Zhang
> On Oct. 13, 2018, 1:40 a.m., James Peach wrote: > > 3rdparty/stout/tests/os/filesystem_tests.cpp > > Lines 830 (patched) > > > > > > Maybe also add: > > ``` > > EXPECT_FALSE(std::find(fds->begin(),

Re: Review Request 68991: Added a test `FsTest.Lsof`.

2018-10-12 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68991/#review209492 --- Fix it, then Ship it!