Re: Review Request 69032: Optimized resources filter operation.

2018-10-19 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69032/#review209782 --- Patch looks great! Reviews applied: [69032] Passed command:

Re: Review Request 69032: Optimized resources filter operation.

2018-10-18 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69032/#review209773 --- PASS: Mesos patch 69032 was successfully built and tested.

Re: Review Request 69032: Optimized resources filter operation.

2018-10-18 Thread Meng Zhu
> On Oct. 16, 2018, 5:24 p.m., Benjamin Mahler wrote: > > Can you also post the filter benchmark results? > > > > https://github.com/apache/mesos/blob/1.7.0/src/tests/resources_tests.cpp#L3865-L3920 Done. > On Oct. 16, 2018, 5:24 p.m., Benjamin Mahler wrote: > > src/common/resources.cpp > >

Re: Review Request 69032: Optimized resources filter operation.

2018-10-18 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69032/ --- (Updated Oct. 18, 2018, 9:22 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 69032: Optimized resources filter operation.

2018-10-16 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69032/#review209670 --- PASS: Mesos patch 69032 was successfully built and tested.

Re: Review Request 69032: Optimized resources filter operation.

2018-10-16 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69032/#review209669 --- Ship it! Can you also post the filter benchmark results?