Re: Review Request 69286: Allowed creating non-existing host paths for Mesos Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69286/#review213070 --- Ship it! Ship It! - Gilbert Song On Feb. 21, 2019, 5:43

Re: Review Request 69286: Allowed creating non-existing host paths for Mesos Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69286/ --- (Updated Feb. 22, 2019, 1:43 a.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 69286: Allowed creating non-existing host paths for Mesos Containerizer.

> On Feb. 21, 2019, 11:58 p.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/isolators/volume/host_path.cpp > > Lines 165-167 (original), 181-183 (patched) > > > > > > Sorry, I was wrong. Would you mind

Re: Review Request 69286: Allowed creating non-existing host paths for Mesos Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69286/#review213061 --- Fix it, then Ship it!

Re: Review Request 69286: Allowed creating non-existing host paths for Mesos Containerizer.

> On Feb. 21, 2019, 8:06 p.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/isolators/volume/host_path.hpp > > Lines 23 (patched) > > > > > > nits: > > > > newline above (usually we do that if the

Re: Review Request 69286: Allowed creating non-existing host paths for Mesos Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69286/ --- (Updated Feb. 21, 2019, 11:34 p.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 69286: Allowed creating non-existing host paths for Mesos Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69286/#review213043 --- Fix it, then Ship it! The patch LGTM. Thanks for working on

Re: Review Request 69286: Allowed creating non-existing host paths for Mesos Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69286/ --- (Updated Feb. 11, 2019, 11:12 p.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 69286: Allowed creating non-existing host paths for Mesos Containerizer.

> On Nov. 8, 2018, 6:33 a.m., Gilbert Song wrote: > > Hi, @gilbert. I updated the patch a bit differently than you originally requested by creating a `PathValidator` that encapsulate the validation logic instead. Please check if this revision rings a bell to you. > On Nov. 8, 2018, 6:33

Re: Review Request 69286: Allowed creating non-existing host paths for Mesos Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69286/#review210388 --- src/slave/containerizer/mesos/isolators/volume/host_path.hpp