----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69286/#review210388 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/volume/host_path.hpp Lines 46 (patched) <https://reviews.apache.org/r/69286/#comment295052> s/hostPathWhitelist/forceCreatedHostPaths/g? src/slave/containerizer/mesos/isolators/volume/host_path.cpp Lines 56-57 (patched) <https://reviews.apache.org/r/69286/#comment295053> do we still need them if we remove the volume namespace? src/slave/containerizer/mesos/isolators/volume/host_path.cpp Lines 86 (patched) <https://reviews.apache.org/r/69286/#comment295054> I would move the parse() to create() src/slave/containerizer/mesos/isolators/volume/utils.cpp Lines 31 (patched) <https://reviews.apache.org/r/69286/#comment295057> probably we do not need this method? src/slave/flags.cpp Lines 657 (patched) <https://reviews.apache.org/r/69286/#comment295050> if directories do not exist src/slave/flags.cpp Lines 658-660 (patched) <https://reviews.apache.org/r/69286/#comment295051> Remove these lines? - Gilbert Song On Nov. 7, 2018, 2:03 p.m., Jason Lai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69286/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2018, 2:03 p.m.) > > > Review request for mesos, Chun-Hung Hsiao, Eric Chung, Gilbert Song, Jie Yu, > and James Peach. > > > Bugs: MESOS-9009 > https://issues.apache.org/jira/browse/MESOS-9009 > > > Repository: mesos > > > Description > ------- > > Added a new agent flag `--host_path_volume_force_creation` for > the `volume/host_path` isolator. The flag takes a colon-separated > whitelist of paths, under which non-existing host paths are allowed to > be created. > > If the flag is not specified, the isolator behaves in the original way > of prohibiting all non-existing host paths from being created. > > > Diffs > ----- > > src/CMakeLists.txt 732368293049b7d9d6f62057344d433637ad44e8 > src/Makefile.am c17eae4ff1d019d515f67d81821e933ecb5dc190 > src/slave/containerizer/mesos/isolators/volume/host_path.hpp > 4b509e91a056381ca90293d16a400ea4368234a3 > src/slave/containerizer/mesos/isolators/volume/host_path.cpp > 88ecf91d91e2bebd484a4ac94510a14b3500dbfb > src/slave/containerizer/mesos/isolators/volume/utils.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/volume/utils.cpp PRE-CREATION > src/slave/flags.hpp 29d8b7985ffde57da02b5fe0d3a524e98acc27c8 > src/slave/flags.cpp ccaf65029ec2d0e78041fc3992a0bf5ca0798686 > > > Diff: https://reviews.apache.org/r/69286/diff/1/ > > > Testing > ------- > > > Thanks, > > Jason Lai > >
