Re: Review Request 69544: Made non-root containers can access shared persistent volume.

2019-02-27 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69544/#review213275
---


Ship it!




Ship It!

- Gilbert Song


On Feb. 27, 2019, 6:47 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69544/
> ---
> 
> (Updated Feb. 27, 2019, 6:47 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Gilbert Song, Greg Mann, Ilya 
> Pronin, and Jie Yu.
> 
> 
> Bugs: MESOS-8813
> https://issues.apache.org/jira/browse/MESOS-8813
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Made non-root containers can access shared persistent volume.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 5e6b3540da9bd75ea4b73846d477652ff80237ad 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.hpp 
> 8f76944cd9058c0ba809443e32a3d8c8a26ac4a6 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
> 1e116b7856fbcbe5e830203a844760f91be64708 
>   src/slave/containerizer/mesos/isolators/filesystem/posix.hpp 
> deacc909a2d323671667cb646c019664bdb660e7 
>   src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 
> f91a2eeb835bb65a855eeb314d4c69e3b58fecae 
>   src/slave/containerizer/mesos/isolators/filesystem/windows.hpp 
> 2bf011d3e7b014a17f759851d755b161c897b131 
>   src/slave/containerizer/mesos/isolators/filesystem/windows.cpp 
> f169c380f803a2111b1612cee60250ee9a30ef2e 
>   src/slave/volume_gid_manager/volume_gid_manager.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/69544/diff/7/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 69544: Made non-root containers can access shared persistent volume.

2019-02-27 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69544/
---

(Updated Feb. 27, 2019, 10:47 p.m.)


Review request for mesos, Andrei Budnik, Gilbert Song, Greg Mann, Ilya Pronin, 
and Jie Yu.


Changes
---

Passed volume type when calling volume gid manager's `allocate` method and 
skipped the resources from resource provider.


Bugs: MESOS-8813
https://issues.apache.org/jira/browse/MESOS-8813


Repository: mesos


Description
---

Made non-root containers can access shared persistent volume.


Diffs (updated)
-

  src/slave/containerizer/mesos/containerizer.cpp 
5e6b3540da9bd75ea4b73846d477652ff80237ad 
  src/slave/containerizer/mesos/isolators/filesystem/linux.hpp 
8f76944cd9058c0ba809443e32a3d8c8a26ac4a6 
  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
1e116b7856fbcbe5e830203a844760f91be64708 
  src/slave/containerizer/mesos/isolators/filesystem/posix.hpp 
deacc909a2d323671667cb646c019664bdb660e7 
  src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 
f91a2eeb835bb65a855eeb314d4c69e3b58fecae 
  src/slave/containerizer/mesos/isolators/filesystem/windows.hpp 
2bf011d3e7b014a17f759851d755b161c897b131 
  src/slave/containerizer/mesos/isolators/filesystem/windows.cpp 
f169c380f803a2111b1612cee60250ee9a30ef2e 
  src/slave/volume_gid_manager/volume_gid_manager.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/69544/diff/7/

Changes: https://reviews.apache.org/r/69544/diff/6-7/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 69544: Made non-root containers can access shared persistent volume.

2019-02-25 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69544/
---

(Updated Feb. 26, 2019, 11:01 a.m.)


Review request for mesos, Andrei Budnik, Gilbert Song, Greg Mann, Ilya Pronin, 
and Jie Yu.


Changes
---

Minor changes.


Bugs: MESOS-8813
https://issues.apache.org/jira/browse/MESOS-8813


Repository: mesos


Description
---

Made non-root containers can access shared persistent volume.


Diffs (updated)
-

  src/slave/containerizer/mesos/containerizer.cpp 
5e6b3540da9bd75ea4b73846d477652ff80237ad 
  src/slave/containerizer/mesos/isolators/filesystem/linux.hpp 
8f76944cd9058c0ba809443e32a3d8c8a26ac4a6 
  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
1e116b7856fbcbe5e830203a844760f91be64708 
  src/slave/containerizer/mesos/isolators/filesystem/posix.hpp 
deacc909a2d323671667cb646c019664bdb660e7 
  src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 
f91a2eeb835bb65a855eeb314d4c69e3b58fecae 
  src/slave/containerizer/mesos/isolators/filesystem/windows.hpp 
2bf011d3e7b014a17f759851d755b161c897b131 
  src/slave/containerizer/mesos/isolators/filesystem/windows.cpp 
f169c380f803a2111b1612cee60250ee9a30ef2e 
  src/slave/volume_gid_manager/volume_gid_manager.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/69544/diff/6/

Changes: https://reviews.apache.org/r/69544/diff/5-6/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 69544: Made non-root containers can access shared persistent volume.

2019-02-25 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69544/#review213182
---


Ship it!




Ship It!

- Gilbert Song


On Jan. 6, 2019, 4:49 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69544/
> ---
> 
> (Updated Jan. 6, 2019, 4:49 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Gilbert Song, Greg Mann, Ilya 
> Pronin, and Jie Yu.
> 
> 
> Bugs: MESOS-8813
> https://issues.apache.org/jira/browse/MESOS-8813
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Made non-root containers can access shared persistent volume.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.cpp 
> a5cf2da55c046c5c45e0c2ca3400f64de12de62b 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.hpp 
> 8f76944cd9058c0ba809443e32a3d8c8a26ac4a6 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
> 2a9ea448d7f963f86e8b2909d83e82b498e4104c 
>   src/slave/containerizer/mesos/isolators/filesystem/posix.hpp 
> deacc909a2d323671667cb646c019664bdb660e7 
>   src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 
> f91a2eeb835bb65a855eeb314d4c69e3b58fecae 
>   src/slave/containerizer/mesos/isolators/filesystem/windows.hpp 
> 2bf011d3e7b014a17f759851d755b161c897b131 
>   src/slave/containerizer/mesos/isolators/filesystem/windows.cpp 
> f169c380f803a2111b1612cee60250ee9a30ef2e 
>   src/slave/volume_gid_manager/volume_gid_manager.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/69544/diff/5/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 69544: Made non-root containers can access shared persistent volume.

2019-02-25 Thread Qian Zhang 


> On Feb. 25, 2019, 11:43 a.m., Gilbert Song wrote:
> > src/slave/containerizer/mesos/isolators/filesystem/linux.cpp
> > Lines 889 (patched)
> > 
> >
> > we called update in multiple places in slave.cpp, is it true that for 
> > PV, the update would only be invoked once?
> > 
> > Also, does it hurt if our volumeGidManager invokes allocate a 
> > particular `path` multiple times?

> we called update in multiple places in slave.cpp, is it true that for PV, the 
> update would only be invoked once?

The `update` method will be called twice:
1. Called by `prepare` method.
2. Called when the executor registers agent.

For command executor, volume gid manager will be called in #1 and #2 is just a 
no-op (because there is no resource changes, i.e., nothing to update). For 
default executor, volume gid manager will be called in #2 and #1 is just a 
no-op (because default executor itself has no PV specified but the task's PV 
resources will be merged to it in #2).

> Also, does it hurt if our volumeGidManager invokes allocate a particular path 
> multiple times?

It will not hurt because in that case volume gid manager will find the volume 
path has been already allocated with a gid and just return that gid to caller.


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69544/#review213132
---


On Jan. 7, 2019, 8:49 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69544/
> ---
> 
> (Updated Jan. 7, 2019, 8:49 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Gilbert Song, Greg Mann, Ilya 
> Pronin, and Jie Yu.
> 
> 
> Bugs: MESOS-8813
> https://issues.apache.org/jira/browse/MESOS-8813
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Made non-root containers can access shared persistent volume.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.cpp 
> a5cf2da55c046c5c45e0c2ca3400f64de12de62b 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.hpp 
> 8f76944cd9058c0ba809443e32a3d8c8a26ac4a6 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
> 2a9ea448d7f963f86e8b2909d83e82b498e4104c 
>   src/slave/containerizer/mesos/isolators/filesystem/posix.hpp 
> deacc909a2d323671667cb646c019664bdb660e7 
>   src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 
> f91a2eeb835bb65a855eeb314d4c69e3b58fecae 
>   src/slave/containerizer/mesos/isolators/filesystem/windows.hpp 
> 2bf011d3e7b014a17f759851d755b161c897b131 
>   src/slave/containerizer/mesos/isolators/filesystem/windows.cpp 
> f169c380f803a2111b1612cee60250ee9a30ef2e 
>   src/slave/volume_gid_manager/volume_gid_manager.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/69544/diff/5/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 69544: Made non-root containers can access shared persistent volume.

2019-02-24 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69544/#review213132
---




src/slave/containerizer/mesos/isolators/filesystem/linux.cpp
Lines 889 (patched)


we called update in multiple places in slave.cpp, is it true that for PV, 
the update would only be invoked once?

Also, does it hurt if our volumeGidManager invokes allocate a particular 
`path` multiple times?


- Gilbert Song


On Jan. 6, 2019, 4:49 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69544/
> ---
> 
> (Updated Jan. 6, 2019, 4:49 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Gilbert Song, Greg Mann, Ilya 
> Pronin, and Jie Yu.
> 
> 
> Bugs: MESOS-8813
> https://issues.apache.org/jira/browse/MESOS-8813
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Made non-root containers can access shared persistent volume.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.cpp 
> a5cf2da55c046c5c45e0c2ca3400f64de12de62b 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.hpp 
> 8f76944cd9058c0ba809443e32a3d8c8a26ac4a6 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
> 2a9ea448d7f963f86e8b2909d83e82b498e4104c 
>   src/slave/containerizer/mesos/isolators/filesystem/posix.hpp 
> deacc909a2d323671667cb646c019664bdb660e7 
>   src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 
> f91a2eeb835bb65a855eeb314d4c69e3b58fecae 
>   src/slave/containerizer/mesos/isolators/filesystem/windows.hpp 
> 2bf011d3e7b014a17f759851d755b161c897b131 
>   src/slave/containerizer/mesos/isolators/filesystem/windows.cpp 
> f169c380f803a2111b1612cee60250ee9a30ef2e 
>   src/slave/volume_gid_manager/volume_gid_manager.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/69544/diff/5/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 69544: Made non-root containers can access shared persistent volume.

2019-01-06 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69544/
---

(Updated Jan. 7, 2019, 8:49 a.m.)


Review request for mesos, Andrei Budnik, Gilbert Song, Greg Mann, Ilya Pronin, 
and Jie Yu.


Changes
---

Rebased.


Bugs: MESOS-8813
https://issues.apache.org/jira/browse/MESOS-8813


Repository: mesos


Description
---

Made non-root containers can access shared persistent volume.


Diffs (updated)
-

  src/slave/containerizer/mesos/containerizer.cpp 
a5cf2da55c046c5c45e0c2ca3400f64de12de62b 
  src/slave/containerizer/mesos/isolators/filesystem/linux.hpp 
8f76944cd9058c0ba809443e32a3d8c8a26ac4a6 
  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
2a9ea448d7f963f86e8b2909d83e82b498e4104c 
  src/slave/containerizer/mesos/isolators/filesystem/posix.hpp 
deacc909a2d323671667cb646c019664bdb660e7 
  src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 
f91a2eeb835bb65a855eeb314d4c69e3b58fecae 
  src/slave/containerizer/mesos/isolators/filesystem/windows.hpp 
2bf011d3e7b014a17f759851d755b161c897b131 
  src/slave/containerizer/mesos/isolators/filesystem/windows.cpp 
f169c380f803a2111b1612cee60250ee9a30ef2e 
  src/slave/volume_gid_manager/volume_gid_manager.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/69544/diff/5/

Changes: https://reviews.apache.org/r/69544/diff/4-5/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 69544: Made non-root containers can access shared persistent volume.

2018-12-20 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69544/
---

(Updated Dec. 21, 2018, 11 a.m.)


Review request for mesos, Andrei Budnik, Gilbert Song, Greg Mann, Ilya Pronin, 
and Jie Yu.


Changes
---

Added more logs.


Bugs: MESOS-8813
https://issues.apache.org/jira/browse/MESOS-8813


Repository: mesos


Description
---

Made non-root containers can access shared persistent volume.


Diffs (updated)
-

  src/slave/containerizer/mesos/containerizer.cpp 
a5cf2da55c046c5c45e0c2ca3400f64de12de62b 
  src/slave/containerizer/mesos/isolators/filesystem/linux.hpp 
8f76944cd9058c0ba809443e32a3d8c8a26ac4a6 
  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
2a9ea448d7f963f86e8b2909d83e82b498e4104c 
  src/slave/containerizer/mesos/isolators/filesystem/posix.hpp 
deacc909a2d323671667cb646c019664bdb660e7 
  src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 
f91a2eeb835bb65a855eeb314d4c69e3b58fecae 
  src/slave/containerizer/mesos/isolators/filesystem/windows.hpp 
2bf011d3e7b014a17f759851d755b161c897b131 
  src/slave/containerizer/mesos/isolators/filesystem/windows.cpp 
f169c380f803a2111b1612cee60250ee9a30ef2e 
  src/slave/containerizer/mesos/volume_gid_manager/volume_gid_manager.cpp 
PRE-CREATION 


Diff: https://reviews.apache.org/r/69544/diff/4/

Changes: https://reviews.apache.org/r/69544/diff/3-4/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 69544: Made non-root containers can access shared persistent volume.

2018-12-18 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69544/
---

(Updated Dec. 18, 2018, 4:08 p.m.)


Review request for mesos, Andrei Budnik, Gilbert Song, Greg Mann, Ilya Pronin, 
and Jie Yu.


Changes
---

Added more logs.


Bugs: MESOS-8813
https://issues.apache.org/jira/browse/MESOS-8813


Repository: mesos


Description
---

Made non-root containers can access shared persistent volume.


Diffs (updated)
-

  src/slave/containerizer/mesos/containerizer.cpp 
a5cf2da55c046c5c45e0c2ca3400f64de12de62b 
  src/slave/containerizer/mesos/isolators/filesystem/linux.hpp 
8f76944cd9058c0ba809443e32a3d8c8a26ac4a6 
  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
2a9ea448d7f963f86e8b2909d83e82b498e4104c 
  src/slave/containerizer/mesos/isolators/filesystem/posix.hpp 
deacc909a2d323671667cb646c019664bdb660e7 
  src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 
f91a2eeb835bb65a855eeb314d4c69e3b58fecae 
  src/slave/containerizer/mesos/isolators/filesystem/windows.hpp 
2bf011d3e7b014a17f759851d755b161c897b131 
  src/slave/containerizer/mesos/isolators/filesystem/windows.cpp 
f169c380f803a2111b1612cee60250ee9a30ef2e 
  src/slave/containerizer/mesos/volume_gid_manager/volume_gid_manager.cpp 
PRE-CREATION 


Diff: https://reviews.apache.org/r/69544/diff/3/

Changes: https://reviews.apache.org/r/69544/diff/2-3/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 69544: Made non-root containers can access shared persistent volume.

2018-12-12 Thread Andrei Budnik 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69544/#review211231
---


Ship it!




Ship It!

- Andrei Budnik


On Dec. 11, 2018, 1:17 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69544/
> ---
> 
> (Updated Dec. 11, 2018, 1:17 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Gilbert Song, Greg Mann, Ilya 
> Pronin, and Jie Yu.
> 
> 
> Bugs: MESOS-8813
> https://issues.apache.org/jira/browse/MESOS-8813
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Made non-root containers can access shared persistent volume.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.cpp 
> a5cf2da55c046c5c45e0c2ca3400f64de12de62b 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.hpp 
> 8f76944cd9058c0ba809443e32a3d8c8a26ac4a6 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
> 2a9ea448d7f963f86e8b2909d83e82b498e4104c 
>   src/slave/containerizer/mesos/isolators/filesystem/posix.hpp 
> deacc909a2d323671667cb646c019664bdb660e7 
>   src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 
> f91a2eeb835bb65a855eeb314d4c69e3b58fecae 
>   src/slave/containerizer/mesos/isolators/filesystem/windows.hpp 
> 2bf011d3e7b014a17f759851d755b161c897b131 
>   src/slave/containerizer/mesos/isolators/filesystem/windows.cpp 
> f169c380f803a2111b1612cee60250ee9a30ef2e 
>   src/slave/containerizer/mesos/volume_gid_manager/volume_gid_manager.cpp 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/69544/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 69544: Made non-root containers can access shared persistent volume.

2018-12-10 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69544/#review211180
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['69342', '69541', '69542', '69543', '69478', '69479', 
'69544']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2692/mesos-review-69544

Relevant logs:

- 
[mesos-tests-cmake.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2692/mesos-review-69544/logs/mesos-tests-cmake.log):

```
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3501):
 warning C4996: 'sprintf': This function or variable may be unsafe. Consider 
using sprintf_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3479):
 warning C4101: 'addrstr': unreferenced local variable 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\recordio.c(170):
 warning C4267: '=': conversion from 'size_t' to 'int32_t', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\mt_adaptor.c(496):
 warning C4244: '=': conversion from 'time_t' to 'int32_t', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(256):
 warning C4090: 'function': different 'const' qualifiers 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(166):
 warning C4716: 'pthread_cond_broadcast': must return a value 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(205):
 warning C4716: 'pthread_cond_wait': must return a value 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(124):
 warning C4996: 'fopen': This function or variable may be unsafe. Consider 
using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See 
online help for details. 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(128):
 warning C4267: 'initializing': conversion from 'size_t' to 'int', possible 
loss of data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(279):
 warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(301):
 warning C4267: 'initializing': conversion from 'size_t' to 'int', possible 
loss of data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(368):
 warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(372):
 warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(512):

Re: Review Request 69544: Made non-root containers can access shared persistent volume.

2018-12-10 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69544/
---

(Updated Dec. 11, 2018, 9:17 a.m.)


Review request for mesos, Andrei Budnik, Gilbert Song, Greg Mann, Ilya Pronin, 
and Jie Yu.


Changes
---

Fixed the compilation issue on Windows.


Bugs: MESOS-8813
https://issues.apache.org/jira/browse/MESOS-8813


Repository: mesos


Description
---

Made non-root containers can access shared persistent volume.


Diffs (updated)
-

  src/slave/containerizer/mesos/containerizer.cpp 
a5cf2da55c046c5c45e0c2ca3400f64de12de62b 
  src/slave/containerizer/mesos/isolators/filesystem/linux.hpp 
8f76944cd9058c0ba809443e32a3d8c8a26ac4a6 
  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
2a9ea448d7f963f86e8b2909d83e82b498e4104c 
  src/slave/containerizer/mesos/isolators/filesystem/posix.hpp 
deacc909a2d323671667cb646c019664bdb660e7 
  src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 
f91a2eeb835bb65a855eeb314d4c69e3b58fecae 
  src/slave/containerizer/mesos/isolators/filesystem/windows.hpp 
2bf011d3e7b014a17f759851d755b161c897b131 
  src/slave/containerizer/mesos/isolators/filesystem/windows.cpp 
f169c380f803a2111b1612cee60250ee9a30ef2e 
  src/slave/containerizer/mesos/volume_gid_manager/volume_gid_manager.cpp 
PRE-CREATION 


Diff: https://reviews.apache.org/r/69544/diff/2/

Changes: https://reviews.apache.org/r/69544/diff/1-2/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 69544: Made non-root containers can access shared persistent volume.

2018-12-10 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69544/#review211162
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['69342', '69541', '69542', '69543', '69478', '69479', 
'69544']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2688/mesos-review-69544

Relevant logs:

- 
[mesos-tests-cmake.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2688/mesos-review-69544/logs/mesos-tests-cmake.log):

```
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3500):
 warning C4996: 'inet_ntoa': Use inet_ntop() or InetNtop() instead or define 
_WINSOCK_DEPRECATED_NO_WARNINGS to disable deprecated API warnings 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3501):
 warning C4996: 'sprintf': This function or variable may be unsafe. Consider 
using sprintf_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3479):
 warning C4101: 'addrstr': unreferenced local variable 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\recordio.c(170):
 warning C4267: '=': conversion from 'size_t' to 'int32_t', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\mt_adaptor.c(496):
 warning C4244: '=': conversion from 'time_t' to 'int32_t', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(256):
 warning C4090: 'function': different 'const' qualifiers 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(166):
 warning C4716: 'pthread_cond_broadcast': must return a value 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(205):
 warning C4716: 'pthread_cond_wait': must return a value 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(124):
 warning C4996: 'fopen': This function or variable may be unsafe. Consider 
using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See 
online help for details. 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(128):
 warning C4267: 'initializing': conversion from 'size_t' to 'int', possible 
loss of data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(279):
 warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(301):
 warning C4267: 'initializing': conversion from 'size_t' to 'int', possible 
loss of data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
 
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(368):
 warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]