Re: Review Request 69680: Have master acknowledge operation updates of completed frameworks.

2019-02-05 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69680/#review212565 --- PASS: Mesos patch 69680 was successfully built and tested.

Re: Review Request 69680: Have master acknowledge operation updates of completed frameworks.

2019-02-05 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69680/ --- (Updated Feb. 5, 2019, 6:02 p.m.) Review request for mesos, Gastón Kleiman and

Re: Review Request 69680: Have master acknowledge operation updates of completed frameworks.

2019-02-05 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69680/ --- (Updated Feb. 5, 2019, 5:40 p.m.) Review request for mesos, Gastón Kleiman and

Re: Review Request 69680: Have master acknowledge operation updates of completed frameworks.

2019-01-31 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69680/#review212486 --- Fix it, then Ship it! src/tests/master_tests.cpp Line 9331

Re: Review Request 69680: Have master acknowledge operation updates of completed frameworks.

2019-01-29 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69680/#review212413 --- PASS: Mesos patch 69680 was successfully built and tested.

Re: Review Request 69680: Have master acknowledge operation updates of completed frameworks.

2019-01-29 Thread Benjamin Bannier
> On Jan. 28, 2019, 9:37 p.m., Greg Mann wrote: > > src/tests/master_tests.cpp > > Lines 9469-9491 (patched) > > > > > > Can you use the mock RP's `operationDefault` method to accomplish this? > > > > > >

Re: Review Request 69680: Have master acknowledge operation updates of completed frameworks.

2019-01-29 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69680/ --- (Updated Jan. 29, 2019, 2:21 p.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 69680: Have master acknowledge operation updates of completed frameworks.

2019-01-28 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69680/#review212392 --- Fix it, then Ship it! src/master/master.cpp Line 8623

Re: Review Request 69680: Have master acknowledge operation updates of completed frameworks.

2019-01-09 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69680/#review211791 --- PASS: Mesos patch 69680 was successfully built and tested.