Re: Review Request 69890: Added test for per-framework, per-role minimal allocatable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69890/#review212847 --- PASS: Mesos patch 69890 was successfully built and tested.

Re: Review Request 69890: Added test for per-framework, per-role minimal allocatable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69890/ --- (Updated Feb. 14, 2019, 9:48 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 69890: Added test for per-framework, per-role minimal allocatable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69890/#review212842 --- Ship it! Ship It! - Benjamin Mahler On Feb. 14, 2019, 8:48

Re: Review Request 69890: Added test for per-framework, per-role minimal allocatable resources.

> On Feb. 8, 2019, 9:47 p.m., Benjamin Mahler wrote: > > src/tests/hierarchical_allocator_tests.cpp > > Lines 2357-2374 (patched) > > > > > > Both "empty set" and "NullResourcesAllocatable" don't seem to > >

Re: Review Request 69890: Added test for per-framework, per-role minimal allocatable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69890/#review212820 --- Patch looks great! Reviews applied: [69900, 69902, 69818, 69862,

Re: Review Request 69890: Added test for per-framework, per-role minimal allocatable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69890/#review212811 --- PASS: Mesos patch 69890 was successfully built and tested.

Re: Review Request 69890: Added test for per-framework, per-role minimal allocatable resources.

> On Feb. 8, 2019, 9:47 p.m., Benjamin Mahler wrote: > > src/tests/hierarchical_allocator_tests.cpp > > Lines 2357-2374 (patched) > > > > > > Both "empty set" and "NullResourcesAllocatable" don't seem to > >

Re: Review Request 69890: Added test for per-framework, per-role minimal allocatable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69890/ --- (Updated Feb. 13, 2019, 11:31 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 69890: Added test for per-framework, per-role minimal allocatable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69890/#review212785 --- Patch looks great! Reviews applied: [69900, 69902, 69818, 69862,

Re: Review Request 69890: Added test for per-framework, per-role minimal allocatable resources.

> On Feb. 8, 2019, 8:47 p.m., Benjamin Mahler wrote: > > src/tests/hierarchical_allocator_tests.cpp > > Lines 2357-2374 (patched) > > > > > > Both "empty set" and "NullResourcesAllocatable" don't seem to > >

Re: Review Request 69890: Added test for per-framework, per-role minimal allocatable resources.

> On Feb. 8, 2019, 9:47 p.m., Benjamin Mahler wrote: > > src/tests/hierarchical_allocator_tests.cpp > > Lines 2357-2374 (patched) > > > > > > Both "empty set" and "NullResourcesAllocatable" don't seem to > >

Re: Review Request 69890: Added test for per-framework, per-role minimal allocatable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69890/#review212702 --- PASS: Mesos patch 69890 was successfully built and tested.

Re: Review Request 69890: Added test for per-framework, per-role minimal allocatable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69890/ --- (Updated Feb. 11, 2019, 4:46 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 69890: Added test for per-framework, per-role minimal allocatable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69890/#review212678 --- Fix it, then Ship it! Looks good, after leaving the comment

Re: Review Request 69890: Added test for per-framework, per-role minimal allocatable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69890/#review212666 --- FAIL: Failed to apply the dependent review: 69821. Failed

Re: Review Request 69890: Added test for per-framework, per-role minimal allocatable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69890/ --- (Updated Feb. 8, 2019, 12:32 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 69890: Added test for per-framework, per-role minimal allocatable resources.

> On Feb. 5, 2019, 8:03 p.m., Benjamin Mahler wrote: > > src/tests/hierarchical_allocator_tests.cpp > > Lines 2287 (patched) > > > > > > any reason not to stick to using "minimum" for these? ditto below > > >

Re: Review Request 69890: Added test for per-framework, per-role minimal allocatable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69890/#review212563 --- Looks good! Just some minor comments below

Re: Review Request 69890: Added test for per-framework, per-role minimal allocatable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69890/#review212541 --- PASS: Mesos patch 69890 was successfully built and tested.