Re: Review Request 71194: Add `disk/xfs` isolator support for ephemeral volumes.

2019-08-06 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71194/ --- (Updated Aug. 7, 2019, 2:59 a.m.) Review request for mesos, Xudong Ni, Gilbert

Re: Review Request 71194: Add `disk/xfs` isolator support for ephemeral volumes.

2019-08-06 Thread James Peach
> On Aug. 2, 2019, 11:03 p.m., Jiang Yan Xu wrote: > > src/slave/containerizer/mesos/isolators/xfs/disk.cpp > > Lines 342 (patched) > > > > > > Use `at()`? Yup, updating to use `at()` everywhere. > On Aug. 2,

Re: Review Request 71194: Add `disk/xfs` isolator support for ephemeral volumes.

2019-08-06 Thread Andrei Budnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71194/#review217103 --- Ship it! Ship It! - Andrei Budnik On Авг. 2, 2019, 2:27

Re: Review Request 71194: Add `disk/xfs` isolator support for ephemeral volumes.

2019-08-02 Thread Jiang Yan Xu
> On Aug. 2, 2019, 4:03 p.m., Jiang Yan Xu wrote: > > src/slave/containerizer/mesos/isolators/xfs/disk.cpp > > Lines 424 (patched) > > > > > > FWIW sandbox scanning predates the container run state, now it does > >

Re: Review Request 71194: Add `disk/xfs` isolator support for ephemeral volumes.

2019-08-02 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71194/#review217058 --- src/slave/containerizer/mesos/isolators/xfs/disk.cpp Lines 342

Re: Review Request 71194: Add `disk/xfs` isolator support for ephemeral volumes.

2019-08-01 Thread James Peach
> On Aug. 1, 2019, 2:15 p.m., Andrei Budnik wrote: > > src/slave/containerizer/mesos/isolators/xfs/disk.cpp > > Lines 335 (patched) > > > > > > According to this comment > >

Re: Review Request 71194: Add `disk/xfs` isolator support for ephemeral volumes.

2019-08-01 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71194/ --- (Updated Aug. 2, 2019, 2:27 a.m.) Review request for mesos, Xudong Ni, Gilbert

Re: Review Request 71194: Add `disk/xfs` isolator support for ephemeral volumes.

2019-08-01 Thread Andrei Budnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71194/#review217030 --- src/slave/containerizer/mesos/isolators/xfs/disk.cpp Lines 335