Re: Review Request 71241: Added a `distcheck` target to the cmake build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71241/#review217607 --- Bad patch! Reviews applied: [71240, 71241] Failed command:

Re: Review Request 71241: Added a `distcheck` target to the cmake build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71241/#review217580 --- Ship it! Ship It! - Till Toenshoff On Sept. 3, 2019, 2:51

Re: Review Request 71241: Added a `distcheck` target to the cmake build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71241/#review217554 --- Patch looks great! Reviews applied: [71240, 71241] Passed

Re: Review Request 71241: Added a `distcheck` target to the cmake build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71241/ --- (Updated Sept. 3, 2019, 4:51 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 71241: Added a `distcheck` target to the cmake build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71241/ --- (Updated Sept. 3, 2019, 3:52 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 71241: Added a `distcheck` target to the cmake build.

> On Sept. 3, 2019, 3:08 p.m., Benno Evers wrote: > > cmake/distcheck.sh > > Lines 25 (patched) > > > > > > I don't think we should unconditionally override the users environment > > like this in a support script -

Re: Review Request 71241: Added a `distcheck` target to the cmake build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71241/#review217542 --- cmake/distcheck.sh Lines 22 (patched)

Re: Review Request 71241: Added a `distcheck` target to the cmake build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71241/#review217107 --- Patch looks great! Reviews applied: [71240, 71241] Passed