Re: Review Request 72269: Added resource limits to the web UI.

2020-03-31 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72269/#review220161
---


Ship it!




Ship It!

- Qian Zhang


On April 1, 2020, 12:14 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72269/
> ---
> 
> (Updated April 1, 2020, 12:14 a.m.)
> 
> 
> Review request for mesos and Qian Zhang.
> 
> 
> Bugs: MESOS-10055
> https://issues.apache.org/jira/browse/MESOS-10055
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added resource limits to the web UI.
> 
> 
> Diffs
> -
> 
>   src/webui/app/agents/agent-executor.html 
> 7ec56c3bd039ee190c0f1c61ec8957001b52f1dc 
> 
> 
> Diff: https://reviews.apache.org/r/72269/diff/4/
> 
> 
> Testing
> ---
> 
> Viewed manually in a web browser.
> 
> 
> File Attachments
> 
> 
> UI Before Change
>   
> https://reviews.apache.org/media/uploaded/files/2020/03/31/555e2c58-70ef-4319-9c68-122f9842116f__Screen_Shot_2020-03-31_at_9.13.29_AM.png
> UI After Change
>   
> https://reviews.apache.org/media/uploaded/files/2020/03/31/5e6e0c6e-a501-496d-9572-504bbdb796aa__Screen_Shot_2020-03-31_at_9.13.10_AM.png
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 72269: Added resource limits to the web UI.

2020-03-31 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72269/#review220158
---



Patch looks great!

Reviews applied: [72269]

Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/jenkins/buildbot.sh

- Mesos Reviewbot


On March 31, 2020, 4:14 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72269/
> ---
> 
> (Updated March 31, 2020, 4:14 p.m.)
> 
> 
> Review request for mesos and Qian Zhang.
> 
> 
> Bugs: MESOS-10055
> https://issues.apache.org/jira/browse/MESOS-10055
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added resource limits to the web UI.
> 
> 
> Diffs
> -
> 
>   src/webui/app/agents/agent-executor.html 
> 7ec56c3bd039ee190c0f1c61ec8957001b52f1dc 
> 
> 
> Diff: https://reviews.apache.org/r/72269/diff/4/
> 
> 
> Testing
> ---
> 
> Viewed manually in a web browser.
> 
> 
> File Attachments
> 
> 
> UI Before Change
>   
> https://reviews.apache.org/media/uploaded/files/2020/03/31/555e2c58-70ef-4319-9c68-122f9842116f__Screen_Shot_2020-03-31_at_9.13.29_AM.png
> UI After Change
>   
> https://reviews.apache.org/media/uploaded/files/2020/03/31/5e6e0c6e-a501-496d-9572-504bbdb796aa__Screen_Shot_2020-03-31_at_9.13.10_AM.png
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 72269: Added resource limits to the web UI.

2020-03-31 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72269/
---

(Updated March 31, 2020, 4:14 p.m.)


Review request for mesos and Qian Zhang.


Bugs: MESOS-10055
https://issues.apache.org/jira/browse/MESOS-10055


Repository: mesos


Description
---

Added resource limits to the web UI.


Diffs
-

  src/webui/app/agents/agent-executor.html 
7ec56c3bd039ee190c0f1c61ec8957001b52f1dc 


Diff: https://reviews.apache.org/r/72269/diff/4/


Testing
---

Viewed manually in a web browser.


File Attachments (updated)


UI Before Change
  
https://reviews.apache.org/media/uploaded/files/2020/03/31/555e2c58-70ef-4319-9c68-122f9842116f__Screen_Shot_2020-03-31_at_9.13.29_AM.png
UI After Change
  
https://reviews.apache.org/media/uploaded/files/2020/03/31/5e6e0c6e-a501-496d-9572-504bbdb796aa__Screen_Shot_2020-03-31_at_9.13.10_AM.png


Thanks,

Greg Mann

Re: Review Request 72269: Added resource limits to the web UI.

2020-03-31 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72269/
---

(Updated March 31, 2020, 4:12 p.m.)


Review request for mesos and Qian Zhang.


Bugs: MESOS-10055
https://issues.apache.org/jira/browse/MESOS-10055


Repository: mesos


Description
---

Added resource limits to the web UI.


Diffs (updated)
-

  src/webui/app/agents/agent-executor.html 
7ec56c3bd039ee190c0f1c61ec8957001b52f1dc 


Diff: https://reviews.apache.org/r/72269/diff/4/

Changes: https://reviews.apache.org/r/72269/diff/3-4/


Testing
---

Viewed manually in a web browser.


Thanks,

Greg Mann

Re: Review Request 72269: Added resource limits to the web UI.

2020-03-31 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72269/#review220138
---



Patch looks great!

Reviews applied: [72269]

Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/jenkins/buildbot.sh

- Mesos Reviewbot


On March 31, 2020, 3:22 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72269/
> ---
> 
> (Updated March 31, 2020, 3:22 a.m.)
> 
> 
> Review request for mesos and Qian Zhang.
> 
> 
> Bugs: MESOS-10055
> https://issues.apache.org/jira/browse/MESOS-10055
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added resource limits to the web UI.
> 
> 
> Diffs
> -
> 
>   src/webui/app/agents/agent-executor.html 
> 7ec56c3bd039ee190c0f1c61ec8957001b52f1dc 
> 
> 
> Diff: https://reviews.apache.org/r/72269/diff/3/
> 
> 
> Testing
> ---
> 
> Viewed manually in a web browser.
> 
> 
> File Attachments
> 
> 
> UI Before Change
>   
> https://reviews.apache.org/media/uploaded/files/2020/03/31/e33001a2-d63e-4f81-a4d7-06019a01e001__Screen_Shot_2020-03-30_at_8.13.04_PM.png
> UI After Change
>   
> https://reviews.apache.org/media/uploaded/files/2020/03/31/6b206fcb-b0e1-4836-a2db-e24b1bda3d7f__Screen_Shot_2020-03-30_at_8.12.04_PM.png
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 72269: Added resource limits to the web UI.

2020-03-30 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72269/
---

(Updated March 31, 2020, 3:22 a.m.)


Review request for mesos and Qian Zhang.


Bugs: MESOS-10055
https://issues.apache.org/jira/browse/MESOS-10055


Repository: mesos


Description
---

Added resource limits to the web UI.


Diffs
-

  src/webui/app/agents/agent-executor.html 
7ec56c3bd039ee190c0f1c61ec8957001b52f1dc 


Diff: https://reviews.apache.org/r/72269/diff/3/


Testing
---

Viewed manually in a web browser.


File Attachments (updated)


UI Before Change
  
https://reviews.apache.org/media/uploaded/files/2020/03/31/e33001a2-d63e-4f81-a4d7-06019a01e001__Screen_Shot_2020-03-30_at_8.13.04_PM.png
UI After Change
  
https://reviews.apache.org/media/uploaded/files/2020/03/31/6b206fcb-b0e1-4836-a2db-e24b1bda3d7f__Screen_Shot_2020-03-30_at_8.12.04_PM.png


Thanks,

Greg Mann

Re: Review Request 72269: Added resource limits to the web UI.

2020-03-30 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72269/
---

(Updated March 31, 2020, 3:20 a.m.)


Review request for mesos and Qian Zhang.


Bugs: MESOS-10055
https://issues.apache.org/jira/browse/MESOS-10055


Repository: mesos


Description
---

Added resource limits to the web UI.


Diffs (updated)
-

  src/webui/app/agents/agent-executor.html 
7ec56c3bd039ee190c0f1c61ec8957001b52f1dc 


Diff: https://reviews.apache.org/r/72269/diff/3/

Changes: https://reviews.apache.org/r/72269/diff/2-3/


Testing
---

Viewed manually in a web browser.


File Attachments


UI Before Change
  
https://reviews.apache.org/media/uploaded/files/2020/03/30/60bdc793-bd03-467a-8504-f2686a9b176f__before.png
UI After Change
  
https://reviews.apache.org/media/uploaded/files/2020/03/30/f171975f-0abf-4766-ad8e-42516261f1ec__after.png


Thanks,

Greg Mann

Re: Review Request 72269: Added resource limits to the web UI.

2020-03-30 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72269/#review220132
---




src/webui/app/agents/agent-executor.html
Lines 155-158 (patched)


Maybe we should change `Request` to `Allocated` to be consistent with `GPUs 
(allocated)` and `Disk (allocated)`? For a running task, its resources are 
indeed allocated (i.e. enforaced in cgroups).



src/webui/app/agents/agent-executor.html
Lines 178-179 (original), 194-195 (patched)


Not yours, but I think for a completed task, its resources should already 
be freed rather than still allocated, so maybe we should remove `(allocated)` 
here?


- Qian Zhang


On March 31, 2020, 3:23 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72269/
> ---
> 
> (Updated March 31, 2020, 3:23 a.m.)
> 
> 
> Review request for mesos and Qian Zhang.
> 
> 
> Bugs: MESOS-10055
> https://issues.apache.org/jira/browse/MESOS-10055
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added resource limits to the web UI.
> 
> 
> Diffs
> -
> 
>   src/webui/app/agents/agent-executor.html 
> 7ec56c3bd039ee190c0f1c61ec8957001b52f1dc 
> 
> 
> Diff: https://reviews.apache.org/r/72269/diff/2/
> 
> 
> Testing
> ---
> 
> Viewed manually in a web browser.
> 
> 
> File Attachments
> 
> 
> UI Before Change
>   
> https://reviews.apache.org/media/uploaded/files/2020/03/30/60bdc793-bd03-467a-8504-f2686a9b176f__before.png
> UI After Change
>   
> https://reviews.apache.org/media/uploaded/files/2020/03/30/f171975f-0abf-4766-ad8e-42516261f1ec__after.png
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 72269: Added resource limits to the web UI.

2020-03-30 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72269/#review220124
---



Patch looks great!

Reviews applied: [72269]

Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/jenkins/buildbot.sh

- Mesos Reviewbot


On March 30, 2020, 7:23 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72269/
> ---
> 
> (Updated March 30, 2020, 7:23 p.m.)
> 
> 
> Review request for mesos and Qian Zhang.
> 
> 
> Bugs: MESOS-10055
> https://issues.apache.org/jira/browse/MESOS-10055
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added resource limits to the web UI.
> 
> 
> Diffs
> -
> 
>   src/webui/app/agents/agent-executor.html 
> 7ec56c3bd039ee190c0f1c61ec8957001b52f1dc 
> 
> 
> Diff: https://reviews.apache.org/r/72269/diff/2/
> 
> 
> Testing
> ---
> 
> Viewed manually in a web browser.
> 
> 
> File Attachments
> 
> 
> UI Before Change
>   
> https://reviews.apache.org/media/uploaded/files/2020/03/30/60bdc793-bd03-467a-8504-f2686a9b176f__before.png
> UI After Change
>   
> https://reviews.apache.org/media/uploaded/files/2020/03/30/f171975f-0abf-4766-ad8e-42516261f1ec__after.png
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 72269: Added resource limits to the web UI.

2020-03-30 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72269/
---

(Updated March 30, 2020, 7:23 p.m.)


Review request for mesos and Qian Zhang.


Bugs: MESOS-10055
https://issues.apache.org/jira/browse/MESOS-10055


Repository: mesos


Description
---

Added resource limits to the web UI.


Diffs (updated)
-

  src/webui/app/agents/agent-executor.html 
7ec56c3bd039ee190c0f1c61ec8957001b52f1dc 


Diff: https://reviews.apache.org/r/72269/diff/2/

Changes: https://reviews.apache.org/r/72269/diff/1-2/


Testing
---

Viewed manually in a web browser.


File Attachments (updated)


UI Before Change
  
https://reviews.apache.org/media/uploaded/files/2020/03/30/60bdc793-bd03-467a-8504-f2686a9b176f__before.png
UI After Change
  
https://reviews.apache.org/media/uploaded/files/2020/03/30/f171975f-0abf-4766-ad8e-42516261f1ec__after.png


Thanks,

Greg Mann

Re: Review Request 72269: Added resource limits to the web UI.

2020-03-30 Thread Andrei Sekretenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72269/#review220112
---


Ship it!




Ship It!

- Andrei Sekretenko


On March 25, 2020, 7:20 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72269/
> ---
> 
> (Updated March 25, 2020, 7:20 p.m.)
> 
> 
> Review request for mesos and Qian Zhang.
> 
> 
> Bugs: MESOS-10055
> https://issues.apache.org/jira/browse/MESOS-10055
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added resource limits to the web UI.
> 
> 
> Diffs
> -
> 
>   src/webui/app/agents/agent-executor.html 
> 7ec56c3bd039ee190c0f1c61ec8957001b52f1dc 
> 
> 
> Diff: https://reviews.apache.org/r/72269/diff/1/
> 
> 
> Testing
> ---
> 
> Viewed manually in a web browser.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 72269: Added resource limits to the web UI.

2020-03-25 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72269/#review220084
---



Patch looks great!

Reviews applied: [72269]

Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/jenkins/buildbot.sh

- Mesos Reviewbot


On March 25, 2020, 7:20 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72269/
> ---
> 
> (Updated March 25, 2020, 7:20 p.m.)
> 
> 
> Review request for mesos and Qian Zhang.
> 
> 
> Bugs: MESOS-10055
> https://issues.apache.org/jira/browse/MESOS-10055
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added resource limits to the web UI.
> 
> 
> Diffs
> -
> 
>   src/webui/app/agents/agent-executor.html 
> 7ec56c3bd039ee190c0f1c61ec8957001b52f1dc 
> 
> 
> Diff: https://reviews.apache.org/r/72269/diff/1/
> 
> 
> Testing
> ---
> 
> Viewed manually in a web browser.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>