Re: Review Request 34559: Used the pull model to get estimations from resource estimator.

2015-05-21 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34559/#review84804 --- Ship it! LGTM - Thanks Jie! src/tests/mesos.hpp

Re: Review Request 34559: Used the pull model to get estimations from resource estimator.

2015-05-21 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34559/#review84793 --- Ship it! Ship It! - Vinod Kone On May 21, 2015, 9:26 p.m., Jie Y

Re: Review Request 34559: Used the pull model to get estimations from resource estimator.

2015-05-21 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34559/ --- (Updated May 21, 2015, 9:26 p.m.) Review request for mesos, Benjamin Hindman, N

Re: Review Request 34559: Used the pull model to get estimations from resource estimator.

2015-05-21 Thread Jie Yu
> On May 21, 2015, 7:26 p.m., Vinod Kone wrote: > > src/slave/slave.cpp, line 3986 > > > > > > Can you add a comment here on why we forward periodically instead of > > after every update? Discussed with Vinod offlin

Re: Review Request 34559: Used the pull model to get estimations from resource estimator.

2015-05-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34559/#review84776 --- Patch looks great! Reviews applied: [34559] All tests passed. - M

Re: Review Request 34559: Used the pull model to get estimations from resource estimator.

2015-05-21 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34559/#review84768 --- src/slave/slave.cpp

Review Request 34559: Used the pull model to get estimations from resource estimator.

2015-05-21 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34559/ --- Review request for mesos, Benjamin Hindman, Niklas Nielsen, and Vinod Kone. Bug