Re: Review Request 34721: Added QoS kill executor correction test.

2015-06-16 Thread Niklas Nielsen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34721/
---

(Updated June 16, 2015, 5 p.m.)


Review request for mesos, Bartek Plotka, Jie Yu, Joris Van Remoortere, and 
Vinod Kone.


Changes
---

Wrapped long line


Bugs: MESOS-2653
https://issues.apache.org/jira/browse/MESOS-2653


Repository: mesos


Description
---

See summary


Diffs (updated)
-

  src/tests/mesos.hpp ecdf9109d2e46e8730754eeeb4978863679d56e7 
  src/tests/mesos.cpp 509f9f205fdb1fa094e313b6f0da53000ffecbb3 
  src/tests/oversubscription_tests.cpp 3481ad2eef43c3860642970b4c96494997de8552 

Diff: https://reviews.apache.org/r/34721/diff/


Testing
---

make check (with new qos test)


Thanks,

Niklas Nielsen

Re: Review Request 34721: Added QoS kill executor correction test.

2015-06-16 Thread Niklas Nielsen 


> On June 16, 2015, 4:56 p.m., Jie Yu wrote:
> > src/tests/oversubscription_tests.cpp, line 762
> > 
> >
> > I cannot tell, does this exceed 80 chars?

Good catch - it is too long. Will get that fixed right away.


- Niklas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34721/#review88169
---


On June 16, 2015, 4:52 p.m., Niklas Nielsen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34721/
> ---
> 
> (Updated June 16, 2015, 4:52 p.m.)
> 
> 
> Review request for mesos, Bartek Plotka, Jie Yu, Joris Van Remoortere, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-2653
> https://issues.apache.org/jira/browse/MESOS-2653
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary
> 
> 
> Diffs
> -
> 
>   src/tests/mesos.hpp ecdf9109d2e46e8730754eeeb4978863679d56e7 
>   src/tests/mesos.cpp 509f9f205fdb1fa094e313b6f0da53000ffecbb3 
>   src/tests/oversubscription_tests.cpp 
> 3481ad2eef43c3860642970b4c96494997de8552 
> 
> Diff: https://reviews.apache.org/r/34721/diff/
> 
> 
> Testing
> ---
> 
> make check (with new qos test)
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>

Re: Review Request 34721: Added QoS kill executor correction test.

2015-06-16 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34721/#review88169
---

Ship it!


LGTM!


src/tests/oversubscription_tests.cpp (line 762)


I cannot tell, does this exceed 80 chars?


- Jie Yu


On June 16, 2015, 11:52 p.m., Niklas Nielsen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34721/
> ---
> 
> (Updated June 16, 2015, 11:52 p.m.)
> 
> 
> Review request for mesos, Bartek Plotka, Jie Yu, Joris Van Remoortere, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-2653
> https://issues.apache.org/jira/browse/MESOS-2653
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary
> 
> 
> Diffs
> -
> 
>   src/tests/mesos.hpp ecdf9109d2e46e8730754eeeb4978863679d56e7 
>   src/tests/mesos.cpp 509f9f205fdb1fa094e313b6f0da53000ffecbb3 
>   src/tests/oversubscription_tests.cpp 
> 3481ad2eef43c3860642970b4c96494997de8552 
> 
> Diff: https://reviews.apache.org/r/34721/diff/
> 
> 
> Testing
> ---
> 
> make check (with new qos test)
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>

Re: Review Request 34721: Added QoS kill executor correction test.

2015-06-16 Thread Niklas Nielsen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34721/
---

(Updated June 16, 2015, 4:52 p.m.)


Review request for mesos, Bartek Plotka, Jie Yu, Joris Van Remoortere, and 
Vinod Kone.


Changes
---

Removed unnecessary prefix


Bugs: MESOS-2653
https://issues.apache.org/jira/browse/MESOS-2653


Repository: mesos


Description
---

See summary


Diffs (updated)
-

  src/tests/mesos.hpp ecdf9109d2e46e8730754eeeb4978863679d56e7 
  src/tests/mesos.cpp 509f9f205fdb1fa094e313b6f0da53000ffecbb3 
  src/tests/oversubscription_tests.cpp 3481ad2eef43c3860642970b4c96494997de8552 

Diff: https://reviews.apache.org/r/34721/diff/


Testing
---

make check (with new qos test)


Thanks,

Niklas Nielsen

Re: Review Request 34721: Added QoS kill executor correction test.

2015-06-16 Thread Niklas Nielsen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34721/
---

(Updated June 16, 2015, 4:50 p.m.)


Review request for mesos, Bartek Plotka, Jie Yu, Joris Van Remoortere, and 
Vinod Kone.


Changes
---

Addressed comments from Jie


Bugs: MESOS-2653
https://issues.apache.org/jira/browse/MESOS-2653


Repository: mesos


Description
---

See summary


Diffs (updated)
-

  src/tests/mesos.hpp ecdf9109d2e46e8730754eeeb4978863679d56e7 
  src/tests/mesos.cpp 509f9f205fdb1fa094e313b6f0da53000ffecbb3 
  src/tests/oversubscription_tests.cpp 3481ad2eef43c3860642970b4c96494997de8552 

Diff: https://reviews.apache.org/r/34721/diff/


Testing
---

make check (with new qos test)


Thanks,

Niklas Nielsen

Re: Review Request 34721: Added QoS kill executor correction test.

2015-06-16 Thread Niklas Nielsen 


> On June 16, 2015, 2:31 p.m., Jie Yu wrote:
> > src/tests/mesos.hpp, line 205
> > 
> >
> > Can you instead add a overload for qosController only (similar to what 
> > we did for resourceEstimator above)?

Done


> On June 16, 2015, 2:31 p.m., Jie Yu wrote:
> > src/tests/oversubscription_tests.cpp, lines 827-834
> > 
> >
> > can you use 'createTask' to construct the task? See examples in this 
> > file.

Great suggestion! Should be in now


> On June 16, 2015, 2:31 p.m., Jie Yu wrote:
> > src/tests/oversubscription_tests.cpp, lines 859-861
> > 
> >
> > Use initialization list please:)

Good point - looks much better now


- Niklas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34721/#review88128
---


On June 16, 2015, 1:43 p.m., Niklas Nielsen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34721/
> ---
> 
> (Updated June 16, 2015, 1:43 p.m.)
> 
> 
> Review request for mesos, Bartek Plotka, Jie Yu, Joris Van Remoortere, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-2653
> https://issues.apache.org/jira/browse/MESOS-2653
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary
> 
> 
> Diffs
> -
> 
>   src/tests/mesos.hpp ecdf9109d2e46e8730754eeeb4978863679d56e7 
>   src/tests/mesos.cpp 509f9f205fdb1fa094e313b6f0da53000ffecbb3 
>   src/tests/oversubscription_tests.cpp 
> 3481ad2eef43c3860642970b4c96494997de8552 
> 
> Diff: https://reviews.apache.org/r/34721/diff/
> 
> 
> Testing
> ---
> 
> make check (with new qos test)
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>

Re: Review Request 34721: Added QoS kill executor correction test.

2015-06-16 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34721/#review88128
---



src/tests/mesos.hpp (line 205)


Can you instead add a overload for qosController only (similar to what we 
did for resourceEstimator above)?



src/tests/oversubscription_tests.cpp (line 789)


s/KillExecutorQoSCorrection/QoSCorrectionKill/



src/tests/oversubscription_tests.cpp (line 799)


This should be InvokeWithoutArgs

Could you please fix all instances in this file?



src/tests/oversubscription_tests.cpp (line 803)


No need to save this temp variable.



src/tests/oversubscription_tests.cpp (lines 827 - 834)


can you use 'createTask' to construct the task? See examples in this file.



src/tests/oversubscription_tests.cpp (line 842)


You may wanna add
```
.WillRepeatedly(Return());   // Ignore subsequent updates.
```
after the second `.WillOnce`



src/tests/oversubscription_tests.cpp (line 850)


Please kill mesos::slave prefix



src/tests/oversubscription_tests.cpp (lines 859 - 861)


Use initialization list please:)


- Jie Yu


On June 16, 2015, 8:43 p.m., Niklas Nielsen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34721/
> ---
> 
> (Updated June 16, 2015, 8:43 p.m.)
> 
> 
> Review request for mesos, Bartek Plotka, Jie Yu, Joris Van Remoortere, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-2653
> https://issues.apache.org/jira/browse/MESOS-2653
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary
> 
> 
> Diffs
> -
> 
>   src/tests/mesos.hpp ecdf9109d2e46e8730754eeeb4978863679d56e7 
>   src/tests/mesos.cpp 509f9f205fdb1fa094e313b6f0da53000ffecbb3 
>   src/tests/oversubscription_tests.cpp 
> 3481ad2eef43c3860642970b4c96494997de8552 
> 
> Diff: https://reviews.apache.org/r/34721/diff/
> 
> 
> Testing
> ---
> 
> make check (with new qos test)
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>

Re: Review Request 34721: Added QoS kill executor correction test.

2015-06-16 Thread Niklas Nielsen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34721/
---

(Updated June 16, 2015, 1:43 p.m.)


Review request for mesos, Bartek Plotka, Jie Yu, Joris Van Remoortere, and 
Vinod Kone.


Bugs: MESOS-2653
https://issues.apache.org/jira/browse/MESOS-2653


Repository: mesos


Description
---

See summary


Diffs (updated)
-

  src/tests/mesos.hpp ecdf9109d2e46e8730754eeeb4978863679d56e7 
  src/tests/mesos.cpp 509f9f205fdb1fa094e313b6f0da53000ffecbb3 
  src/tests/oversubscription_tests.cpp 3481ad2eef43c3860642970b4c96494997de8552 

Diff: https://reviews.apache.org/r/34721/diff/


Testing
---

make check (with new qos test)


Thanks,

Niklas Nielsen

Re: Review Request 34721: Added QoS kill executor correction test.

2015-06-12 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34721/#review87784
---


Patch looks great!

Reviews applied: [35079, 34631, 34632, 34633, 34719, 34720, 34721]

All tests passed.

- Mesos ReviewBot


On June 12, 2015, 10:37 p.m., Niklas Nielsen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34721/
> ---
> 
> (Updated June 12, 2015, 10:37 p.m.)
> 
> 
> Review request for mesos, Bartek Plotka, Jie Yu, Joris Van Remoortere, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-2653
> https://issues.apache.org/jira/browse/MESOS-2653
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary
> 
> 
> Diffs
> -
> 
>   src/tests/mesos.hpp ecdf9109d2e46e8730754eeeb4978863679d56e7 
>   src/tests/mesos.cpp 509f9f205fdb1fa094e313b6f0da53000ffecbb3 
>   src/tests/oversubscription_tests.cpp 
> e7d94cecb4a668f634e94fb0aba95155dc827510 
> 
> Diff: https://reviews.apache.org/r/34721/diff/
> 
> 
> Testing
> ---
> 
> make check (with new qos test)
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>

Re: Review Request 34721: Added QoS kill executor correction test.

2015-06-12 Thread Niklas Nielsen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34721/
---

(Updated June 12, 2015, 3:37 p.m.)


Review request for mesos, Bartek Plotka, Jie Yu, Joris Van Remoortere, and 
Vinod Kone.


Bugs: MESOS-2653
https://issues.apache.org/jira/browse/MESOS-2653


Repository: mesos


Description
---

See summary


Diffs (updated)
-

  src/tests/mesos.hpp ecdf9109d2e46e8730754eeeb4978863679d56e7 
  src/tests/mesos.cpp 509f9f205fdb1fa094e313b6f0da53000ffecbb3 
  src/tests/oversubscription_tests.cpp e7d94cecb4a668f634e94fb0aba95155dc827510 

Diff: https://reviews.apache.org/r/34721/diff/


Testing
---

make check (with new qos test)


Thanks,

Niklas Nielsen

Re: Review Request 34721: Added QoS kill executor correction test.

2015-06-11 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34721/#review87663
---


Patch looks great!

Reviews applied: [35079, 34631, 34632, 34633, 34719, 34720, 34721]

All tests passed.

- Mesos ReviewBot


On June 11, 2015, 10:58 p.m., Niklas Nielsen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34721/
> ---
> 
> (Updated June 11, 2015, 10:58 p.m.)
> 
> 
> Review request for mesos, Bartek Plotka, Jie Yu, Joris Van Remoortere, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-2653
> https://issues.apache.org/jira/browse/MESOS-2653
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary
> 
> 
> Diffs
> -
> 
>   src/tests/mesos.hpp e19ef984f9e4696bd405027d6f19756cf23d0df2 
>   src/tests/mesos.cpp 5e574c5aa79d548e5730db021b0e8b77d27f220b 
>   src/tests/oversubscription_tests.cpp 
> e8ae053dd9cd712e49bd2830e414b7a3d99c20ca 
> 
> Diff: https://reviews.apache.org/r/34721/diff/
> 
> 
> Testing
> ---
> 
> make check (with new qos test)
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>

Re: Review Request 34721: Added QoS kill executor correction test.

2015-06-11 Thread Niklas Nielsen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34721/
---

(Updated June 11, 2015, 3:58 p.m.)


Review request for mesos, Bartek Plotka, Jie Yu, Joris Van Remoortere, and 
Vinod Kone.


Bugs: MESOS-2653
https://issues.apache.org/jira/browse/MESOS-2653


Repository: mesos


Description
---

See summary


Diffs (updated)
-

  src/tests/mesos.hpp e19ef984f9e4696bd405027d6f19756cf23d0df2 
  src/tests/mesos.cpp 5e574c5aa79d548e5730db021b0e8b77d27f220b 
  src/tests/oversubscription_tests.cpp e8ae053dd9cd712e49bd2830e414b7a3d99c20ca 

Diff: https://reviews.apache.org/r/34721/diff/


Testing
---

make check (with new qos test)


Thanks,

Niklas Nielsen

Re: Review Request 34721: Added QoS kill executor correction test.

2015-06-04 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34721/#review86731
---


Patch looks great!

Reviews applied: [35079, 34631, 34632, 34633, 34719, 34720, 34721]

All tests passed.

- Mesos ReviewBot


On June 4, 2015, 9:25 p.m., Niklas Nielsen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34721/
> ---
> 
> (Updated June 4, 2015, 9:25 p.m.)
> 
> 
> Review request for mesos, Bartek Plotka, Jie Yu, Joris Van Remoortere, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-2653
> https://issues.apache.org/jira/browse/MESOS-2653
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary
> 
> 
> Diffs
> -
> 
>   src/tests/mesos.hpp 7e134b7d938e149504a70b77fe617ddc5a192f66 
>   src/tests/mesos.cpp d3a8bb70478993883f34804c8e2d7559d16c3538 
>   src/tests/oversubscription_tests.cpp 
> 43a13eec4aab564f84eadb99970b041faa0379f8 
> 
> Diff: https://reviews.apache.org/r/34721/diff/
> 
> 
> Testing
> ---
> 
> make check (with new qos test)
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>

Re: Review Request 34721: Added QoS kill executor correction test.

2015-06-04 Thread Niklas Nielsen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34721/
---

(Updated June 4, 2015, 2:25 p.m.)


Review request for mesos, Bartek Plotka, Jie Yu, Joris Van Remoortere, and 
Vinod Kone.


Changes
---

Kicking off new build from build bot


Bugs: MESOS-2653
https://issues.apache.org/jira/browse/MESOS-2653


Repository: mesos


Description
---

See summary


Diffs (updated)
-

  src/tests/mesos.hpp 7e134b7d938e149504a70b77fe617ddc5a192f66 
  src/tests/mesos.cpp d3a8bb70478993883f34804c8e2d7559d16c3538 
  src/tests/oversubscription_tests.cpp 43a13eec4aab564f84eadb99970b041faa0379f8 

Diff: https://reviews.apache.org/r/34721/diff/


Testing
---

make check (with new qos test)


Thanks,

Niklas Nielsen

Re: Review Request 34721: Added QoS kill executor correction test.

2015-06-04 Thread Niklas Nielsen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34721/
---

(Updated June 4, 2015, 10:43 a.m.)


Review request for mesos, Bartek Plotka, Jie Yu, Joris Van Remoortere, and 
Vinod Kone.


Bugs: MESOS-2653
https://issues.apache.org/jira/browse/MESOS-2653


Repository: mesos


Description
---

See summary


Diffs (updated)
-

  src/tests/mesos.hpp 7e134b7d938e149504a70b77fe617ddc5a192f66 
  src/tests/mesos.cpp d3a8bb70478993883f34804c8e2d7559d16c3538 
  src/tests/oversubscription_tests.cpp 43a13eec4aab564f84eadb99970b041faa0379f8 

Diff: https://reviews.apache.org/r/34721/diff/


Testing
---

make check (with new qos test)


Thanks,

Niklas Nielsen

Re: Review Request 34721: Added QoS kill executor correction test.

2015-06-02 Thread Niklas Nielsen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34721/
---

(Updated June 2, 2015, 9:30 p.m.)


Review request for mesos, Bartek Plotka, Jie Yu, Joris Van Remoortere, and 
Vinod Kone.


Changes
---

Rebased


Bugs: MESOS-2653
https://issues.apache.org/jira/browse/MESOS-2653


Repository: mesos


Description
---

See summary


Diffs (updated)
-

  src/tests/mesos.hpp aeeed61ea987963345a8b5c6e09d14e51098bb2e 
  src/tests/mesos.cpp d3a8bb70478993883f34804c8e2d7559d16c3538 
  src/tests/oversubscription_tests.cpp f047b90d8f0b4dfe7e6cad6dc58909451e9f894b 

Diff: https://reviews.apache.org/r/34721/diff/


Testing
---

make check (with new qos test)


Thanks,

Niklas Nielsen

Review Request 34721: Added QoS kill executor correction test.

2015-05-27 Thread Niklas Nielsen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34721/
---

Review request for mesos, Bartek Plotka, Jie Yu, Joris Van Remoortere, and 
Vinod Kone.


Bugs: MESOS-2653
https://issues.apache.org/jira/browse/MESOS-2653


Repository: mesos


Description
---

See summary


Diffs
-

  src/tests/mesos.hpp b8f7a2f9236166e42421d926718af8d45e857eba 
  src/tests/mesos.cpp 1d5639c85517229f3396b40f2d8bd421b2ed7325 
  src/tests/oversubscription_tests.cpp 75c25b04c1e6a8e0e7e8fd55440743fe1699af88 

Diff: https://reviews.apache.org/r/34721/diff/


Testing
---

make check (with new qos test)


Thanks,

Niklas Nielsen