Re: Review Request 34736: Implemented 'updateSlave()' call in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34736/#review85661 --- Patch looks great! Reviews applied: [34729, 34730, 34736] All test

Re: Review Request 34736: Implemented 'updateSlave()' call in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34736/#review85658 --- Ship it! Ship It! - Niklas Nielsen On May 28, 2015, 5:31 p.m., V

Re: Review Request 34736: Implemented 'updateSlave()' call in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34736/ --- (Updated May 29, 2015, 12:31 a.m.) Review request for mesos, Jie Yu, Joris Van

Re: Review Request 34736: Implemented 'updateSlave()' call in the master.

> On May 28, 2015, 8:21 p.m., Niklas Nielsen wrote: > > src/master/master.cpp, line 3471 > > > > > > Do we use semi-colon in log lines? Have mostly seen ':' > > > > Want to add the resources which are now _no

Re: Review Request 34736: Implemented 'updateSlave()' call in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34736/#review85604 --- Looks good. One high level comment is that we may need to _not_ type

Review Request 34736: Implemented 'updateSlave()' call in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34736/ --- Review request for mesos, Jie Yu, Joris Van Remoortere, and Niklas Nielsen. Bug