Re: Review Request 34748: Defined protobuf for usage returned by Resource Monitor. Reused ResourceUsage

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34748/#review86298 --- Ship it! Ship It! - Jie Yu On June 2, 2015, 10:06 p.m., Bartek P

Re: Review Request 34748: Defined protobuf for usage returned by Resource Monitor. Reused ResourceUsage

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34748/#review86297 --- Ship it! Ship It! - Niklas Nielsen On June 2, 2015, 3:06 p.m., B

Re: Review Request 34748: Defined protobuf for usage returned by Resource Monitor. Reused ResourceUsage

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34748/ --- (Updated June 2, 2015, 10:06 p.m.) Review request for mesos, Ben Mahler, Jie Yu

Re: Review Request 34748: Defined protobuf for usage returned by Resource Monitor. Reused ResourceUsage. Pass ResourceUsage to ResourceEstimator

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34748/#review86276 --- Patch looks great! Reviews applied: [34816, 34662, 34748] All test

Re: Review Request 34748: Defined protobuf for usage returned by Resource Monitor. Reused ResourceUsage. Pass ResourceUsage to ResourceEstimator

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34748/ --- (Updated June 2, 2015, 8:16 p.m.) Review request for mesos, Ben Mahler, Jie Yu,

Re: Review Request 34748: Defined protobuf for usage returned by Resource Monitor. Reused ResourceUsage. Pass ResourceUsage to ResourceEstimator

> On June 1, 2015, 9:40 p.m., Ben Mahler wrote: > > include/mesos/mesos.proto, lines 577-580 > > > > > > We've lost the important information (what does it mean for these to be > > unset?). Could you revert the commen

Re: Review Request 34748: Defined protobuf for usage returned by Resource Monitor. Reused ResourceUsage. Pass ResourceUsage to ResourceEstimator

> On June 1, 2015, 9:40 p.m., Ben Mahler wrote: > > include/mesos/mesos.proto, lines 577-580 > > > > > > We've lost the important information (what does it mean for these to be > > unset?). Could you revert the commen

Re: Review Request 34748: Defined protobuf for usage returned by Resource Monitor. Reused ResourceUsage. Pass ResourceUsage to ResourceEstimator

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34748/ --- (Updated June 2, 2015, 7:40 p.m.) Review request for mesos, Ben Mahler, Jie Yu,

Re: Review Request 34748: Defined protobuf for usage returned by Resource Monitor. Reused ResourceUsage. Pass ResourceUsage to ResourceEstimator

> On June 1, 2015, 9:58 p.m., Jie Yu wrote: > > include/mesos/mesos.proto, line 578 > > > > > > I think we also need to know the total resources allocated to the > > container. For instance, one may want to know the u

Re: Review Request 34748: Defined protobuf for usage returned by Resource Monitor. Reused ResourceUsage. Pass ResourceUsage to ResourceEstimator

> On June 1, 2015, 2:58 p.m., Jie Yu wrote: > > include/mesos/mesos.proto, line 578 > > > > > > I think we also need to know the total resources allocated to the > > container. For instance, one may want to know the u

Re: Review Request 34748: Defined protobuf for usage returned by Resource Monitor. Reused ResourceUsage. Pass ResourceUsage to ResourceEstimator

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34748/#review86098 --- include/mesos/mesos.proto

Re: Review Request 34748: Defined protobuf for usage returned by Resource Monitor. Reused ResourceUsage. Pass ResourceUsage to ResourceEstimator

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34748/#review86092 --- High level looks good, just some minor comments. include/mesos/mes

Re: Review Request 34748: Defined protobuf for usage returned by Resource Monitor. Reused ResourceUsage. Pass ResourceUsage to ResourceEstimator

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34748/#review86088 --- LGTM include/mesos/mesos.proto

Re: Review Request 34748: Defined protobuf for usage returned by Resource Monitor. Reused ResourceUsage. Pass ResourceUsage to ResourceEstimator

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34748/#review85965 --- Patch looks great! Reviews applied: [34816, 34662, 34748] All test

Re: Review Request 34748: Defined protobuf for usage returned by Resource Monitor. Reused ResourceUsage. Pass ResourceUsage to ResourceEstimator

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34748/ --- (Updated June 1, 2015, 8:31 a.m.) Review request for mesos, Jie Yu, Joris Van R

Re: Review Request 34748: Defined protobuf for usage returned by Resource Monitor. Reused ResourceUsage. Pass ResourceUsage to ResourceEstimator

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34748/ --- (Updated June 1, 2015, 8:15 a.m.) Review request for mesos, Jie Yu, Joris Van R

Re: Review Request 34748: Defined protobuf for usage returned by Resource Monitor. Reused ResourceUsage. Pass ResourceUsage to ResourceEstimator

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34748/#review85601 --- Patch looks great! Reviews applied: [34662, 34748] All tests passe

Re: Review Request 34748: Defined protobuf for usage returned by Resource Monitor. Reused ResourceUsage. Pass ResourceUsage to ResourceEstimator

> On May 28, 2015, 6:12 p.m., Niklas Nielsen wrote: > > This will change the resource estimator patch set too - do you want to make > > them dependent on this one? This patch depents on Resource Estimator modularization. (: - Bartek --

Re: Review Request 34748: Defined protobuf for usage returned by Resource Monitor. Reused ResourceUsage. Pass ResourceUsage to ResourceEstimator

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34748/ --- (Updated May 28, 2015, 6:41 p.m.) Review request for mesos, Jie Yu, Joris Van R

Re: Review Request 34748: Defined protobuf for usage returned by Resource Monitor. Reused ResourceUsage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34748/#review85585 --- This will change the resource estimator patch set too - do you want

Re: Review Request 34748: Defined protobuf for usage returned by Resource Monitor. Reused ResourceUsage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34748/#review85541 --- Patch looks great! Reviews applied: [34748] All tests passed. - M

Re: Review Request 34748: Defined protobuf for usage returned by Resource Monitor. Reused ResourceUsage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34748/ --- (Updated May 28, 2015, 2:37 a.m.) Review request for mesos, Jie Yu, Joris Van R

Review Request 34748: Defined protobuf for usage returned by Resource Monitor. Reused ResourceUsage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34748/ --- Review request for mesos, Jie Yu, Joris Van Remoortere, Niklas Nielsen, Szymon K