Re: Review Request 34944: Used flags validation to handle --help.
> On June 2, 2015, 3:54 p.m., Marco Massenzio wrote: > > Sweet! > > > > Only comment is that this does not give the client of FlagsBase an option > > as to the behavior of --help (ie, it prints and exit: like it or lump it :). > > > > Which is perfectly fine, IMO, but was wondering whether this was too > > restrictive? > > (I haven't seen any other pattern in the 10+ refactorings I've done - so > > this should be just fine) Yeah, I'm not convinced this is the way we want to do this, more that it's an easy MVP with a flags validator (which motivated me to dust off my old flags validation patch). I'm going to discard this review for now while someone actually puts a little more thought into this. - Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34944/#review86231 --- On June 2, 2015, 2:46 p.m., Benjamin Hindman wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34944/ > --- > > (Updated June 2, 2015, 2:46 p.m.) > > > Review request for mesos and Marco Massenzio. > > > Repository: mesos > > > Description > --- > > This is one possible way of handling processing --help. Also, this is missing > a test. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp > 61a405f225d14acbc38a80d35570426cb05a3d0a > > Diff: https://reviews.apache.org/r/34944/diff/ > > > Testing > --- > > make check > > > Thanks, > > Benjamin Hindman > >
Re: Review Request 34944: Used flags validation to handle --help.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34944/#review86231 --- Ship it! Sweet! Only comment is that this does not give the client of FlagsBase an option as to the behavior of --help (ie, it prints and exit: like it or lump it :). Which is perfectly fine, IMO, but was wondering whether this was too restrictive? (I haven't seen any other pattern in the 10+ refactorings I've done - so this should be just fine) - Marco Massenzio On June 2, 2015, 2:46 p.m., Benjamin Hindman wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34944/ > --- > > (Updated June 2, 2015, 2:46 p.m.) > > > Review request for mesos and Marco Massenzio. > > > Repository: mesos > > > Description > --- > > This is one possible way of handling processing --help. Also, this is missing > a test. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp > 61a405f225d14acbc38a80d35570426cb05a3d0a > > Diff: https://reviews.apache.org/r/34944/diff/ > > > Testing > --- > > make check > > > Thanks, > > Benjamin Hindman > >
Re: Review Request 34944: Used flags validation to handle --help.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34944/#review86229 --- Patch looks great! Reviews applied: [34943, 34944] All tests passed. - Mesos ReviewBot On June 2, 2015, 2:46 p.m., Benjamin Hindman wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34944/ > --- > > (Updated June 2, 2015, 2:46 p.m.) > > > Review request for mesos and Marco Massenzio. > > > Repository: mesos > > > Description > --- > > This is one possible way of handling processing --help. Also, this is missing > a test. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp > 61a405f225d14acbc38a80d35570426cb05a3d0a > > Diff: https://reviews.apache.org/r/34944/diff/ > > > Testing > --- > > make check > > > Thanks, > > Benjamin Hindman > >
Re: Review Request 34944: Used flags validation to handle --help.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34944/ --- (Updated June 2, 2015, 2:46 p.m.) Review request for mesos and Marco Massenzio. Repository: mesos Description --- This is one possible way of handling processing --help. Also, this is missing a test. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 61a405f225d14acbc38a80d35570426cb05a3d0a Diff: https://reviews.apache.org/r/34944/diff/ Testing --- make check Thanks, Benjamin Hindman
Review Request 34944: Used flags validation to handle --help.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34944/ --- Review request for mesos and Marco Massenzio. Repository: mesos Description --- This is one possible way of handling processing --help. Also, this is missing a test. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 61a405f225d14acbc38a80d35570426cb05a3d0a Diff: https://reviews.apache.org/r/34944/diff/ Testing --- make check Thanks, Benjamin Hindman
