Re: Review Request 35562: Removed unnecessary use of os::ExecEnv.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35562/#review88788 --- Ship it! Ship It! - Till Toenshoff On June 17, 2015, 2:28 p.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35562/ --- (Updated June 17, 2015, 2:28 p.m.) Review request for mesos and Till Toenshoff. Bugs: MESOS-2832 https://issues.apache.org/jira/browse/MESOS-2832 Repository: mesos Description --- See summary. Diffs - src/slave/containerizer/mesos/launch.cpp 2f2d60e2011f60ec711d3b29fd2c157e30c83c34 Diff: https://reviews.apache.org/r/35562/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 35562: Removed unnecessary use of os::ExecEnv.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35562/#review88272
---
Would it make sense to have this RR as being the last in this chain? That way
we could be safely commit earlier RRs without breaking the build.
src/slave/containerizer/mesos/launch.cpp (line 23)
https://reviews.apache.org/r/35562/#comment140702
Seems we can kill this one.
src/slave/containerizer/mesos/launch.cpp (line 36)
https://reviews.apache.org/r/35562/#comment140703
.. and this one :)
src/slave/containerizer/mesos/launch.cpp (line 218)
https://reviews.apache.org/r/35562/#comment140701
Does this TODO refer to a clean environment as being an environment
without anything being set [envp={NULL}]? In any case, does it still make sense
to have this TODO?
- Till Toenshoff
On June 17, 2015, 2:28 p.m., Benjamin Hindman wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35562/
---
(Updated June 17, 2015, 2:28 p.m.)
Review request for mesos and Till Toenshoff.
Bugs: MESOS-2832
https://issues.apache.org/jira/browse/MESOS-2832
Repository: mesos
Description
---
See summary.
Diffs
-
src/slave/containerizer/mesos/launch.cpp
2f2d60e2011f60ec711d3b29fd2c157e30c83c34
Diff: https://reviews.apache.org/r/35562/diff/
Testing
---
make check
Thanks,
Benjamin Hindman
Re: Review Request 35562: Removed unnecessary use of os::ExecEnv.
On June 17, 2015, 8:32 p.m., Till Toenshoff wrote: Would it make sense to have this RR as being the last in this chain? That way we could be safely commit earlier RRs without breaking the build. Oops, I meant to say the above for the next RR (35563) - Till --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35562/#review88272 --- On June 17, 2015, 2:28 p.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35562/ --- (Updated June 17, 2015, 2:28 p.m.) Review request for mesos and Till Toenshoff. Bugs: MESOS-2832 https://issues.apache.org/jira/browse/MESOS-2832 Repository: mesos Description --- See summary. Diffs - src/slave/containerizer/mesos/launch.cpp 2f2d60e2011f60ec711d3b29fd2c157e30c83c34 Diff: https://reviews.apache.org/r/35562/diff/ Testing --- make check Thanks, Benjamin Hindman
Review Request 35562: Removed unnecessary use of os::ExecEnv.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35562/ --- Review request for mesos and Till Toenshoff. Bugs: MESOS-2832 https://issues.apache.org/jira/browse/MESOS-2832 Repository: mesos Description --- See summary. Diffs - src/slave/containerizer/mesos/launch.cpp 2f2d60e2011f60ec711d3b29fd2c157e30c83c34 Diff: https://reviews.apache.org/r/35562/diff/ Testing --- make check Thanks, Benjamin Hindman
