Re: Review Request 35586: Updated LinuxLauncher to receive list of namespaces.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35586/#review89032 --- src/slave/containerizer/linux_launcher.hpp (line 33) https://reviews.apache.org/r/35586/#comment141637 Please use const Optionint as least:) - Jie Yu On June 23, 2015, 7:05 p.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35586/ --- (Updated June 23, 2015, 7:05 p.m.) Review request for mesos, Ian Downes, Jie Yu, and Niklas Nielsen. Bugs: MESOS-2884 https://issues.apache.org/jira/browse/MESOS-2884 Repository: mesos Description --- MesosContainerizer looks up the list of required namespaces by calling Isolator::namespaces() for all enabled isolators and passes on this value to LinuxLauncher. Diffs - src/slave/containerizer/linux_launcher.hpp ec08e24b9ba525893d218636ebddea480e641bbf src/slave/containerizer/linux_launcher.cpp 8eae258d81229e19f8c587f5e023b1df7deed025 src/slave/containerizer/mesos/containerizer.cpp 8c102fb7d1f79ee768cb06de3a976ea12f958712 src/tests/isolator_tests.cpp c635a4d5c78d71ca5474993eba57d1f81be9cbf1 src/tests/port_mapping_tests.cpp 6caab134fdbf3894f9fae801daf9491a13888c7d Diff: https://reviews.apache.org/r/35586/diff/ Testing --- make check Thanks, Kapil Arya
Re: Review Request 35586: Updated LinuxLauncher to receive list of namespaces.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35586/#review88910 --- Patch looks great! Reviews applied: [35585, 35586] All tests passed. - Mesos ReviewBot On June 23, 2015, 2:48 a.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35586/ --- (Updated June 23, 2015, 2:48 a.m.) Review request for mesos, Ian Downes, Jie Yu, and Niklas Nielsen. Bugs: MESOS-2884 https://issues.apache.org/jira/browse/MESOS-2884 Repository: mesos Description --- MesosContainerizer looks up the list of required namespaces by calling Isolator::namespaces() for all enabled isolators and passes on this value to LinuxLauncher. Diffs - src/slave/containerizer/linux_launcher.hpp ec08e24b9ba525893d218636ebddea480e641bbf src/slave/containerizer/linux_launcher.cpp 8eae258d81229e19f8c587f5e023b1df7deed025 src/slave/containerizer/mesos/containerizer.cpp 8c102fb7d1f79ee768cb06de3a976ea12f958712 src/tests/isolator_tests.cpp c635a4d5c78d71ca5474993eba57d1f81be9cbf1 Diff: https://reviews.apache.org/r/35586/diff/ Testing --- make check Thanks, Kapil Arya
Re: Review Request 35586: Updated LinuxLauncher to receive list of namespaces.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35586/ --- (Updated June 22, 2015, 10:21 p.m.) Review request for mesos, Ian Downes, Jie Yu, and Niklas Nielsen. Changes --- rebased Bugs: MESOS-2884 https://issues.apache.org/jira/browse/MESOS-2884 Repository: mesos Description --- MesosContainerizer looks up the list of required namespaces by calling Isolator::namespaces() for all enabled isolators and passes on this value to LinuxLauncher. Diffs (updated) - include/mesos/slave/isolator.hpp 18edc030367e42240090f2f3dbc92aec7a4c6234 src/slave/containerizer/isolator.cpp d51ecc9347cafef90c92a6965e37f417b4929e79 src/slave/containerizer/isolators/filesystem/shared.hpp 08c6ffea0e2fada8e0b04f4ab15d8569c5416a8e src/slave/containerizer/isolators/namespaces/pid.hpp 6b24e2990311d0b09b3f6f2bb4ab29ee83fc src/slave/containerizer/isolators/network/port_mapping.hpp ee869ce71a68f51d58159c701d3c5d1e502b src/slave/containerizer/linux_launcher.hpp ec08e24b9ba525893d218636ebddea480e641bbf src/slave/containerizer/linux_launcher.cpp 8eae258d81229e19f8c587f5e023b1df7deed025 src/slave/containerizer/mesos/containerizer.cpp 8c102fb7d1f79ee768cb06de3a976ea12f958712 src/tests/isolator_tests.cpp c635a4d5c78d71ca5474993eba57d1f81be9cbf1 Diff: https://reviews.apache.org/r/35586/diff/ Testing --- make check Thanks, Kapil Arya
Re: Review Request 35586: Updated LinuxLauncher to receive list of namespaces.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35586/ --- (Updated June 22, 2015, 10:48 p.m.) Review request for mesos, Ian Downes, Jie Yu, and Niklas Nielsen. Changes --- rebased Bugs: MESOS-2884 https://issues.apache.org/jira/browse/MESOS-2884 Repository: mesos Description --- MesosContainerizer looks up the list of required namespaces by calling Isolator::namespaces() for all enabled isolators and passes on this value to LinuxLauncher. Diffs (updated) - src/slave/containerizer/linux_launcher.hpp ec08e24b9ba525893d218636ebddea480e641bbf src/slave/containerizer/linux_launcher.cpp 8eae258d81229e19f8c587f5e023b1df7deed025 src/slave/containerizer/mesos/containerizer.cpp 8c102fb7d1f79ee768cb06de3a976ea12f958712 src/tests/isolator_tests.cpp c635a4d5c78d71ca5474993eba57d1f81be9cbf1 Diff: https://reviews.apache.org/r/35586/diff/ Testing --- make check Thanks, Kapil Arya
Re: Review Request 35586: Updated LinuxLauncher to receive list of namespaces.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35586/ --- (Updated June 23, 2015, 12:59 a.m.) Review request for mesos, Ian Downes, Jie Yu, and Niklas Nielsen. Changes --- rebased Bugs: MESOS-2884 https://issues.apache.org/jira/browse/MESOS-2884 Repository: mesos Description --- MesosContainerizer looks up the list of required namespaces by calling Isolator::namespaces() for all enabled isolators and passes on this value to LinuxLauncher. Diffs (updated) - src/slave/containerizer/linux_launcher.hpp ec08e24b9ba525893d218636ebddea480e641bbf src/slave/containerizer/linux_launcher.cpp 8eae258d81229e19f8c587f5e023b1df7deed025 src/slave/containerizer/mesos/containerizer.cpp 8c102fb7d1f79ee768cb06de3a976ea12f958712 src/tests/isolator_tests.cpp c635a4d5c78d71ca5474993eba57d1f81be9cbf1 src/tests/port_mapping_tests.cpp 6caab134fdbf3894f9fae801daf9491a13888c7d Diff: https://reviews.apache.org/r/35586/diff/ Testing --- make check Thanks, Kapil Arya
Re: Review Request 35586: Updated LinuxLauncher to receive list of namespaces.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35586/#review88331 --- Patch looks great! Reviews applied: [35585, 35586] All tests passed. - Mesos ReviewBot On June 18, 2015, 1:23 a.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35586/ --- (Updated June 18, 2015, 1:23 a.m.) Review request for mesos and Niklas Nielsen. Bugs: MESOS-2884 https://issues.apache.org/jira/browse/MESOS-2884 Repository: mesos Description --- MesosContainerizer looks up the list of required namespaces by calling Isolator::namespaces() for all enabled isolators and passes on this value to LinuxLauncher. Diffs - src/slave/containerizer/linux_launcher.hpp ec08e24b9ba525893d218636ebddea480e641bbf src/slave/containerizer/linux_launcher.cpp 8eae258d81229e19f8c587f5e023b1df7deed025 src/slave/containerizer/mesos/containerizer.cpp 8c102fb7d1f79ee768cb06de3a976ea12f958712 src/tests/isolator_tests.cpp c635a4d5c78d71ca5474993eba57d1f81be9cbf1 Diff: https://reviews.apache.org/r/35586/diff/ Testing --- make check Thanks, Kapil Arya
Review Request 35586: Updated LinuxLauncher to receive list of namespaces.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35586/ --- Review request for mesos and Niklas Nielsen. Bugs: MESOS-2884 https://issues.apache.org/jira/browse/MESOS-2884 Repository: mesos Description --- MesosContainerizer looks up the list of required namespaces by calling Isolator::namespaces() for all enabled isolators and passes on this value to LinuxLauncher. Diffs - src/slave/containerizer/linux_launcher.hpp ec08e24b9ba525893d218636ebddea480e641bbf src/slave/containerizer/linux_launcher.cpp 8eae258d81229e19f8c587f5e023b1df7deed025 src/slave/containerizer/mesos/containerizer.cpp 8c102fb7d1f79ee768cb06de3a976ea12f958712 src/tests/isolator_tests.cpp c635a4d5c78d71ca5474993eba57d1f81be9cbf1 Diff: https://reviews.apache.org/r/35586/diff/ Testing --- make check Thanks, Kapil Arya
