Re: Review Request 35687: Added capabilities to state.json

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35687/ --- (Updated July 15, 2015, 5:20 p.m.) Review request for mesos, Marco Massenzio

Re: Review Request 35687: Added capabilities to state.json

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35687/#review91774 --- Patch looks great! Reviews applied: [35687] All tests passed. -

Re: Review Request 35687: Added capabilities to state.json

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35687/#review91508 --- LGTM modulo Alex's reviews. Fix them and I'll commit this for you.

Re: Review Request 35687: Added capabilities to state.json

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35687/#review91436 --- src/master/http.cpp (line 124)

Re: Review Request 35687: Added capabilities to state.json

On June 20, 2015, 10:50 a.m., Alexander Rukletsov wrote: src/master/http.cpp, line 124 https://reviews.apache.org/r/35687/diff/1/?file=988871#file988871line124 Let's make it `foreachvalue` for consistency. Aditi Dixit wrote: Hi, I'm sorry, but I'm unable to understand

Re: Review Request 35687: Added capabilities to state.json

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35687/#review91414 --- Patch looks great! Reviews applied: [35687] All tests passed. -

Re: Review Request 35687: Added capabilities to state.json

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35687/#review91408 --- src/master/http.cpp (lines 124 - 125)

Re: Review Request 35687: Added capabilities to state.json

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35687/ --- (Updated July 12, 2015, 6:25 p.m.) Review request for mesos, Marco Massenzio

Re: Review Request 35687: Added capabilities to state.json

On June 20, 2015, 10:50 a.m., Alexander Rukletsov wrote: src/master/http.cpp, line 124 https://reviews.apache.org/r/35687/diff/1/?file=988871#file988871line124 Let's make it `foreachvalue` for consistency. Hi, I'm sorry, but I'm unable to understand how foreachvalue works. -

Re: Review Request 35687: Added capabilities to state.json

On July 9, 2015, 4:26 p.m., Vinod Kone wrote: src/master/http.cpp, lines 124-125 https://reviews.apache.org/r/35687/diff/2/?file=1003411#file1003411line124 were you not able to use 'foreach' here? foreach(FrameworkInfo::Capability capability,

Re: Review Request 35687: Added capabilities to state.json

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35687/#review91113 --- src/master/http.cpp (lines 124 - 125)

Re: Review Request 35687: Added capabilities to state.json

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35687/#review91128 --- Patch looks great! Reviews applied: [35687] All tests passed. -

Re: Review Request 35687: Added capabilities to state.json

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35687/ --- (Updated July 9, 2015, 4:04 p.m.) Review request for mesos, Marco Massenzio

Review Request 35687: Added capabilities to state.json

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35687/ --- Review request for mesos, Marco Massenzio and Vinod Kone. Bugs: MESOS-2900

Re: Review Request 35687: Added capabilities to state.json

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35687/#review88640 --- src/master/http.cpp (line 124)

Re: Review Request 35687: Added capabilities to state.json

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35687/#review88666 --- Patch looks great! Reviews applied: [35687] All tests passed. -