Re: Review Request 35715: Added revocable resource state validation.

2015-07-16 Thread Michael Park
> On June 21, 2015, 6:47 p.m., Vinod Kone wrote: > > src/common/resources.cpp, lines 479-487 > > > > > > These checks are done in master's validation.cpp > > Michael Park wrote: > Ah sorry, I missed that. > >

Re: Review Request 35715: Added revocable resource state validation.

2015-07-16 Thread Niklas Nielsen
> On June 21, 2015, 11:47 a.m., Vinod Kone wrote: > > src/common/resources.cpp, lines 479-487 > > > > > > These checks are done in master's validation.cpp > > Michael Park wrote: > Ah sorry, I missed that. >

Re: Review Request 35715: Added revocable resource state validation.

2015-06-23 Thread Niklas Nielsen
> On June 21, 2015, 11:47 a.m., Vinod Kone wrote: > > src/common/resources.cpp, lines 479-487 > > > > > > These checks are done in master's validation.cpp > > Michael Park wrote: > Ah sorry, I missed that. >

Re: Review Request 35715: Added revocable resource state validation.

2015-06-22 Thread Michael Park
> On June 21, 2015, 6:47 p.m., Vinod Kone wrote: > > src/common/resources.cpp, lines 479-487 > > > > > > These checks are done in master's validation.cpp > > Michael Park wrote: > Ah sorry, I missed that. > >

Re: Review Request 35715: Added revocable resource state validation.

2015-06-22 Thread Jie Yu
> On June 21, 2015, 6:47 p.m., Vinod Kone wrote: > > src/common/resources.cpp, lines 479-487 > > > > > > These checks are done in master's validation.cpp > > Michael Park wrote: > Ah sorry, I missed that. > >

Re: Review Request 35715: Added revocable resource state validation.

2015-06-21 Thread Michael Park
> On June 21, 2015, 6:47 p.m., Vinod Kone wrote: > > src/common/resources.cpp, lines 479-487 > > > > > > These checks are done in master's validation.cpp > > Michael Park wrote: > Ah sorry, I missed that. > >

Re: Review Request 35715: Added revocable resource state validation.

2015-06-21 Thread Michael Park
> On June 21, 2015, 6:47 p.m., Vinod Kone wrote: > > src/common/resources.cpp, lines 479-487 > > > > > > These checks are done in master's validation.cpp Ah sorry, I missed that. This reminded me of the discussion Ji

Re: Review Request 35715: Added revocable resource state validation.

2015-06-21 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35715/#review88710 --- src/common/resources.cpp (lines 479 - 487)

Re: Review Request 35715: Added revocable resource state validation.

2015-06-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35715/#review88704 --- Patch looks great! Reviews applied: [35715] All tests passed. - M

Re: Review Request 35715: Added revocable resource state validation.

2015-06-21 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35715/ --- (Updated June 21, 2015, 5:10 p.m.) Review request for mesos, Niklas Nielsen and

Review Request 35715: Added revocable resource state validation.

2015-06-21 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35715/ --- Review request for mesos, Niklas Nielsen and Vinod Kone. Repository: mesos De